#5 SDL sound improvements

[Anonymous]

Originally created by: clac...@gmail.com
Originally owned by: clac...@gmail.com

There are reports from some users/developers that the current SDL sound support doesn't sound quite right.

Ayla has worked on a new mixer (diff attached, which includes non-sound changes too) (full code http://crapouillou.net/~paul/gnuboy-src.tar.gz ) as part of the OpenDingux port.

The diff makes of of Unix semaphore.h and sem_t type which limits portability.

[Anonymous]

Originally posted by: clac...@gmail.com

sound.c has a new mix routine, I'm not clear what it does. It looks like the mixer could be used without the semaphore sync code (note using semaphore rather than timing sleep seems like a much better idea, it looks like this could be #ifdef'd in for platforms that have semaphores and the old sleep code used for platforms without).

[Anonymous]

Originally posted by: pcerc...@gmail.com

Note that SDL provides wrappers around semaphores and monitors, which would probably be a better idea here for the sake of portability.

The patch is quite an ugly hack; a good alternative would be to promote a "push" interface in SDL: http://bugzilla.libsdl.org/show_bug.cgi?id=1511

This would benefit all the emulators that rely on the sound output to synchronize emulation.

[Anonymous]

Originally posted by: clac...@gmail.com

More details at http://boards.dingoonity.org/dingux-releases/gnuboy-for-opendingux/msg38755/#msg38755 also look at SDL_LockMutex(), SDL_UnlockMutex(), and SDL_CondWait()

Labels: -Type-Defect Type-Enhancement