Menu

#18 Make.rules incomplete/wrong; make -r failure

v1.0_(example)
closed
None
5
2019-03-15
2019-03-06
No

Make.rules is not complete; in particular it lacks a %.o: %.S rule. This happens to work due to the builtin make rule to that effect. but building with make -r, or building as a sub-make of an environment that uses make -r (or MAKEFLAGS += -r) causes it to break.

In general, make -r is strongly preferred, and Make.rules seems to have been created explicitly to support this.

To further complicate things, the rule %.S: %.c causes a completely incomprehensible error message. This rule is wrong, it should be %.s: %.c not %.S: %.c.

Finally, the rule %.E: %.c is normally %.i: %.c; .i is the normal extension for preprocessed C source. The equivalent rule for assembly is %.s: %.S.

Proposed patch attached.

1 Attachments

Discussion

  • Nigel Croxon

    Nigel Croxon - 2019-03-15
    • status: open --> closed
    • assigned_to: Nigel Croxon
     
  • Nigel Croxon

    Nigel Croxon - 2019-03-15

    Patch was reviewed and accepted.
    commit de4e5e4e3b6faaf05b0b9a9a7ead882269078dc3

     

Log in to post a comment.