From: Luke B. <luk...@gm...> - 2005-02-05 01:35:20
|
I've just had to fix what I discovered is a release critical bug #1115289. in the function mpg123_add_mp3_args (execfunctions.c) we previously would write: exec_cmd_add_arg(cmd, "-w%s", *convertedfile); whereas the correct way to do it is: exec_cmd_add_arg(cmd, "%s", "-w"); exec_cmd_add_arg(cmd, "%s", *convertedfile); The reason for this is thay they are discrete arguments on the command line and as such must be seperate arguments in the argument array passed to execvp. I've also made changes to the way we invoke mkisofs, oggdec, sox and growisofs inline with this discovery. I've tested everything but growisofs so can one of you confirm it still works fine. I know we're about to release and this may seem risky but I think it's the right thing to do. |