From: Mark G. <mg...@us...> - 2005-12-06 00:38:06
|
Update of /cvsroot/gmod/apollo/src/java/apollo/datamodel In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv12096/src/java/apollo/datamodel Modified Files: Range.java Log Message: woopsy - fixed bug in chado xml writer - forgot to set strand on temporary range for protein in writePepFeatLoc - i think i assume that Range will figure the strand from the start and end - which leads to the question shouldnt it? shouldnt range via setStart setEnd setHigh setLow set its strand accordingly? any reason it shouldnt? of course the range could be wrong in between the setStart & setEnd but who cares as one always follows the other - oh actually that is problematic as its chicken & egg - strand is used in setStart to set high or low - wait no it could still work just do strand check before doing hi & lo - it might be nice as it doesnt seem like it should be necasary to set strand after setting start & end Index: Range.java =================================================================== RCS file: /cvsroot/gmod/apollo/src/java/apollo/datamodel/Range.java,v retrieving revision 1.26 retrieving revision 1.27 diff -C2 -d -r1.26 -r1.27 *** Range.java 12 Nov 2005 00:40:34 -0000 1.26 --- Range.java 6 Dec 2005 00:37:50 -0000 1.27 *************** *** 98,101 **** --- 98,102 ---- public void setStart(int start) { + // check if strand is proper given start value? if (getStrand() == -1) { high = start; |