I don't want logging enabled (in glscene.inc), but the code doesn't compile w/o it.
The problem is inconsistent usage through the code: often the "uses GLSLog" is guarded by "$IFDEF" but calls to GLSLogger.LogXX are NOT.
It seems that GLSLogger() function and TLogSession.AppendLog() are guarded by "$IFDEF" causing direct exit, so the code could always use unit "GLSLog".
Can someone fix this?
Regards,
Gabriel
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Yes, the logging functions are included in code in many places. It was done for debugging purposes and not so easy to remove it from the code. Now there is the Code Site tool in RAD Studio (don't know about one in Lazarus) that can make the same or even better logging with CodeSiteLogging unit. So I'll try to fix the usage of GLSLog in RAD studio package in next release v.1.3.1 of GLScene
PW
Last edit: Pavel Vassiliev 2014-12-01
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Well, I've fixed correct usage of IFDEF GLS_LOGGING in GLSLanguage unit. See as example the LanguageDemo sample from Utilities in current SVN. There should be exit without any log file if GLS_LOGGING not defined. But there are many other places in GLS code to finish the work.
PW
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Gabriel, now it's possible to switch on/off GLS_Logging in GLScene.inc file with or without creating log files for glscene applications. See current SVN version.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I don't want logging enabled (in glscene.inc), but the code doesn't compile w/o it.
The problem is inconsistent usage through the code: often the "uses GLSLog" is guarded by "$IFDEF" but calls to GLSLogger.LogXX are NOT.
It seems that GLSLogger() function and TLogSession.AppendLog() are guarded by "$IFDEF" causing direct exit, so the code could always use unit "GLSLog".
Can someone fix this?
Regards,
Gabriel
Yes, the logging functions are included in code in many places. It was done for debugging purposes and not so easy to remove it from the code. Now there is the Code Site tool in RAD Studio (don't know about one in Lazarus) that can make the same or even better logging with CodeSiteLogging unit. So I'll try to fix the usage of GLSLog in RAD studio package in next release v.1.3.1 of GLScene
PW
Last edit: Pavel Vassiliev 2014-12-01
I just need to be able to compile w/o logging.
Thanks,
Gabriel
Well, I've fixed correct usage of IFDEF GLS_LOGGING in GLSLanguage unit. See as example the LanguageDemo sample from Utilities in current SVN. There should be exit without any log file if GLS_LOGGING not defined. But there are many other places in GLS code to finish the work.
PW
Gabriel, now it's possible to switch on/off GLS_Logging in GLScene.inc file with or without creating log files for glscene applications. See current SVN version.
Thanks!
While you're at it, see the other bmp/font message; I'm glad I can contribute at least a minimal issue.