Menu

#43 const correctness with the OGL 4.4 specs

1.11.0
closed
nobody
None
5
2015-01-24
2013-10-08
Anonymous
No

There are a couple of wrong types at the function parameters.
I validated them being wrong by checking the OpenGL 4.4 Specs(registry -> gl.xml).

I attached an svn diff.

1 Attachments

Discussion

  • Nigel Stewart

    Nigel Stewart - 2013-12-09

    Thanks for the patch.

     
  • Polarina

    Polarina - 2014-01-08

    This patch is missing a fix to GLDEBUGPROC and GLDEBUGPROCARB. The userParam argument is a const void pointer.

     
  • Nigel Stewart

    Nigel Stewart - 2014-01-09

    Fixed GLDEBUGPROC and GLDEBUGPROCARB...

    $ egrep GLDEBUGPROC[^A] include/GL/
    include/GL/glew.h:typedef void (APIENTRY
    GLDEBUGPROC)(GLenum source, GLenum type, GLuint id, GLenum severity, GLsizei length, const GLchar message, const void userParam);
    include/GL/glew.h:typedef void (GLAPIENTRY * PFNGLDEBUGMESSAGECALLBACKPROC) (GLDEBUGPROC callback, const void *userParam);

    $ grep GLDEBUGPROCARB include/GL/
    include/GL/glew.h:typedef void (APIENTRY
    GLDEBUGPROCARB)(GLenum source, GLenum type, GLuint id, GLenum severity, GLsizei length, const GLchar message, const void userParam);
    include/GL/glew.h:typedef void (GLAPIENTRY * PFNGLDEBUGMESSAGECALLBACKARBPROC) (GLDEBUGPROCARB callback, const void *userParam);

     
  • Nigel Stewart

    Nigel Stewart - 2014-02-20
    • status: open --> pending
     
  • Nigel Stewart

    Nigel Stewart - 2014-02-20

    Patch applied to git master branch.

     
  • Nigel Stewart

    Nigel Stewart - 2014-08-12
    • Group: 1.10.1 --> 1.11.0
     
  • Nigel Stewart

    Nigel Stewart - 2015-01-24
    • Status: pending --> closed