RE: LADSPA Support

[Richard G. <ric...@st...>]

On Mon, 15 May 2000, Richard W.E. Furse wrote:

> I had taken the approach of modifying glmid/glplugin.c (get_plugin() etc) 
> slightly to add LADSPA support (done & working - and only cuts in if the 
> library cannot be find elsewhere) although the LADSPA-specific loading code 
> is in glmid/glladspa.c. I had put the beginnings of the wrapper plugin in 
> this file too but moving it into plugins/ladspa.c is straightforward if 
> you'd prefer this.

If you want to transparently handle LADSPA plugins modifications of
get_plugin() etc. are necessary (to get the right register() function?).
But the cleaner(?) and most non-intrusive way to do LADSPA is to have
a plugins/ladspa.c which registers all available ladspa plugins (i.e. in
the ladspa.c register() function do iterate through the LADSPA plugins
and do the stuff you put into plugin_get()). The only thing left to fix
in glplugin.c:try_load_plugin() is the
        if (!reg_func && !set)
                goto err;
check to include a standard symbol for LADSPA plugins.

May I see the source (as patch) you did for now?

Richard.

> Is this a silly way to do things?
> 
> -- Richard
> 
> -----Original Message-----
> From:	Richard Guenther [SMTP:ric...@st...]
> Sent:	Monday, May 15, 2000 8:46 AM
> To:	Richard W.E. Furse
> Cc:	GLAME Mailing List (E-mail)
> Subject:	Re: LADSPA Support
> 
> On Sun, 14 May 2000, Richard W.E. Furse wrote:
> 
> > Hi there - I thought I'd join this list and see if I could help out by
> > adding LADSPA support to GLAME. I'm hoping people would find this useful
> > (see http://www.muse.demon.co.uk/ladspa.html).
> >
> > So far I've got as far as patching the GLAME codebase so LADSPA libraries 
> > can be loaded in - basically I've done all the organisational faff 
> required
> > to get into a position where I can start using the API in filter.h (which 
> > would probably have taken any of you people who know the system 
> seconds!).
> >
> > Would people find this code useful once its finished? In this case, 
> should
> > I post it onto this list or should I have CVS access? Also, I'm wondering 
> > if there has been prior debate about these issues - I'd hate to break
> > anything or miss hooks/planning that might already be in place. Perhaps
> > someone has looked at this already anyway? What are people's thoughts 
> here
> > on LADSPA?
> 
> I thought on adding support for LADSPA plugins once there is some more
> documentation about it - and I have some spare coding time. Support for
> LADSPA plugins should be handled just like any other filter in glame -
> f.i. look at the plugins/pipe.c filter which allows you to start external
> programs as glame filter. I dont think you should touch filter.h at all -
> but of course you may convince me if you show the code you already have
> (either try out the patch manager - I'd love to see this working) or just
> post a patch to this mailinglist.
> 
> In principal CVS access is no problem - especially if you dont touch
> anything beyond plugins/ladspa.c - every changes in filter/* though will
> surely get objections from me :)
> 
> Richard.
> 
> >
> > Best wishes,
> >
> > -- Richard
> >
> >
> > _______________________________________________
> > glame-devel mailing list
> > gla...@li...
> > http://lists.sourceforge.net/mailman/listinfo/glame-devel
> >
> 
> --
> Richard Guenther <ric...@st...>
> WWW: http://www.anatom.uni-tuebingen.de/~richi/
> The GLAME Project: http://www.glame.de/
> 
> 
> _______________________________________________
> glame-devel mailing list
> gla...@li...
> http://lists.sourceforge.net/mailman/listinfo/glame-devel
> 

--
Richard Guenther <ric...@st...>
WWW: http://www.anatom.uni-tuebingen.de/~richi/
The GLAME Project: http://www.glame.de/