Menu
▾
▴
gitclipse-devel — Gitclipse development issues
You can subscribe to this list here.
| 2008 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
(113) |
Aug
(56) |
Sep
|
Oct
|
Nov
|
Dec
|
|---|
|
From: Andrew C. <ac...@co...> - 2008-08-04 20:23:30
|
Hey Paul, I was seeing the php errors that you ran into on the website. I think it probably has something to do with a misconfigured sf.net webserver node in which it doesn't look in the current directory path for include files (while the other cluster nodes do). I'm substituting a workaround for both our sites. -- Drew On Mon, 4 Aug 2008, Paul Munson Bethe wrote: > Andrew, > > your changes (648) to GitPull/GitPush have broken the build... > > As we are not exposing those operations in the pre-alpha, I will comment out the calling code in PullPage/PushPage > > Question to all: Why did this not break cruise-control? > > -P > > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > Gitclipse-devel mailing list > Git...@li... > https://lists.sourceforge.net/lists/listinfo/gitclipse-devel > |
|
From: Paul M. B. <pm...@ny...> - 2008-08-04 18:59:39
|
Patrick, There was a bug in DotGitMonitor, in that there was a pre-condition to have a '.git' folder somewhere from the project root and up. (this was assumed, not tested) And, GitProviderPlugin.map should have checked with isManagedByGit before calling out [I have added this logic] However, I believe the problem was with your test. Look at GitProviderPluginTest testIsAssociated:34 You wrote: "//Test mapped project, this should fail because there's no meta info." Then you try to map a project (with no .git dir), and an exeption is thrown (correctly). However, now you fail on exception... [I have fixed this] So, all that remains is to figure out why testRefresh is still failing on the build system It was failing for me, but I fixed it by adding .waitFor() to the end of the processBuilder.start() calls, b/c a separate process is forked, and it is important not to look for .git etc until the creating process finishes. Now it works for me, but not on CC (btw - can we compile with debug info so we can get the line# where the assertion is failing?) -Paul ----- Original Message ----- From: Patrick C Winters <pat...@ny...> Date: Monday, August 4, 2008 2:16 pm Subject: Re: [Gitclipse-devel] pull/push changes To: Andrew Case <ac...@co...> Cc: Paul Munson Bethe <pm...@ny...>, git...@li... > Since Friday night the build was fixed and set to fail with test > errors. Since Saturday night Michelle and I got the tests running > correctly and the build publishing the results. Remember that the > build is using the latest javagit jar, so if your project isn't > compiling locally, you might need to update javagit on your machine. > > Since we got it running, there's been exceptions and failures related > to the DotGitMonitor and Decorator. I'm pretty sure this is related > to tests I created that import and use projects outside the workspace. > Although this was mostly Paul's work, anybody with time can take a > look at it. This should be top priority. We need to support external > projects if gitclipse is going to be useful. > > I sent a link in another thread about IResources, what they represent, > and how to get their java.io.File counterparts. It's in the Eclipse > programmer's guide in the section on IResources. > -- > Patrick > > ----- Original Message ----- > From: Andrew Case <ac...@co...> > Date: Monday, August 4, 2008 1:52 pm > Subject: Re: [Gitclipse-devel] pull/push changes > To: Paul Munson Bethe <pm...@ny...> > Cc: git...@li... > > > It was compiling fine on my machine. I shouldn't have to care about > > > your machine. That's what cruisecontrol is for. My commit didn't > > break > > the CC build, it was already broken. And has been for days on end! > > > This > > makes it impossible for me to commit something and know if it's > going > > to > > break your build or not. > > > > Paul, As mentioned before, it looks like it's your tests that are > > causing > > the failure... please clean it up, ASAP. Otherwise this will get > > worse > > the more people commit. > > > > -- > > Drew > > > > > > > > On Mon, 4 Aug 2008, Paul Munson Bethe wrote: > > > > > > > > Well, on Saturday night, core and UI were building on my machine > > (though > > > tests were failing). > > > > > > Today, UI was failing to even compile due to those changes. I > have > > > > > checked in the commented out version that at least compile. About > > > to > > > have a fixed test that should fix the tests. > > > > > > ----- Original Message ----- > > > From: Andrew Case <ac...@co...> > > > Date: Monday, August 4, 2008 1:18 pm > > > Subject: Re: [Gitclipse-devel] pull/push changes > > > To: Paul Munson Bethe <pm...@ny...> > > > Cc: git...@li... > > > > > > > > >> Did cruisecontrol move somewhere else that I'm aware of? I haven't > > >> seen > > >> it build successfully in days! It was broken way before my changes. > > >> > > >> -- > > >> Drew > > >> > > >> > > >> On Mon, 4 Aug 2008, Paul Munson Bethe wrote: > > >> > > >>> Andrew, > > >>> > > >>> your changes (648) to GitPull/GitPush have broken the build... > > >>> > > >>> As we are not exposing those operations in the pre-alpha, I will > > >> comment out the calling code in PullPage/PushPage > > >>> > > >>> Question to all: Why did this not break cruise-control? > > >>> > > >>> -P > > >>> > > >>> > > >>> ------------------------------------------------------------------------- > > >>> This SF.Net email is sponsored by the Moblin Your Move > Developer's > > challenge > > >>> Build the coolest Linux based applications with Moblin SDK & win > > >> great prizes > > >>> Grand prize is a trip for two to an Open Source event anywhere in > > >> the world > > >>> http://moblin-contest.org/redirect.php?banner_id=100&url=/ > > >>> _______________________________________________ > > >>> Gitclipse-devel mailing list > > >>> Git...@li... > > >>> https://lists.sourceforge.net/lists/listinfo/gitclipse-devel > > >>> > > > > > > > ------------------------------------------------------------------------- > > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > > Build the coolest Linux based applications with Moblin SDK & win > great > > prizes > > Grand prize is a trip for two to an Open Source event anywhere in > the > > world > > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > > _______________________________________________ > > Gitclipse-devel mailing list > > Git...@li... > > https://lists.sourceforge.net/lists/listinfo/gitclipse-devel |
|
From: Paul M. B. <pm...@ny...> - 2008-08-04 18:24:57
|
Ahh... NYU mail cut off the link into 2 parts -- sorry tried a naive click-thru. Working now. ----- Original Message ----- From: Paul Munson Bethe <pm...@ny...> Date: Monday, August 4, 2008 2:22 pm Subject: Re: [Gitclipse-devel] pull/push changes Cc: git...@li... > Hmm... OK - I fixed the ui tests, but the core tests still fail where > Patrick indicated. > > BTW - the link you sent Patrick did not work. > > ----- Original Message ----- > From: Paul Munson Bethe <pm...@ny...> > Date: Monday, August 4, 2008 2:17 pm > Subject: Re: [Gitclipse-devel] pull/push changes > To: Andrew Case <ac...@co...> > Cc: git...@li... > > > > OK - fair enough. > > > > But it did break the compile - so first of all, I am wondering why > > this passed through that stage of CC. > > > > 2nd (amusingly): If I run the build and junit tests, they work for > me. > > (using the fix I just committed) > > > > However they still appear to be broken on Cruise Control: Based on > > > the log, it looks like what I had BEFORE I fixed my tests... > > > > SO, based on #1, and #2 I am wondering if cruise is actually pulling > > > down the new source code? > > > > Patrick/Michelle, can you double check this? > > If the timestamp for .ui.test/.../DecoratorTest.java is not from > after > > 1:30 today, then we have the problem. > > > > -Paul > > > > > > ----- Original Message ----- > > From: Andrew Case <ac...@co...> > > Date: Monday, August 4, 2008 1:53 pm > > Subject: Re: [Gitclipse-devel] pull/push changes > > To: Paul Munson Bethe <pm...@ny...> > > Cc: Andrew Case <ac...@co...>, git...@li... > > > > > > > It was compiling fine on my machine. I shouldn't have to care > about > > > > > your machine. That's what cruisecontrol is for. My commit didn't > > > > break > > > the CC build, it was already broken. And has been for days on > end! > > > > > This > > > makes it impossible for me to commit something and know if it's > > going > > > to > > > break your build or not. > > > > > > Paul, As mentioned before, it looks like it's your tests that are > > > > causing > > > the failure... please clean it up, ASAP. Otherwise this will get > > > > worse > > > the more people commit. > > > > > > -- > > > Drew > > > > > > > > > > > > On Mon, 4 Aug 2008, Paul Munson Bethe wrote: > > > > > > > > > > > Well, on Saturday night, core and UI were building on my machine > > > > (though > > > > tests were failing). > > > > > > > > Today, UI was failing to even compile due to those changes. I > > have > > > > > > > checked in the commented out version that at least compile. > About > > > > > to > > > > have a fixed test that should fix the tests. > > > > > > > > ----- Original Message ----- > > > > From: Andrew Case <ac...@co...> > > > > Date: Monday, August 4, 2008 1:18 pm > > > > Subject: Re: [Gitclipse-devel] pull/push changes > > > > To: Paul Munson Bethe <pm...@ny...> > > > > Cc: git...@li... > > > > > > > > > > > >> Did cruisecontrol move somewhere else that I'm aware of? I haven't > > > >> seen > > > >> it build successfully in days! It was broken way before my changes. > > > >> > > > >> -- > > > >> Drew > > > >> > > > >> > > > >> On Mon, 4 Aug 2008, Paul Munson Bethe wrote: > > > >> > > > >>> Andrew, > > > >>> > > > >>> your changes (648) to GitPull/GitPush have broken the build... > > > >>> > > > >>> As we are not exposing those operations in the pre-alpha, I will > > > >> comment out the calling code in PullPage/PushPage > > > >>> > > > >>> Question to all: Why did this not break cruise-control? > > > >>> > > > >>> -P > > > >>> > > > >>> > > > >>> ------------------------------------------------------------------------- > > > >>> This SF.Net email is sponsored by the Moblin Your Move > > Developer's > > > challenge > > > >>> Build the coolest Linux based applications with Moblin SDK & win > > > >> great prizes > > > >>> Grand prize is a trip for two to an Open Source event anywhere > in > > > >> the world > > > >>> http://moblin-contest.org/redirect.php?banner_id=100&url=/ > > > >>> _______________________________________________ > > > >>> Gitclipse-devel mailing list > > > >>> Git...@li... > > > >>> https://lists.sourceforge.net/lists/listinfo/gitclipse-devel > > > >>> > > > > > > > > ------------------------------------------------------------------------- > > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > > Build the coolest Linux based applications with Moblin SDK & win > great > > prizes > > Grand prize is a trip for two to an Open Source event anywhere in > the > > world > > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > > _______________________________________________ > > Gitclipse-devel mailing list > > Git...@li... > > https://lists.sourceforge.net/lists/listinfo/gitclipse-devel > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great > prizes > Grand prize is a trip for two to an Open Source event anywhere in the > world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > Gitclipse-devel mailing list > Git...@li... > https://lists.sourceforge.net/lists/listinfo/gitclipse-devel |
|
From: Paul M. B. <pm...@ny...> - 2008-08-04 18:21:34
|
Hmm... OK - I fixed the ui tests, but the core tests still fail where Patrick indicated. BTW - the link you sent Patrick did not work. ----- Original Message ----- From: Paul Munson Bethe <pm...@ny...> Date: Monday, August 4, 2008 2:17 pm Subject: Re: [Gitclipse-devel] pull/push changes To: Andrew Case <ac...@co...> Cc: git...@li... > OK - fair enough. > > But it did break the compile - so first of all, I am wondering why > this passed through that stage of CC. > > 2nd (amusingly): If I run the build and junit tests, they work for me. > (using the fix I just committed) > > However they still appear to be broken on Cruise Control: Based on > the log, it looks like what I had BEFORE I fixed my tests... > > SO, based on #1, and #2 I am wondering if cruise is actually pulling > down the new source code? > > Patrick/Michelle, can you double check this? > If the timestamp for .ui.test/.../DecoratorTest.java is not from after > 1:30 today, then we have the problem. > > -Paul > > > ----- Original Message ----- > From: Andrew Case <ac...@co...> > Date: Monday, August 4, 2008 1:53 pm > Subject: Re: [Gitclipse-devel] pull/push changes > To: Paul Munson Bethe <pm...@ny...> > Cc: Andrew Case <ac...@co...>, git...@li... > > > > It was compiling fine on my machine. I shouldn't have to care about > > > your machine. That's what cruisecontrol is for. My commit didn't > > break > > the CC build, it was already broken. And has been for days on end! > > > This > > makes it impossible for me to commit something and know if it's > going > > to > > break your build or not. > > > > Paul, As mentioned before, it looks like it's your tests that are > > causing > > the failure... please clean it up, ASAP. Otherwise this will get > > worse > > the more people commit. > > > > -- > > Drew > > > > > > > > On Mon, 4 Aug 2008, Paul Munson Bethe wrote: > > > > > > > > Well, on Saturday night, core and UI were building on my machine > > (though > > > tests were failing). > > > > > > Today, UI was failing to even compile due to those changes. I > have > > > > > checked in the commented out version that at least compile. About > > > to > > > have a fixed test that should fix the tests. > > > > > > ----- Original Message ----- > > > From: Andrew Case <ac...@co...> > > > Date: Monday, August 4, 2008 1:18 pm > > > Subject: Re: [Gitclipse-devel] pull/push changes > > > To: Paul Munson Bethe <pm...@ny...> > > > Cc: git...@li... > > > > > > > > >> Did cruisecontrol move somewhere else that I'm aware of? I haven't > > >> seen > > >> it build successfully in days! It was broken way before my changes. > > >> > > >> -- > > >> Drew > > >> > > >> > > >> On Mon, 4 Aug 2008, Paul Munson Bethe wrote: > > >> > > >>> Andrew, > > >>> > > >>> your changes (648) to GitPull/GitPush have broken the build... > > >>> > > >>> As we are not exposing those operations in the pre-alpha, I will > > >> comment out the calling code in PullPage/PushPage > > >>> > > >>> Question to all: Why did this not break cruise-control? > > >>> > > >>> -P > > >>> > > >>> > > >>> ------------------------------------------------------------------------- > > >>> This SF.Net email is sponsored by the Moblin Your Move > Developer's > > challenge > > >>> Build the coolest Linux based applications with Moblin SDK & win > > >> great prizes > > >>> Grand prize is a trip for two to an Open Source event anywhere in > > >> the world > > >>> http://moblin-contest.org/redirect.php?banner_id=100&url=/ > > >>> _______________________________________________ > > >>> Gitclipse-devel mailing list > > >>> Git...@li... > > >>> https://lists.sourceforge.net/lists/listinfo/gitclipse-devel > > >>> > > > > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great > prizes > Grand prize is a trip for two to an Open Source event anywhere in the > world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > Gitclipse-devel mailing list > Git...@li... > https://lists.sourceforge.net/lists/listinfo/gitclipse-devel |
|
From: Paul M. B. <pm...@ny...> - 2008-08-04 18:17:17
|
OK - fair enough. But it did break the compile - so first of all, I am wondering why this passed through that stage of CC. 2nd (amusingly): If I run the build and junit tests, they work for me. (using the fix I just committed) However they still appear to be broken on Cruise Control: Based on the log, it looks like what I had BEFORE I fixed my tests... SO, based on #1, and #2 I am wondering if cruise is actually pulling down the new source code? Patrick/Michelle, can you double check this? If the timestamp for .ui.test/.../DecoratorTest.java is not from after 1:30 today, then we have the problem. -Paul ----- Original Message ----- From: Andrew Case <ac...@co...> Date: Monday, August 4, 2008 1:53 pm Subject: Re: [Gitclipse-devel] pull/push changes To: Paul Munson Bethe <pm...@ny...> Cc: Andrew Case <ac...@co...>, git...@li... > It was compiling fine on my machine. I shouldn't have to care about > your machine. That's what cruisecontrol is for. My commit didn't > break > the CC build, it was already broken. And has been for days on end! > This > makes it impossible for me to commit something and know if it's going > to > break your build or not. > > Paul, As mentioned before, it looks like it's your tests that are > causing > the failure... please clean it up, ASAP. Otherwise this will get > worse > the more people commit. > > -- > Drew > > > > On Mon, 4 Aug 2008, Paul Munson Bethe wrote: > > > > > Well, on Saturday night, core and UI were building on my machine > (though > > tests were failing). > > > > Today, UI was failing to even compile due to those changes. I have > > > checked in the commented out version that at least compile. About > to > > have a fixed test that should fix the tests. > > > > ----- Original Message ----- > > From: Andrew Case <ac...@co...> > > Date: Monday, August 4, 2008 1:18 pm > > Subject: Re: [Gitclipse-devel] pull/push changes > > To: Paul Munson Bethe <pm...@ny...> > > Cc: git...@li... > > > > > >> Did cruisecontrol move somewhere else that I'm aware of? I haven't > >> seen > >> it build successfully in days! It was broken way before my changes. > >> > >> -- > >> Drew > >> > >> > >> On Mon, 4 Aug 2008, Paul Munson Bethe wrote: > >> > >>> Andrew, > >>> > >>> your changes (648) to GitPull/GitPush have broken the build... > >>> > >>> As we are not exposing those operations in the pre-alpha, I will > >> comment out the calling code in PullPage/PushPage > >>> > >>> Question to all: Why did this not break cruise-control? > >>> > >>> -P > >>> > >>> > >>> ------------------------------------------------------------------------- > >>> This SF.Net email is sponsored by the Moblin Your Move Developer's > challenge > >>> Build the coolest Linux based applications with Moblin SDK & win > >> great prizes > >>> Grand prize is a trip for two to an Open Source event anywhere in > >> the world > >>> http://moblin-contest.org/redirect.php?banner_id=100&url=/ > >>> _______________________________________________ > >>> Gitclipse-devel mailing list > >>> Git...@li... > >>> https://lists.sourceforge.net/lists/listinfo/gitclipse-devel > >>> > > |
|
From: Patrick C W. <pat...@ny...> - 2008-08-04 18:16:13
|
Since Friday night the build was fixed and set to fail with test errors. Since Saturday night Michelle and I got the tests running correctly and the build publishing the results. Remember that the build is using the latest javagit jar, so if your project isn't compiling locally, you might need to update javagit on your machine. Since we got it running, there's been exceptions and failures related to the DotGitMonitor and Decorator. I'm pretty sure this is related to tests I created that import and use projects outside the workspace. Although this was mostly Paul's work, anybody with time can take a look at it. This should be top priority. We need to support external projects if gitclipse is going to be useful. I sent a link in another thread about IResources, what they represent, and how to get their java.io.File counterparts. It's in the Eclipse programmer's guide in the section on IResources. -- Patrick ----- Original Message ----- From: Andrew Case <ac...@co...> Date: Monday, August 4, 2008 1:52 pm Subject: Re: [Gitclipse-devel] pull/push changes To: Paul Munson Bethe <pm...@ny...> Cc: git...@li... > It was compiling fine on my machine. I shouldn't have to care about > your machine. That's what cruisecontrol is for. My commit didn't > break > the CC build, it was already broken. And has been for days on end! > This > makes it impossible for me to commit something and know if it's going > to > break your build or not. > > Paul, As mentioned before, it looks like it's your tests that are > causing > the failure... please clean it up, ASAP. Otherwise this will get > worse > the more people commit. > > -- > Drew > > > > On Mon, 4 Aug 2008, Paul Munson Bethe wrote: > > > > > Well, on Saturday night, core and UI were building on my machine > (though > > tests were failing). > > > > Today, UI was failing to even compile due to those changes. I have > > > checked in the commented out version that at least compile. About > to > > have a fixed test that should fix the tests. > > > > ----- Original Message ----- > > From: Andrew Case <ac...@co...> > > Date: Monday, August 4, 2008 1:18 pm > > Subject: Re: [Gitclipse-devel] pull/push changes > > To: Paul Munson Bethe <pm...@ny...> > > Cc: git...@li... > > > > > >> Did cruisecontrol move somewhere else that I'm aware of? I haven't > >> seen > >> it build successfully in days! It was broken way before my changes. > >> > >> -- > >> Drew > >> > >> > >> On Mon, 4 Aug 2008, Paul Munson Bethe wrote: > >> > >>> Andrew, > >>> > >>> your changes (648) to GitPull/GitPush have broken the build... > >>> > >>> As we are not exposing those operations in the pre-alpha, I will > >> comment out the calling code in PullPage/PushPage > >>> > >>> Question to all: Why did this not break cruise-control? > >>> > >>> -P > >>> > >>> > >>> ------------------------------------------------------------------------- > >>> This SF.Net email is sponsored by the Moblin Your Move Developer's > challenge > >>> Build the coolest Linux based applications with Moblin SDK & win > >> great prizes > >>> Grand prize is a trip for two to an Open Source event anywhere in > >> the world > >>> http://moblin-contest.org/redirect.php?banner_id=100&url=/ > >>> _______________________________________________ > >>> Gitclipse-devel mailing list > >>> Git...@li... > >>> https://lists.sourceforge.net/lists/listinfo/gitclipse-devel > >>> > > > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great > prizes > Grand prize is a trip for two to an Open Source event anywhere in the > world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > Gitclipse-devel mailing list > Git...@li... > https://lists.sourceforge.net/lists/listinfo/gitclipse-devel |
|
From: Andrew C. <ac...@co...> - 2008-08-04 17:52:01
|
It was compiling fine on my machine. I shouldn't have to care about your machine. That's what cruisecontrol is for. My commit didn't break the CC build, it was already broken. And has been for days on end! This makes it impossible for me to commit something and know if it's going to break your build or not. Paul, As mentioned before, it looks like it's your tests that are causing the failure... please clean it up, ASAP. Otherwise this will get worse the more people commit. -- Drew On Mon, 4 Aug 2008, Paul Munson Bethe wrote: > > Well, on Saturday night, core and UI were building on my machine (though > tests were failing). > > Today, UI was failing to even compile due to those changes. I have > checked in the commented out version that at least compile. About to > have a fixed test that should fix the tests. > > ----- Original Message ----- > From: Andrew Case <ac...@co...> > Date: Monday, August 4, 2008 1:18 pm > Subject: Re: [Gitclipse-devel] pull/push changes > To: Paul Munson Bethe <pm...@ny...> > Cc: git...@li... > > >> Did cruisecontrol move somewhere else that I'm aware of? I haven't >> seen >> it build successfully in days! It was broken way before my changes. >> >> -- >> Drew >> >> >> On Mon, 4 Aug 2008, Paul Munson Bethe wrote: >> >>> Andrew, >>> >>> your changes (648) to GitPull/GitPush have broken the build... >>> >>> As we are not exposing those operations in the pre-alpha, I will >> comment out the calling code in PullPage/PushPage >>> >>> Question to all: Why did this not break cruise-control? >>> >>> -P >>> >>> >>> ------------------------------------------------------------------------- >>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge >>> Build the coolest Linux based applications with Moblin SDK & win >> great prizes >>> Grand prize is a trip for two to an Open Source event anywhere in >> the world >>> http://moblin-contest.org/redirect.php?banner_id=100&url=/ >>> _______________________________________________ >>> Gitclipse-devel mailing list >>> Git...@li... >>> https://lists.sourceforge.net/lists/listinfo/gitclipse-devel >>> > |
|
From: Paul M. B. <pm...@ny...> - 2008-08-04 17:25:31
|
Well, on Saturday night, core and UI were building on my machine (though tests were failing). Today, UI was failing to even compile due to those changes. I have checked in the commented out version that at least compile. About to have a fixed test that should fix the tests. ----- Original Message ----- From: Andrew Case <ac...@co...> Date: Monday, August 4, 2008 1:18 pm Subject: Re: [Gitclipse-devel] pull/push changes To: Paul Munson Bethe <pm...@ny...> Cc: git...@li... > Did cruisecontrol move somewhere else that I'm aware of? I haven't > seen > it build successfully in days! It was broken way before my changes. > > -- > Drew > > > On Mon, 4 Aug 2008, Paul Munson Bethe wrote: > > > Andrew, > > > > your changes (648) to GitPull/GitPush have broken the build... > > > > As we are not exposing those operations in the pre-alpha, I will > comment out the calling code in PullPage/PushPage > > > > Question to all: Why did this not break cruise-control? > > > > -P > > > > > > ------------------------------------------------------------------------- > > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > > Build the coolest Linux based applications with Moblin SDK & win > great prizes > > Grand prize is a trip for two to an Open Source event anywhere in > the world > > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > > _______________________________________________ > > Gitclipse-devel mailing list > > Git...@li... > > https://lists.sourceforge.net/lists/listinfo/gitclipse-devel > > |
|
From: Andrew C. <ac...@co...> - 2008-08-04 17:24:39
|
Did cruisecontrol move somewhere else that I'm aware of? I haven't seen it build successfully in days! It was broken way before my changes. -- Drew On Mon, 4 Aug 2008, Paul Munson Bethe wrote: > Andrew, > > your changes (648) to GitPull/GitPush have broken the build... > > As we are not exposing those operations in the pre-alpha, I will comment out the calling code in PullPage/PushPage > > Question to all: Why did this not break cruise-control? > > -P > > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > Gitclipse-devel mailing list > Git...@li... > https://lists.sourceforge.net/lists/listinfo/gitclipse-devel > |
|
From: Andrew C. <ac...@co...> - 2008-08-04 17:24:37
|
I've made a similar announcement. I'll send it out when we're ready to release on Tuesday. -- Drew On Mon, 4 Aug 2008, James Linder wrote: > Hi All, > > This summer, the Open Source Programming class has started two new open > source projects, JavaGit and GitClipse. Today, JavaGit has released its > first official version. I am forwarding the release announcement email sent > to the javagit-users email list. > > We are looking to continue the project and welcome new volunteers. So if the > project sounds interesting, check it out and let us know what you think. > > Regards, > > James Linder > > p.s. Please feel free to forward this to other people and lists who may be > interested. > > > ---------- Forwarded message ---------- > Date: Mon, Aug 4, 2008 at 11:09 AM > Subject: JavaGit Releases Version 0.1.0 Alpha > To: jav...@li... > > > Hello JavaGit Users, > > The JavaGit team has released version 0.1.0 Alpha of the JavaGit API. > Thanks to you for your help with bug reporting and feedback. > > Please see below for the release announcement. > > Regards, > > The JavaGit Team > > ------------------------------------------------------------ > JavaGit Releases Version 0.1.0 Alpha - August 4, 2008 > > The JavaGit team is pleased to announce the release of JavaGit version > 0.1.0 alpha, an API providing access to git repositories from Java > programs. The goal of JavaGit is to bring the power of git to the Java > developer as an API that is intuitive for developers new to git and > developers who are veteran git users. > > JavaGit is engineered to provide the developer with access to the raw > git commands through a command API as well as an object API designed > to represent the .git repository, the working tree and other, familiar > git concepts. JavaGit uses the git binaries installed on the host > machine to proide git functionality and has been designed to easily > accommodate additional methods of access to git repositories. > > JavaGit is released as open source software under the GNU LGPL license. > > For additional information on the JavaGit project, please visit: > > http://www.javagit.com > > > --- > You are currently subscribed to fun-at-cims as: ac...@co... > To unsubscribe send a blank email to > lea...@li... |
|
From: Paul M. B. <pm...@ny...> - 2008-08-04 16:41:49
|
Andrew, your changes (648) to GitPull/GitPush have broken the build... As we are not exposing those operations in the pre-alpha, I will comment out the calling code in PullPage/PushPage Question to all: Why did this not break cruise-control? -P |
|
From: Paul M. B. <pm...@ny...> - 2008-08-04 16:25:00
|
Is it possible to also get this as a popup menu? There are some of us (like me), who tend not to use the repository view too much, and want these actions in the Team menu while doing Java/C++ development. -P ----- Original Message ----- From: Han Chiu <dev...@gm...> Date: Saturday, August 2, 2008 5:50 pm Subject: [Gitclipse-devel] Git Project updates after git checkout To: gitclipse-devel <git...@li...> > hi Guys, I've implemented the Git Checkout Action in repository view. > The > last thing I need is to force a project update, I am just looking for > a > couple quick pointers from you guys about how to obtain the current projects > in the workspace, and do updates on them. Any ideas would be great. > I need to persist the data in the Git repository view so that they > won't get > lost when Eclipse restarts, and if time permits, I can go ahead and > implement other git branch related action. That is why I am asking > for some > quick helps. :) > > -- > Han Chiu > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great > prizes > Grand prize is a trip for two to an Open Source event anywhere in the > world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > Gitclipse-devel mailing list > Git...@li... > https://lists.sourceforge.net/lists/listinfo/gitclipse-devel |
|
From: Patrick W. <pat...@ny...> - 2008-08-04 14:47:20
|
Every CC build pulls the latest jar. If you look, in the most recent build, the compile failed. > -----Original Message----- > From: git...@li... [mailto:gitclipse- > dev...@li...] On Behalf Of Paul Munson Bethe > Sent: Monday, August 04, 2008 10:40 AM > To: git...@li... > Subject: Re: [Gitclipse-devel] Changes to GitStatusResponse api > > > Folks, > > question: when does the new javagit.jar snapshot get pulled in (as in, > if someone fixes our code based on Gurdeep's changes, will it break the > CC build? > > > > ----- Original Message ----- > From: Gurdeep Dhindsa <gs...@ny...> > Date: Sunday, August 3, 2008 3:44 pm > Subject: [Gitclipse-devel] Changes to GitStatusResponse api > To: git...@li... > Cc: javagit-devel <jav...@li...> > > > > Ref: Bug [ 2036823 ] Change *Iterator to *Iterable methods in > > GitStatusResponse > > > > Hi > > > > I have renamed the methods in GitStatusResponse and removed the word > > > > iterator completely from method names. > > You will need to make changes to your gitclipse code accordingly. > > > > e.g. the method that was earlier getNewFilesToCommitIteator() is now > > > > just getFilesToCommit() > > > > thanks > > Gurdeep > > > > New method signatures > > -------------------------------- > > public Iterable<File> getNewFilesToCommit() > > public Iterable<File> getDeletedFilesToCommit() > > public Iterable<File> getModifiedFilesToCommit() > > public Iterable<File> getDeletedFilesNotUpdated() > > public Iterable<File> getModifiedFilesNotUpdated() > > public Iterable<File> getRenamedFilesToCommit() > > public Iterable<File> getUntrackedFiles() > > > > --------------------------------------------------------------------- > ---- > > This SF.Net email is sponsored by the Moblin Your Move Developer's > challenge > > Build the coolest Linux based applications with Moblin SDK & win > great > > prizes > > Grand prize is a trip for two to an Open Source event anywhere in the > > world > > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > > _______________________________________________ > > Gitclipse-devel mailing list > > Git...@li... > > https://lists.sourceforge.net/lists/listinfo/gitclipse-devel > > ----------------------------------------------------------------------- > -- > This SF.Net email is sponsored by the Moblin Your Move Developer's > challenge > Build the coolest Linux based applications with Moblin SDK & win great > prizes > Grand prize is a trip for two to an Open Source event anywhere in the > world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > Gitclipse-devel mailing list > Git...@li... > https://lists.sourceforge.net/lists/listinfo/gitclipse-devel |
|
From: Paul M. B. <pm...@ny...> - 2008-08-04 14:39:40
|
Folks, question: when does the new javagit.jar snapshot get pulled in (as in, if someone fixes our code based on Gurdeep's changes, will it break the CC build? ----- Original Message ----- From: Gurdeep Dhindsa <gs...@ny...> Date: Sunday, August 3, 2008 3:44 pm Subject: [Gitclipse-devel] Changes to GitStatusResponse api To: git...@li... Cc: javagit-devel <jav...@li...> > Ref: Bug [ 2036823 ] Change *Iterator to *Iterable methods in > GitStatusResponse > > Hi > > I have renamed the methods in GitStatusResponse and removed the word > > iterator completely from method names. > You will need to make changes to your gitclipse code accordingly. > > e.g. the method that was earlier getNewFilesToCommitIteator() is now > > just getFilesToCommit() > > thanks > Gurdeep > > New method signatures > -------------------------------- > public Iterable<File> getNewFilesToCommit() > public Iterable<File> getDeletedFilesToCommit() > public Iterable<File> getModifiedFilesToCommit() > public Iterable<File> getDeletedFilesNotUpdated() > public Iterable<File> getModifiedFilesNotUpdated() > public Iterable<File> getRenamedFilesToCommit() > public Iterable<File> getUntrackedFiles() > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great > prizes > Grand prize is a trip for two to an Open Source event anywhere in the > world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > Gitclipse-devel mailing list > Git...@li... > https://lists.sourceforge.net/lists/listinfo/gitclipse-devel |
|
From: <pm...@ny...> - 2008-08-03 19:20:11
|
I should be able to look at this tomorrow, in time for the release. ------Original Message------ From: Patrick Winters To: 'Paul Munson Bethe' Cc: git...@li... Sent: Aug 3, 2008 2:43 PM Subject: dotgitmonitor and decorator refresh Paul, Are you going to get a chance to fix these test failures before Tuesday? They are most certainly related to external projects and are very important for the first release. I've got math hw and final next week so I'm trying to do that, but if need be I'll play with it. Let me know. The Eclipse programmer's guide has a nice section about dealing with IResources and their workspace and filesystem counterparts. http://help.eclipse.org/stable/index.jsp?topic=/org.eclipse.platform.doc.isv /guide/resInt_filesystem.htm -- Patrick Sent via BlackBerry |
|
From: Patrick W. <pat...@ny...> - 2008-08-03 18:43:19
|
Paul, Are you going to get a chance to fix these test failures before Tuesday? They are most certainly related to external projects and are very important for the first release. I've got math hw and final next week so I'm trying to do that, but if need be I'll play with it. Let me know. The Eclipse programmer's guide has a nice section about dealing with IResources and their workspace and filesystem counterparts. http://help.eclipse.org/stable/index.jsp?topic=/org.eclipse.platform.doc.isv /guide/resInt_filesystem.htm -- Patrick |
|
From: Gurdeep D. <gs...@ny...> - 2008-08-03 16:47:24
|
Ref: Bug [ 2036823 ] Change *Iterator to *Iterable methods in GitStatusResponse Hi I have renamed the methods in GitStatusResponse and removed the word iterator completely from method names. You will need to make changes to your gitclipse code accordingly. e.g. the method that was earlier getNewFilesToCommitIteator() is now just getFilesToCommit() thanks Gurdeep New method signatures -------------------------------- public Iterable<File> getNewFilesToCommit() public Iterable<File> getDeletedFilesToCommit() public Iterable<File> getModifiedFilesToCommit() public Iterable<File> getDeletedFilesNotUpdated() public Iterable<File> getModifiedFilesNotUpdated() public Iterable<File> getRenamedFilesToCommit() public Iterable<File> getUntrackedFiles() |
|
From: Michelle S O. <ms...@ny...> - 2008-08-03 16:31:17
|
Hey guys, Just a heads up that I'm going to town on the GitStatusAdapter. The basic idea is to store the results in a form that lends itself more easily to efficient queries, either by status or by file. Rather than writing a new custom method every time we need a different kind of status query, there are going to be a small handful of methods which rely on filters to return the desired GitResources. You'll be able to query based on status (eg, give me all GitResources having this status) or by file. There will also be static factory methods to replace what's becoming a proliferation of constructors. I'm really leery of replacing existing code just yet since there aren't tests, so I'm going to deprecate the old methods and leave it to you guys to switch over to the new ones. I'll implement filters to match the functionality of the old methods and make them available as static classes on GitStatusAdapter, so all you'll have to do is replace your method calls with the new methods/filters and then make sure that nothing is broken (I can try to do that, but it's hard to test functionality that you're not all that familiar with yet). Once you see the code it will hopefully make more sense than this explanation. If you guys decide that you hate it, you can undeprecate the old methods and continue to use those, but I'm hoping I can make this class a little neater. Michelle |
|
From: Patrick W. <pat...@ny...> - 2008-08-03 04:54:17
|
The tests are finally running and holding up our build. It took a lot of effort but Michelle got it going. Please examine this and make sure we are rolling by Tuesday. The update-site is up, so as soon as we resolve these test problems we'll be publishing to the update site again. Paul it looks like DotGitMonitor and DecoratorRefresh are giving problems, will you take a look? I'm trying to resolve the lack of line numbers at the moment. I think DotGitMonitor might have a problem running on projects outside the workspace. I don't remember off the top of my head, but you have to resolve the absolute location a little differently. Make sure you read the IProject javadocs. -- Patrick |
|
From: Michelle S O. <ms...@ny...> - 2008-08-03 03:00:16
|
That is weird, now that you point it out. The argument types to 'put' are bound at compile-time but 'get' seems to ignore generics altogether.. anyone know why that is? Michelle ----- Original Message ----- From: Paul Munson Bethe <pm...@ny...> Date: Saturday, August 2, 2008 10:20 pm Subject: Re: GitFileStatus changes To: Michelle S Osborne <ms...@ny...> Cc: git...@li... > What is interesting about this is the following: > > Map<K,T>.get takes type Object, not K... > > So ResourceLabelProvider.java:86 - I would have expected a compiler > error, since I changed resource.status to return GitResourceStatus - > but no, both compatible with Object... thus the problem. > > Fixed, and checked in now. > > -Paul > > > ----- Original Message ----- > From: Michelle S Osborne <ms...@ny...> > Date: Saturday, August 2, 2008 6:58 pm > Subject: Re: GitFileStatus changes > To: pm...@ny... > Cc: git...@li... > > > > Okay, I guess that makes sense for now. I'm still not sure that the > > > different uses of this enum are ultimately going to represent the > same > > abstraction, but we can always separate them again if that becomes > > apparent. It would have been nice to say something about making the > > > change though, given our discussion in the code review. > > > > The broken functionality is my fault too, because there really > should > > be tests. Once commit and add are release-ready I'm going to focus > > solely on that. We should be able to refactor with confidence. > > > > Michelle > > > > ----- Original Message ----- > > From: pm...@ny... > > Date: Saturday, August 2, 2008 6:31 pm > > Subject: Re: GitFileStatus changes > > To: Michelle S Osborne <ms...@ny...> > > Cc: git...@li... > > > > > Sorry. I thought I tested that, but I guess not... I changed it > > > > because I needed to know about Untracked files, and it didn't make > > > > sense to extend the functionality when there was the similar class. > > > > > > I will fix this tomorrow - I had to go out of town last > night/today, > > > > > and I forgot to make a code review. > > > > > > Also, I think that failing test is my fault. Generally me messing > > > > things up here :( > > > > > > I will sort it all out tomorrow. > > > > > > -Paul > > > > > > ------Original Message------ > > > From: Michelle S Osborne > > > Sender: > > > To: pm...@ny... > > > Cc: git...@li... > > > Sent: Aug 2, 2008 5:37 PM > > > Subject: GitFileStatus changes > > > > > > Paul, > > > > > > Why did you change all uses of GitFileStatus to GitResourceStatus? > > > You > > > asked in a code review if there was a reason why I didn't use it > and > > I > > > answered you. If you weren't satisfied with the answer you could > > have > > > discussed it further rather than taking it upon yourself to > replace > > > > > uses of one with the other. You didn't even create a code review > for > > > > > that changeset, so I didn't get a chance to give you feedback, > like > > > > > for example to tell you that your changes broke the commit > dialog's > > > > > status display. > > > > > > I may add more fields to that enum. I don't have the time to > change > > > > > all of the commit dialog's uses of GitResourceStatus back to > > > GitFileStatus, so if I do need to add fields I'm going to make the > > > > getParentTransition method throw exceptions for them, because I > > doubt > > > that the method will make sense in the context of how I'm planning > > > on > > > using the enum. > > > > > > Michelle > > > > > > > > > Sent via BlackBerry |
|
From: Paul M. B. <pm...@ny...> - 2008-08-03 02:20:43
|
What is interesting about this is the following: Map<K,T>.get takes type Object, not K... So ResourceLabelProvider.java:86 - I would have expected a compiler error, since I changed resource.status to return GitResourceStatus - but no, both compatible with Object... thus the problem. Fixed, and checked in now. -Paul ----- Original Message ----- From: Michelle S Osborne <ms...@ny...> Date: Saturday, August 2, 2008 6:58 pm Subject: Re: GitFileStatus changes To: pm...@ny... Cc: git...@li... > Okay, I guess that makes sense for now. I'm still not sure that the > different uses of this enum are ultimately going to represent the same > abstraction, but we can always separate them again if that becomes > apparent. It would have been nice to say something about making the > change though, given our discussion in the code review. > > The broken functionality is my fault too, because there really should > be tests. Once commit and add are release-ready I'm going to focus > solely on that. We should be able to refactor with confidence. > > Michelle > > ----- Original Message ----- > From: pm...@ny... > Date: Saturday, August 2, 2008 6:31 pm > Subject: Re: GitFileStatus changes > To: Michelle S Osborne <ms...@ny...> > Cc: git...@li... > > > Sorry. I thought I tested that, but I guess not... I changed it > > because I needed to know about Untracked files, and it didn't make > > sense to extend the functionality when there was the similar class. > > > > I will fix this tomorrow - I had to go out of town last night/today, > > > and I forgot to make a code review. > > > > Also, I think that failing test is my fault. Generally me messing > > things up here :( > > > > I will sort it all out tomorrow. > > > > -Paul > > > > ------Original Message------ > > From: Michelle S Osborne > > Sender: > > To: pm...@ny... > > Cc: git...@li... > > Sent: Aug 2, 2008 5:37 PM > > Subject: GitFileStatus changes > > > > Paul, > > > > Why did you change all uses of GitFileStatus to GitResourceStatus? > You > > asked in a code review if there was a reason why I didn't use it and > I > > answered you. If you weren't satisfied with the answer you could > have > > discussed it further rather than taking it upon yourself to replace > > > uses of one with the other. You didn't even create a code review for > > > that changeset, so I didn't get a chance to give you feedback, like > > > for example to tell you that your changes broke the commit dialog's > > > status display. > > > > I may add more fields to that enum. I don't have the time to change > > > all of the commit dialog's uses of GitResourceStatus back to > > GitFileStatus, so if I do need to add fields I'm going to make the > > getParentTransition method throw exceptions for them, because I > doubt > > that the method will make sense in the context of how I'm planning > on > > using the enum. > > > > Michelle > > > > > > Sent via BlackBerry |
|
From: Han C. <dev...@gm...> - 2008-08-03 02:09:10
|
I got it. -- Han Chiu |
|
From: <pm...@ny...> - 2008-08-02 23:17:00
|
Great. Again, I am really sorry. I know how crappy it can be when someone else breaks code you worked hard on. -PB ------Original Message------ From: Michelle S Osborne Sender: To: pm...@ny... Cc: git...@li... Sent: Aug 2, 2008 6:58 PM Subject: Re: GitFileStatus changes Okay, I guess that makes sense for now. I'm still not sure that the different uses of this enum are ultimately going to represent the same abstraction, but we can always separate them again if that becomes apparent. It would have been nice to say something about making the change though, given our discussion in the code review. The broken functionality is my fault too, because there really should be tests. Once commit and add are release-ready I'm going to focus solely on that. We should be able to refactor with confidence. Michelle ----- Original Message ----- From: pm...@ny... Date: Saturday, August 2, 2008 6:31 pm Subject: Re: GitFileStatus changes To: Michelle S Osborne <ms...@ny...> Cc: git...@li... > Sorry. I thought I tested that, but I guess not... I changed it > because I needed to know about Untracked files, and it didn't make > sense to extend the functionality when there was the similar class. > > I will fix this tomorrow - I had to go out of town last night/today, > and I forgot to make a code review. > > Also, I think that failing test is my fault. Generally me messing > things up here :( > > I will sort it all out tomorrow. > > -Paul > > ------Original Message------ > From: Michelle S Osborne > Sender: > To: pm...@ny... > Cc: git...@li... > Sent: Aug 2, 2008 5:37 PM > Subject: GitFileStatus changes > > Paul, > > Why did you change all uses of GitFileStatus to GitResourceStatus? You > asked in a code review if there was a reason why I didn't use it and I > answered you. If you weren't satisfied with the answer you could have > discussed it further rather than taking it upon yourself to replace > uses of one with the other. You didn't even create a code review for > that changeset, so I didn't get a chance to give you feedback, like > for example to tell you that your changes broke the commit dialog's > status display. > > I may add more fields to that enum. I don't have the time to change > all of the commit dialog's uses of GitResourceStatus back to > GitFileStatus, so if I do need to add fields I'm going to make the > getParentTransition method throw exceptions for them, because I doubt > that the method will make sense in the context of how I'm planning on > using the enum. > > Michelle > > > Sent via BlackBerry Sent via BlackBerry |
|
From: Michelle S O. <ms...@ny...> - 2008-08-02 22:58:34
|
Okay, I guess that makes sense for now. I'm still not sure that the different uses of this enum are ultimately going to represent the same abstraction, but we can always separate them again if that becomes apparent. It would have been nice to say something about making the change though, given our discussion in the code review. The broken functionality is my fault too, because there really should be tests. Once commit and add are release-ready I'm going to focus solely on that. We should be able to refactor with confidence. Michelle ----- Original Message ----- From: pm...@ny... Date: Saturday, August 2, 2008 6:31 pm Subject: Re: GitFileStatus changes To: Michelle S Osborne <ms...@ny...> Cc: git...@li... > Sorry. I thought I tested that, but I guess not... I changed it > because I needed to know about Untracked files, and it didn't make > sense to extend the functionality when there was the similar class. > > I will fix this tomorrow - I had to go out of town last night/today, > and I forgot to make a code review. > > Also, I think that failing test is my fault. Generally me messing > things up here :( > > I will sort it all out tomorrow. > > -Paul > > ------Original Message------ > From: Michelle S Osborne > Sender: > To: pm...@ny... > Cc: git...@li... > Sent: Aug 2, 2008 5:37 PM > Subject: GitFileStatus changes > > Paul, > > Why did you change all uses of GitFileStatus to GitResourceStatus? You > asked in a code review if there was a reason why I didn't use it and I > answered you. If you weren't satisfied with the answer you could have > discussed it further rather than taking it upon yourself to replace > uses of one with the other. You didn't even create a code review for > that changeset, so I didn't get a chance to give you feedback, like > for example to tell you that your changes broke the commit dialog's > status display. > > I may add more fields to that enum. I don't have the time to change > all of the commit dialog's uses of GitResourceStatus back to > GitFileStatus, so if I do need to add fields I'm going to make the > getParentTransition method throw exceptions for them, because I doubt > that the method will make sense in the context of how I'm planning on > using the enum. > > Michelle > > > Sent via BlackBerry |
|
From: <pm...@ny...> - 2008-08-02 22:31:11
|
Sorry. I thought I tested that, but I guess not... I changed it because I needed to know about Untracked files, and it didn't make sense to extend the functionality when there was the similar class. I will fix this tomorrow - I had to go out of town last night/today, and I forgot to make a code review. Also, I think that failing test is my fault. Generally me messing things up here :( I will sort it all out tomorrow. -Paul ------Original Message------ From: Michelle S Osborne Sender: To: pm...@ny... Cc: git...@li... Sent: Aug 2, 2008 5:37 PM Subject: GitFileStatus changes Paul, Why did you change all uses of GitFileStatus to GitResourceStatus? You asked in a code review if there was a reason why I didn't use it and I answered you. If you weren't satisfied with the answer you could have discussed it further rather than taking it upon yourself to replace uses of one with the other. You didn't even create a code review for that changeset, so I didn't get a chance to give you feedback, like for example to tell you that your changes broke the commit dialog's status display. I may add more fields to that enum. I don't have the time to change all of the commit dialog's uses of GitResourceStatus back to GitFileStatus, so if I do need to add fields I'm going to make the getParentTransition method throw exceptions for them, because I doubt that the method will make sense in the context of how I'm planning on using the enum. Michelle Sent via BlackBerry |
