ginp-developers — ginp Developers

Re: [Ginp-developers] Latest changes - deployment problems

[Doug C. <do...@cu...>]

Sorry Brian but I have not finished the set up wizard and it does not
work.  Either we need to go back to the tapestry version from Justin or
Someone needs to finish it.

It would be great to update the manual because it was written by someone
that understands the GINP, not a user.  However the code needs to work
first.... Maybe your effort would be better served improving the code
then the manual.

Your error looks like the WebAp server can not load the taglib class. 
Check supported version of JSP and Servet specifications in web.xml and
ginp.tld and for your server. Also check for any start up errors on your
web server.

All the best,

Doug

Brian Burch wrote:
> Doug Culnane wrote:
>   
>> I need to do a
>> mvn clean site site:deploy
>> this updates the public website so let me know when you want it updated
>> and it will do it.
>>
>>     
>
> Don't do it yet, Doug. I'm having some problems deploying the war on my 
> own development system and am worried I might have broken something.
>
>   
>> Will do in due course as I use the head in my own website.
>>     
>
> Take a backup first! Perhaps you could find time to test the new version 
>   with your web site BEFORE updating the public version?
>
> ------------
>
> First, some good news... the latest version serves up my photo's under 
> https url's as well as http, so that problem has gone away.
>
>
> ------------
>
> I think I screwed up my own deployment testing by not clearing all the 
> tomcat files before unpacking the new war. It looked for a while as if 
> it was OK, but I'm not confident about what exactly was running (jsps, 
> etc get compiled into {CATALINA_HOME}/work/).
>
> I've now done a thorough clearout and am having some problems. In 
> particular, I'm quite worried about the setup process I don't think I've 
> broken it, but I can't be certain.
>
> The biggest problem is with ginp.xml. When the new ginp-0.30-SNAPSHOT 
> cannot find ginp.xml, it runs the ginpSetup Tapestry application as 
> intended. I have a good version that worked with the pre-maven war in 
> home/config/ginp.xml, but I can't make setup use my existing file. 
> However, when I manually copy the file to ../ginp/WEB-INF/ginp.xml, it 
> is detected and used properly. I've slogged through a lot of the logic 
> but cannot see what is going wrong yet.
>
> I decided to work through your manual, but I'm not making a lot of sense 
> of it yet. I'd like to update it based on what I can get working here.
>
> I would like to explain four different scenarios (not necessarily in 
> this order):-
>
> 1. Whether someone has downloaded the war, or built it from source with 
> maven.. how to configure it to serve up some of their own pictures using 
> the default home page and the "Basic" demo style.
>
> a) manually, by cloning/updating a sample ginp.xml file (e.g. when the 
> setup application is failing).
>
> b) using the setup application, when I can get it working again.
>
> 2. How to customise the system for one's own web site.
>
> a) using an existing style.
>
> b) by creating a new personalised style.
>
>
> At the moment, I'm keeping my life simple by working on 1a. However, 
> when I choose the w2k4 (or backinblack or textart) demos from index.jsp, 
> it fails. I keep reading the manual to see what you are really saying 
> about the style folders, but seem to be missing something important.
>
> If you have any idea why ...
>
> http://www2.pingtoo.com/ginp/styles/w2k4/ginpservlet?cmd=selectcollection&id=0&nocache=207183762
>
> fails with ...
>
> org.apache.jasper.JasperException: /styles/w2k4/collection.jsp(38,0) 
> Unable to load tag handler class "net.sf.ginp.tags.GetFolderInfo" for 
> tag "ginp:getfolderinfo"
>
> please let me know soon!
>
> Brian
>
>
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys - and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> _______________________________________________
> Ginp-developers mailing list
> Gin...@li...
> https://lists.sourceforge.net/lists/listinfo/ginp-developers
>   

Re: [Ginp-developers] Latest changes - deployment problems

[Brian B. <br...@Pi...>]

Doug Culnane wrote:
> I need to do a
> mvn clean site site:deploy
> this updates the public website so let me know when you want it updated
> and it will do it.
> 

Don't do it yet, Doug. I'm having some problems deploying the war on my 
own development system and am worried I might have broken something.

> Will do in due course as I use the head in my own website.

Take a backup first! Perhaps you could find time to test the new version 
  with your web site BEFORE updating the public version?

------------

First, some good news... the latest version serves up my photo's under 
https url's as well as http, so that problem has gone away.


------------

I think I screwed up my own deployment testing by not clearing all the 
tomcat files before unpacking the new war. It looked for a while as if 
it was OK, but I'm not confident about what exactly was running (jsps, 
etc get compiled into {CATALINA_HOME}/work/).

I've now done a thorough clearout and am having some problems. In 
particular, I'm quite worried about the setup process I don't think I've 
broken it, but I can't be certain.

The biggest problem is with ginp.xml. When the new ginp-0.30-SNAPSHOT 
cannot find ginp.xml, it runs the ginpSetup Tapestry application as 
intended. I have a good version that worked with the pre-maven war in 
home/config/ginp.xml, but I can't make setup use my existing file. 
However, when I manually copy the file to ../ginp/WEB-INF/ginp.xml, it 
is detected and used properly. I've slogged through a lot of the logic 
but cannot see what is going wrong yet.

I decided to work through your manual, but I'm not making a lot of sense 
of it yet. I'd like to update it based on what I can get working here.

I would like to explain four different scenarios (not necessarily in 
this order):-

1. Whether someone has downloaded the war, or built it from source with 
maven.. how to configure it to serve up some of their own pictures using 
the default home page and the "Basic" demo style.

a) manually, by cloning/updating a sample ginp.xml file (e.g. when the 
setup application is failing).

b) using the setup application, when I can get it working again.

2. How to customise the system for one's own web site.

a) using an existing style.

b) by creating a new personalised style.


At the moment, I'm keeping my life simple by working on 1a. However, 
when I choose the w2k4 (or backinblack or textart) demos from index.jsp, 
it fails. I keep reading the manual to see what you are really saying 
about the style folders, but seem to be missing something important.

If you have any idea why ...

http://www2.pingtoo.com/ginp/styles/w2k4/ginpservlet?cmd=selectcollection&id=0&nocache=207183762

fails with ...

org.apache.jasper.JasperException: /styles/w2k4/collection.jsp(38,0) 
Unable to load tag handler class "net.sf.ginp.tags.GetFolderInfo" for 
tag "ginp:getfolderinfo"

please let me know soon!

Brian

Re: [Ginp-developers] Latest changes

[Doug C. <do...@cu...>]

Brian Burch wrote:
> Doug,
>
> You will see I've made quite a few changes (commit little and often) to 
> improve the quality of the existing unit tests, but I'm slightly puzzled 
> that I cannot find them on
> http://ginp.sourceforge.net/statscm/2007-01.html
>
> do you know why?
>   
I need to do a
> mvn clean site site:deploy
this updates the public website so let me know when you want it updated
and it will do it.

> You will see I've mainly been working on logging during unit tests... I 
> don't have an ideal solution at the moment because it is not possible to 
> programatically change the Commons Logging level /after/ the first Log 
> instance has been created by the LoggerFactoryImpl. This is a 
> combination of limitations in the way LoggerFactoryImpl processes the 
> sources of its Properties and a lack of flexibility in SimpleLogger.
>   
I would not worry too much the logging of errors is correct behavior and
the testing of error conditions is also correct therefore it is only in
the case of a test failure that the log is interesting.
> If I had more time and enthusiasm, I would start with some code I have 
> in another (private) project and do it properly. Perhaps later this year?
>
> I also had to convert the Picture class to use Commons Logging - it was 
> still explicitly using log4j. Once done, I discovered 4 test cases were 
> failing because they could not find a jpeg file to play with. I sorted 
> all that out.
>   
Good work.
> I wonder whether there are more classes still unconverted Commons Logging?
>   
Maybe?
>
> Anyway, the project builds and tests satisfactorily. I've deployed it to 
> my own server and it looks OK. Can you try it out too?
>   
Will do in due course as I use the head in my own website.
> Brian
>
>
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys - and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> _______________________________________________
> Ginp-developers mailing list
> Gin...@li...
> https://lists.sourceforge.net/lists/listinfo/ginp-developers
>   

[Ginp-developers] Platform independent file paths

[Brian B. <br...@Pi...>]

While working on my latest unit test changes, I found there were A LOT 
of embedded forward-slash characters throughout the main source, as well 
as in the unit tests.

I tried to make the build more portable by changing most of the unit 
tests to use File.separator instead, but didn't have the enthusiasm to 
go through the main classes... I could see that sometimes a forward 
slash was probably mandatory because it gets processed explicitly into a 
file path, but any changes would need a lot of care because we don't 
have a comprehensive set of unit tests to prove this kind of change is 
valid.

I don't propose to do any more about this issue in the short term, but 
felt it was important to warn anyone thinking of building or deploying 
ginp on anything other than linux - beware of file path portability issues!

Brian

[Ginp-developers] Latest changes

[Brian B. <br...@Pi...>]

Doug,

You will see I've made quite a few changes (commit little and often) to 
improve the quality of the existing unit tests, but I'm slightly puzzled 
that I cannot find them on
http://ginp.sourceforge.net/statscm/2007-01.html

do you know why?

You will see I've mainly been working on logging during unit tests... I 
don't have an ideal solution at the moment because it is not possible to 
programatically change the Commons Logging level /after/ the first Log 
instance has been created by the LoggerFactoryImpl. This is a 
combination of limitations in the way LoggerFactoryImpl processes the 
sources of its Properties and a lack of flexibility in SimpleLogger.

If I had more time and enthusiasm, I would start with some code I have 
in another (private) project and do it properly. Perhaps later this year?

I also had to convert the Picture class to use Commons Logging - it was 
still explicitly using log4j. Once done, I discovered 4 test cases were 
failing because they could not find a jpeg file to play with. I sorted 
all that out.

I wonder whether there are more classes still unconverted Commons Logging?


Anyway, the project builds and tests satisfactorily. I've deployed it to 
my own server and it looks OK. Can you try it out too?

Brian

Re: [Ginp-developers] jUnit test logging errors

[Doug C. <do...@cu...>]

Cool Brian,

Please update the documentation for logging if you change it.  The file
is: src/site/xdoc/manual.xml

I am afraid i do not know anything about the SAX warnings so your gess
is as good as mine.

All the best,

Doug

Brian Burch wrote:
> Doug Culnane wrote:
>   
>> The log4j is not really a failure it is good behavior.  You do not need
>> to supply a log4j configuration file it is optional.  Maybe some users
>> have their own logging set up for the web app and do not what log4j
>> configured.  I use commons logging so this will be compatible with most
>> other logging frameworks.
>>     
>
> I looked into the commons logging documentation and decided to replace 
> the default LoggerFactory discovery process. I have committed two new 
> properties files to associate SimpleLog with our jUnit tests and 
> suppress messages less severe than "error". This looks good to me, 
> because it makes no assumptions about the deployment logging framework. 
> Also, no misleading messages are generated during the test goal of the 
> maven life-cycle.
>
>   
>> However most users will want log4j so they need to set the environment
>> variable or drop a log4j.properties file in the class path.
>>
>> Maybe this needs better explanation rather than a fix.  See the logging
>> section of http://ginp.sourceforge.net/manual.html
>>     
>
> I haven't finished with logging yet, but I need to read your manual and 
> think a bit more.
>
> BTW... I've found a couple of org.dom4j.io.SAXReader format errors in 
> TestSetup. They don't prevent the war from being built, but something is 
> wrong. I wonder whether I broke these tests with my earlier changes, so 
> I'll investigate them before I do anything more.
>
> Brian
>
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys - and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> _______________________________________________
> Ginp-developers mailing list
> Gin...@li...
> https://lists.sourceforge.net/lists/listinfo/ginp-developers
>   

Re: [Ginp-developers] jUnit test logging errors

[Brian B. <br...@Pi...>]

Doug Culnane wrote:
> 
> The log4j is not really a failure it is good behavior.  You do not need
> to supply a log4j configuration file it is optional.  Maybe some users
> have their own logging set up for the web app and do not what log4j
> configured.  I use commons logging so this will be compatible with most
> other logging frameworks.

I looked into the commons logging documentation and decided to replace 
the default LoggerFactory discovery process. I have committed two new 
properties files to associate SimpleLog with our jUnit tests and 
suppress messages less severe than "error". This looks good to me, 
because it makes no assumptions about the deployment logging framework. 
Also, no misleading messages are generated during the test goal of the 
maven life-cycle.

> However most users will want log4j so they need to set the environment
> variable or drop a log4j.properties file in the class path.
> 
> Maybe this needs better explanation rather than a fix.  See the logging
> section of http://ginp.sourceforge.net/manual.html

I haven't finished with logging yet, but I need to read your manual and 
think a bit more.

BTW... I've found a couple of org.dom4j.io.SAXReader format errors in 
TestSetup. They don't prevent the war from being built, but something is 
wrong. I wonder whether I broke these tests with my earlier changes, so 
I'll investigate them before I do anything more.

Brian

[Ginp-developers] GINP site updated.

[Doug C. <do...@cu...>]

FYI: I have updated the site becuase it was one month old and to test
another project StatSCM (http://ginp.sourceforge.net/statscm/statscm.html).

This shows a nice clickable report of commit logs and changes:
http://ginp.sourceforge.net/statscm/2007-01.html and makes Brian's
contribution vis able.

Brian: you may want to update the <developers> section of the pom.xml
file to include you as a developer...

All the  best,

Doug

Re: [Ginp-developers] My first changes

[Doug C. <do...@cu...>]

Sounds good Brian,

The log4j is not really a failure it is good behavior.  You do not need
to supply a log4j configuration file it is optional.  Maybe some users
have their own logging set up for the web app and do not what log4j
configured.  I use commons logging so this will be compatible with most
other logging frameworks.

However most users will want log4j so they need to set the environment
variable or drop a log4j.properties file in the class path.

Maybe this needs better explanation rather than a fix.  See the logging
section of http://ginp.sourceforge.net/manual.html

All the best,

Doug


Brian Burch wrote:
> Hi, Doug. Thanks for putting me onto the developers list.
>
> I've just committed three related changes and have fixed the "is a 
> directory" exception in TestSetup.
>
> 1. I changed the already-successful TestGinpModel.setup() method to use 
> the platform-independent file path separator. This minor refactoring 
> allowed me to debug and understand the behaviour of the java.io.File 
> class, which was not intuitively obvious and isn't well explained in 
> ether the jdk5 javadoc, or my older java books. I added a couple of 
> helpful comments. The Test class continued to run OK, so I committed the 
> change.
>
> 2. I then debugged and refactored SetupManagerImpl and Configuration to 
> implement the same logic. It tested successfully a) with /tmp/TestSetup/ 
> missing, b) with /tmp/TestSetup/ present but ginp.xml missing, and c) 
> with /tmp/TestSetup/ginp.xml already present. (We probably need 3 tests 
> for these different cases, but I don't think it is important enough to 
> do now - especially as I tested the cases manually and all 3 cases turn 
> up randomly when running the tests).
>
> 3. I then changed the test configuration file path constants in both 
> test classes to be os-independent.
>
> Maven now builds the war, but before I deploy it I'm going to try fixing 
> the log4j failures in the unit tests.
>
> Regards,
>
> Brian
>
>
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys - and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> _______________________________________________
> Ginp-developers mailing list
> Gin...@li...
> https://lists.sourceforge.net/lists/listinfo/ginp-developers
>   

[Ginp-developers] My first changes

[Brian B. <br...@Pi...>]

Hi, Doug. Thanks for putting me onto the developers list.

I've just committed three related changes and have fixed the "is a 
directory" exception in TestSetup.

1. I changed the already-successful TestGinpModel.setup() method to use 
the platform-independent file path separator. This minor refactoring 
allowed me to debug and understand the behaviour of the java.io.File 
class, which was not intuitively obvious and isn't well explained in 
ether the jdk5 javadoc, or my older java books. I added a couple of 
helpful comments. The Test class continued to run OK, so I committed the 
change.

2. I then debugged and refactored SetupManagerImpl and Configuration to 
implement the same logic. It tested successfully a) with /tmp/TestSetup/ 
missing, b) with /tmp/TestSetup/ present but ginp.xml missing, and c) 
with /tmp/TestSetup/ginp.xml already present. (We probably need 3 tests 
for these different cases, but I don't think it is important enough to 
do now - especially as I tested the cases manually and all 3 cases turn 
up randomly when running the tests).

3. I then changed the test configuration file path constants in both 
test classes to be os-independent.

Maven now builds the war, but before I deploy it I'm going to try fixing 
the log4j failures in the unit tests.

Regards,

Brian

Re: [Ginp-developers] [ginp-users] Subversion and Maven

[Doug C. <do...@cu...>]

You can subscribe to the developers list without restrictions.  Move
discussion to this list.

Looks like the URL may have changed.

Will get back to you on commit access.

I only work on the trunk.

Agree with the Maven Only build, for now it is much less work.

The log4J WARN is not an error.  You can set the environment variable
"log4j.configuration" to point to you log4j config file to get loggin
output.  (Search for log4j.configuration on
http://logging.apache.org/log4j/docs/manual.html  for more info.)

To get a build skip tests
> mvn install -Dmaven.test.skip=true

Find out what test fails:
> mvn site
Browse the HTML site in ./target/site/  for surefire results and you
will get test failure info.
(see: http://ginp.sourceforge.net/surefire-report.html)

All the best,

Doug


Brian Burch wrote:
> Doug, Happy New Year!
>
> I've finally found a few hours to start learning subversion (I have it 
> working under netbeans) and maven (working standalone-only so far).
>   
>> Subversion is very much like cvs. You will need a new client program or
>> plugin because a cvs client does not work with subversion server. I use
>> command line cvs and svn commands and they are very similar. The
>> learning cure here will be small. CVS will no longer be used for the
>> source code.
>>
>> # quick howto
>>
>> svn co http://svn.sorceforge.net/svnroot/ginp/trunk ginp
>>     
>
> Is this still correct? I had to configure subversion-netbeans with:
>
> url - http://ginp.svn.sorceforge.net/svnroot/ginp
> folder - trunk
> repository revision - (empty for HEAD)
>
>   
>> You can send me patches and files or if you get sorted out with
>> subversion I will let you commit directly.
>>
>>     
>
> Would you please add me to the list of project developers? This will 
> allow me to email the developers mailing list in cases where it is more 
> appropriate than the users list. My sourceforge userid is "burchbri".
>
> If it is simpler for you, please also add me to the committers list at 
> the same time - I promise not to commit any changes until either agreed 
> first with you, or trivial.
>
>   
>> I will be using maven not ant because Maven has various project
>> management advantages that are complex to script with ant. However it
>> would be great to have an ant build file that built the project, so if
>> you would like to contribute this it would be great. The only problem is
>> that I no longer have the libs in the source code repository. They are
>> downloaded by maven. The ant build would also need to get this files or
>> have a documentation informing the developer to download the following
>> dependencies.... Not sure how best to solve this.
>>
>>     
>
> I have maven installed and working. I've done a couple of tutorials and 
> some other research. I am not sure it is worth the effort of creating 
> and maintaining a parallel ant build.xml file. My own opinion is that it 
> would create confusion (what tool to use?) and should be removed 
> completely from the source repository as soon as you are certain the 
> maven goals build exactly as you intend. If anyone wants to build from 
> source (e.g. me), it must be done with maven (or not at all).
>
>   
>> I have investigated logging at work a bit I and I think commons logging
>> with a log4j implementation is the best way to go. Commons logging is
>> like a interface that most popular loggers implement, including my
>> favorite log4j. I will do some work and documentation on this. If you
>> are interested read: http://jakarta.apache.org/commons/logging/ Apache
>> also have the logging services project which also used log4j but
>> directly. Again I am not totally sure about the best approach but I
>> think commons logging is the most flexible.
>>
>>     
>
> I ran "mvn compile" successfully. However, the "test" and "install" 
> goals both fail in the "test" stage of the project life cycle.
>
> log4j: WARN No appenders could be found for logger 
> (net.sf.ginp.config.Configuration)
> log4j: WARN Please initialize the log4j system properly.
>
> This is a variation on our previously-fixed log4j problems. If you 
> haven't already resolved it in one of your branch builds, let me know 
> (soon) and I'll sort it out. Until it is fixed, maven will not succeed 
> with the tests and move on to the next (package?) goal.
>
>   
>> I am working on the subversion truck (no tags or branches yet) If you
>> want the best jet version of ginp then download the released source zip
>> file. It may take me a while to get the source version back to a
>> reasonable quality level. However if you find a bug with it then please
>> let me known.
>>
>>     
>
> Are you still working on the trunk, or one of the 3 branches? I assumed 
> my future log4j change would go to the trunk.
>
>  > Thanks for the https info I will try to get round and test this.
>  >
>
> Did you try? If not, I'll have a go as soon as I can get a clean maven 
> build.
>
> Regards,
>
> Brian
>
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys - and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> _______________________________________________
> ginp-users mailing list
> gin...@li...
> https://lists.sourceforge.net/lists/listinfo/ginp-users
>   

[Ginp-developers] [Fwd: Re: [ginp-users] new version of log4j.properties]

[Doug C. <do...@cu...>]

Re: [Ginp-developers] Hacking

[Justin <ju...@sq...>]

Doug,

	You can convert back to Taglibs if you want, though I'd bet you'd 
benefit if you read the "Tapestry in Action" book.  I am going to be 
taking a break from ginp development to work on some personal projects. 
  I was really happy to get it to a point where I was happy with it for 
my own basic personal gallery  so I didn't have to use a php based one.

Regards,

	Justin

Doug Culnane wrote:
> Dear Justin,
> 
> I have been doing a fair amount of hacking and experimentation for the 
> ginp.  I have really tried to use Tapestry and make a data base thing 
> but was finding the learning curve too steep.  I then thought I would 
> move the ginp config file back to the WEB-INF folder as a way of getting 
> into the Tapestry framework.  I got too frustrated with the lack of 
> productivity and so I tried to use the tag libs to do the same thing.  
> This was far more productive and fitted much better with my way of doing 
> things.
> I am not saying that Tapestry is bad (it is clearly a much better frame 
> work that I will ever program) but I think I prefer the taglib method.  
> I do not need total separation of code and html that I can see as being 
> a great benefit of Tapestry in big team environments.  I also do not 
> mind doing the plumbing and worrying about umlauts.....  I am much more 
> productive with taglibs and they are easier to understand and get into 
> for typical php type web programmers. Therefore if I sit in isolation I 
> would continue with the tag lib approach and rework the wizard (and make 
> it work as a phase two config editor.)  However I do not sit in 
> isolation so now is your chance to say "RTFM and we really should use 
> Tapestry because....".
> At the moment I have a big cvs ci which is a lot of stuff that does not 
> really work but I have to decide whether to continue and tidy it up or 
> abandon it.  Therefore what are your thoughts?
> 
> All the best,
> 
> Doug
> 
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by: NEC IT Guy Games.
> Get your fingers limbered up and give it your best shot. 4 great events, 4
> opportunities to win big! Highest score wins.NEC IT Guy Games. Play to
> win an NEC 61 plasma display. Visit http://www.necitguy.com/?r=20
> _______________________________________________
> Ginp-developers mailing list
> Gin...@li...
> https://lists.sourceforge.net/lists/listinfo/ginp-developers

[Ginp-developers] Hacking

[Doug C. <do...@cu...>]

Dear Justin,

I have been doing a fair amount of hacking and experimentation for the 
ginp.  I have really tried to use Tapestry and make a data base thing 
but was finding the learning curve too steep.  I then thought I would 
move the ginp config file back to the WEB-INF folder as a way of getting 
into the Tapestry framework.  I got too frustrated with the lack of 
productivity and so I tried to use the tag libs to do the same thing.  
This was far more productive and fitted much better with my way of doing 
things. 

I am not saying that Tapestry is bad (it is clearly a much better frame 
work that I will ever program) but I think I prefer the taglib method.  
I do not need total separation of code and html that I can see as being 
a great benefit of Tapestry in big team environments.  I also do not 
mind doing the plumbing and worrying about umlauts.....  I am much more 
productive with taglibs and they are easier to understand and get into 
for typical php type web programmers. Therefore if I sit in isolation I 
would continue with the tag lib approach and rework the wizard (and make 
it work as a phase two config editor.)  However I do not sit in 
isolation so now is your chance to say "RTFM and we really should use 
Tapestry because....". 

At the moment I have a big cvs ci which is a lot of stuff that does not 
really work but I have to decide whether to continue and tidy it up or 
abandon it.  Therefore what are your thoughts?

All the best,

Doug

Re: [Ginp-developers] Next Release...

[Doug C. <do...@cu...>]

Thinking aloud I have two reactions:

1 - This is bad because it is complex and hard to test, document and 
maintain the different versions of all parts of the system.  The user 
has Java, Tomcat, MySQL, ginp, GIMP and ginp server to set up and will 
get frustrated and install phpMyPictureGallery.  The Java API does this 
stuff so why do we need this extra complexity?

2- Cool we could do an Alien glow style, that would look awesome. GIMP 
is a good bit of software so why not use it to do what it does well.

I am not sure which way to respond.  I think if ( as you say ) it is an 
optional extra like the database the newbies do not need to touch it but 
the professionals can set up a auto copyright, watermark system.

Therefore if you what to play with this go for it but do not dump me 
with a maintenance nightmare and disappear into the Internet.

All the best,

Doug


Justin wrote:

> Doug,
>
>     Gimp can be set up as a server to listen on a local port for 
> script-fu commands.  We could have an option to do the thumbnails by 
> sending commands to this port over sockets:
>
> http://www.linux-mag.com/archive/2002-02/power_01.html
>
> Here's a perl example.  The example is how to make gimp resize images 
> via script fu!  It would just be an option.  We could fall back to the 
> java algorithm otherwise.  We could provide a shell script/bat to 
> startup the gimp in server mode on linux or windows.  We could even 
> write our how alien glow modes for thumbnails and distribute them as a 
> option in the configuration.  I always want to make ginp run properly 
> without relying on external programs but I think it would be cool to 
> have a image processing via GIMP's Script-Fu Server Option.
>
>
>
> Doug Culnane wrote:
>
>> "
>> What ginp is not?
>> ginp = Ginp Is Not a Picture manager
>> ginp = Ginp Is Not gimP <http://www.gimp.org>
>>
>> The management of the files is NOT part of the application because 
>> there are better tools for copying renaming and moving files.
>> Editing the photos is NOT part of the application because there are 
>> better tools for editing images.
>> "
>>
>> I do not want to program a image resizer / Cropper / alien glower.... 
>> So my idea was to use the file system and Photoshop or GIMP or 
>> ............  to edit the images and the ginp presents the collection 
>> for easy browsing, and sharing, searching......
>> The thumbnailing is bad quality because it uses the standard java 
>> libary which does relitively hi compression.  We could put in the 
>> ToDos the feature "confguration option for image quality" so users 
>> can say high quality thumbs are important.  We could also use the 
>> GIMP for alien glow stuff but I started the project with the concept 
>> of do well what you can do well with the web application and let 
>> desktop software do what it does well.  This can change but I still 
>> think it is not a bad brief.
>>
>> If someone coments about the software I am enklined to take it 
>> seriously (and give it a higher priority) because they are real users 
>> who can stand back and see what the real weeknesses are, therefore I 
>> am open to a solution but the cool thing about the ginp is it is very 
>> platform indepentant and simple.  If we rely on giMp then we start to 
>> end up like a lot of other *nix software which is a patchwork of 
>> stuff that is I nightmare to plug together.  (and windows users will 
>> just not get)
>>
>> Therfore I would say yes high quality thumbs option (implamented with 
>> better use of standard library or another lib) and encourage users to 
>> use their favourite photo editor on the files to modify them as they 
>> like and the ginp rethumbs if the file modiy date is newer than the 
>> thumb.  This is a strategy that aims to get the best from both worlds.
>>
>> An power ginp user can already put copyright messages on a file 
>> system of images with a script do we really need to program an 
>> interface for then to do this with a web application.  It could be 
>> cool but a lot of work.
>>
>> That is my thoughts on this but I try to be open to ideas from 
>> others, because sometimes they are right like the db thing.  So feel 
>> free to rethink this strategy and comment...
>>
>> All the best,
>>
>> Doug
>>
>> Justin wrote:
>>
>>>
>>> Doug,
>>>
>>>     One thing that we may want to do, as far as features go, that we 
>>> may not be able to do anything about is that I had a friend complain 
>>> that the image quality of the thumbnailing could use some work to 
>>> make it as good as professional image manipulation program.  Is 
>>> there another library we could use that does anti-aliasing on 
>>> thumbs?  It's not a super-high priority, as all the other gallery 
>>> programs aren't much better, it's just something for both of us to 
>>> keep an eye on.  Perhaps on Linux or even Windows we could have an 
>>> option to let the GIMP (How Ironic! Ginp using the GIMP) do the 
>>> thumbnail processing or do some kind of custom script-fu (Yes Gimp's 
>>> scripting system is called Script-Fu) to process the images?  That 
>>> way you could put copyright or other messages automatically on your 
>>> thumbs and images or add alien glow borders...
>>>
>>> Regards,
>>>
>>> Justin
>>>
>>> Doug Culnane wrote:
>>>
>>>> I think all known issues are covered in the current release so it 
>>>> is good quality software.  It does not have many features, but it 
>>>> does what it does and does it well.
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>> -------------------------------------------------------
>>> SF email is sponsored by - The IT Product Guide
>>> Read honest & candid reviews on hundreds of IT Products from real 
>>> users.
>>> Discover which products truly live up to the hype. Start reading now.
>>> http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
>>> _______________________________________________
>>> Ginp-developers mailing list
>>> Gin...@li...
>>> https://lists.sourceforge.net/lists/listinfo/ginp-developers
>>>
>>
>>
>>
>> -------------------------------------------------------
>> SF email is sponsored by - The IT Product Guide
>> Read honest & candid reviews on hundreds of IT Products from real users.
>> Discover which products truly live up to the hype. Start reading now.
>> http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
>> _______________________________________________
>> Ginp-developers mailing list
>> Gin...@li...
>> https://lists.sourceforge.net/lists/listinfo/ginp-developers
>
>
>
>
>
> -------------------------------------------------------
> SF email is sponsored by - The IT Product Guide
> Read honest & candid reviews on hundreds of IT Products from real users.
> Discover which products truly live up to the hype. Start reading now.
> http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
> _______________________________________________
> Ginp-developers mailing list
> Gin...@li...
> https://lists.sourceforge.net/lists/listinfo/ginp-developers
>

Re: [Ginp-developers] Next Release...

[Justin <ju...@sq...>]

Doug,

	Gimp can be set up as a server to listen on a local port for script-fu 
commands.  We could have an option to do the thumbnails by sending 
commands to this port over sockets:

http://www.linux-mag.com/archive/2002-02/power_01.html

Here's a perl example.  The example is how to make gimp resize images 
via script fu!  It would just be an option.  We could fall back to the 
java algorithm otherwise.  We could provide a shell script/bat to 
startup the gimp in server mode on linux or windows.  We could even 
write our how alien glow modes for thumbnails and distribute them as a 
option in the configuration.  I always want to make ginp run properly 
without relying on external programs but I think it would be cool to 
have a image processing via GIMP's Script-Fu Server Option.



Doug Culnane wrote:
> "
> What ginp is not?
> ginp = Ginp Is Not a Picture manager
> ginp = Ginp Is Not gimP <http://www.gimp.org>
> 
> The management of the files is NOT part of the application because there 
> are better tools for copying renaming and moving files.
> Editing the photos is NOT part of the application because there are 
> better tools for editing images.
> "
> 
> I do not want to program a image resizer / Cropper / alien glower.... So 
> my idea was to use the file system and Photoshop or GIMP or 
> ............  to edit the images and the ginp presents the collection 
> for easy browsing, and sharing, searching......
> The thumbnailing is bad quality because it uses the standard java libary 
> which does relitively hi compression.  We could put in the ToDos the 
> feature "confguration option for image quality" so users can say high 
> quality thumbs are important.  We could also use the GIMP for alien glow 
> stuff but I started the project with the concept of do well what you can 
> do well with the web application and let desktop software do what it 
> does well.  This can change but I still think it is not a bad brief.
> 
> If someone coments about the software I am enklined to take it seriously 
> (and give it a higher priority) because they are real users who can 
> stand back and see what the real weeknesses are, therefore I am open to 
> a solution but the cool thing about the ginp is it is very platform 
> indepentant and simple.  If we rely on giMp then we start to end up like 
> a lot of other *nix software which is a patchwork of stuff that is I 
> nightmare to plug together.  (and windows users will just not get)
> 
> Therfore I would say yes high quality thumbs option (implamented with 
> better use of standard library or another lib) and encourage users to 
> use their favourite photo editor on the files to modify them as they 
> like and the ginp rethumbs if the file modiy date is newer than the 
> thumb.  This is a strategy that aims to get the best from both worlds.
> 
> An power ginp user can already put copyright messages on a file system 
> of images with a script do we really need to program an interface for 
> then to do this with a web application.  It could be cool but a lot of 
> work.
> 
> That is my thoughts on this but I try to be open to ideas from others, 
> because sometimes they are right like the db thing.  So feel free to 
> rethink this strategy and comment...
> 
> All the best,
> 
> Doug
> 
> Justin wrote:
> 
>>
>> Doug,
>>
>>     One thing that we may want to do, as far as features go, that we 
>> may not be able to do anything about is that I had a friend complain 
>> that the image quality of the thumbnailing could use some work to make 
>> it as good as professional image manipulation program.  Is there 
>> another library we could use that does anti-aliasing on thumbs?  It's 
>> not a super-high priority, as all the other gallery programs aren't 
>> much better, it's just something for both of us to keep an eye on.  
>> Perhaps on Linux or even Windows we could have an option to let the 
>> GIMP (How Ironic! Ginp using the GIMP) do the thumbnail processing or 
>> do some kind of custom script-fu (Yes Gimp's scripting system is 
>> called Script-Fu) to process the images?  That way you could put 
>> copyright or other messages automatically on your thumbs and images or 
>> add alien glow borders...
>>
>> Regards,
>>
>> Justin
>>
>> Doug Culnane wrote:
>>
>>> I think all known issues are covered in the current release so it is 
>>> good quality software.  It does not have many features, but it does 
>>> what it does and does it well.
>>
>>
>>
>>
>>
>>
>> -------------------------------------------------------
>> SF email is sponsored by - The IT Product Guide
>> Read honest & candid reviews on hundreds of IT Products from real users.
>> Discover which products truly live up to the hype. Start reading now.
>> http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
>> _______________________________________________
>> Ginp-developers mailing list
>> Gin...@li...
>> https://lists.sourceforge.net/lists/listinfo/ginp-developers
>>
> 
> 
> 
> -------------------------------------------------------
> SF email is sponsored by - The IT Product Guide
> Read honest & candid reviews on hundreds of IT Products from real users.
> Discover which products truly live up to the hype. Start reading now.
> http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
> _______________________________________________
> Ginp-developers mailing list
> Gin...@li...
> https://lists.sourceforge.net/lists/listinfo/ginp-developers

Re: [Ginp-developers] Next Release...

[Doug C. <do...@cu...>]

"
What ginp is not?
ginp = Ginp Is Not a Picture manager
ginp = Ginp Is Not gimP <http://www.gimp.org>

The management of the files is NOT part of the application because there 
are better tools for copying renaming and moving files.
Editing the photos is NOT part of the application because there are 
better tools for editing images.
"

I do not want to program a image resizer / Cropper / alien glower.... So 
my idea was to use the file system and Photoshop or GIMP or 
............  to edit the images and the ginp presents the collection 
for easy browsing, and sharing, searching...... 

The thumbnailing is bad quality because it uses the standard java libary 
which does relitively hi compression.  We could put in the ToDos the 
feature "confguration option for image quality" so users can say high 
quality thumbs are important.  We could also use the GIMP for alien glow 
stuff but I started the project with the concept of do well what you can 
do well with the web application and let desktop software do what it 
does well.  This can change but I still think it is not a bad brief.

If someone coments about the software I am enklined to take it seriously 
(and give it a higher priority) because they are real users who can 
stand back and see what the real weeknesses are, therefore I am open to 
a solution but the cool thing about the ginp is it is very platform 
indepentant and simple.  If we rely on giMp then we start to end up like 
a lot of other *nix software which is a patchwork of stuff that is I 
nightmare to plug together.  (and windows users will just not get)

Therfore I would say yes high quality thumbs option (implamented with 
better use of standard library or another lib) and encourage users to 
use their favourite photo editor on the files to modify them as they 
like and the ginp rethumbs if the file modiy date is newer than the 
thumb.  This is a strategy that aims to get the best from both worlds.

An power ginp user can already put copyright messages on a file system 
of images with a script do we really need to program an interface for 
then to do this with a web application.  It could be cool but a lot of work.

That is my thoughts on this but I try to be open to ideas from others, 
because sometimes they are right like the db thing.  So feel free to 
rethink this strategy and comment...

All the best,

Doug

Justin wrote:

>
> Doug,
>
>     One thing that we may want to do, as far as features go, that we 
> may not be able to do anything about is that I had a friend complain 
> that the image quality of the thumbnailing could use some work to make 
> it as good as professional image manipulation program.  Is there 
> another library we could use that does anti-aliasing on thumbs?  It's 
> not a super-high priority, as all the other gallery programs aren't 
> much better, it's just something for both of us to keep an eye on.  
> Perhaps on Linux or even Windows we could have an option to let the 
> GIMP (How Ironic! Ginp using the GIMP) do the thumbnail processing or 
> do some kind of custom script-fu (Yes Gimp's scripting system is 
> called Script-Fu) to process the images?  That way you could put 
> copyright or other messages automatically on your thumbs and images or 
> add alien glow borders...
>
> Regards,
>
> Justin
>
> Doug Culnane wrote:
>
>> I think all known issues are covered in the current release so it is 
>> good quality software.  It does not have many features, but it does 
>> what it does and does it well.
>
>
>
>
>
> -------------------------------------------------------
> SF email is sponsored by - The IT Product Guide
> Read honest & candid reviews on hundreds of IT Products from real users.
> Discover which products truly live up to the hype. Start reading now.
> http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
> _______________________________________________
> Ginp-developers mailing list
> Gin...@li...
> https://lists.sourceforge.net/lists/listinfo/ginp-developers
>

Re: [Ginp-developers] Next Release...

[Justin <ju...@sq...>]

Doug,

	One thing that we may want to do, as far as features go, that we may 
not be able to do anything about is that I had a friend complain that 
the image quality of the thumbnailing could use some work to make it as 
good as professional image manipulation program.  Is there another 
library we could use that does anti-aliasing on thumbs?  It's not a 
super-high priority, as all the other gallery programs aren't much 
better, it's just something for both of us to keep an eye on.  Perhaps 
on Linux or even Windows we could have an option to let the GIMP (How 
Ironic! Ginp using the GIMP) do the thumbnail processing or do some kind 
of custom script-fu (Yes Gimp's scripting system is called Script-Fu) to 
process the images?  That way you could put copyright or other messages 
automatically on your thumbs and images or add alien glow borders...

Regards,

Justin

Doug Culnane wrote:
> I think all known issues are covered in the current release so it is 
> good quality software.  It does not have many features, but it does what 
> it does and does it well.

Re: [Ginp-developers] Next Release...

[Doug C. <do...@cu...>]

I think all known issues are covered in the current release so it is 
good quality software.  It does not have many features, but it does what 
it does and does it well.

I tried to test GermanChars-äöüÄÖÜß.jpg on my Tomcat 4.1 installation 
but the operating system could not handle these file names so I give up 
on the idea of Non-Ansii file names.

I try to step back and say what is the most shit thing about the project 
and attack that.  The docs are not great, the code could be cleaner, 
better logging, better javadocs, more sample styles, better styles, 
sexier public website.....????  but I think that at the moment it is the 
data and features because search is an important thing for big 
collections.  As a user I want to associate data with pictures so I can 
write (Locale specific) comments about the pictures.  This means getting 
the DB stuff underway.  You mention a lot of stuff which you should add 
to the ToDo.txt Doc.  I think we should make a start on the db stuff and 
see what happens.  When is stabilizes again we can release, but there is 
lots to do and it is all worthwhile.  So get Hacking on stuff you find 
fun and useful, as it is all just for fun, or attach what you find the 
most shit thing about the project.  Your outline of good features for 
the next release all sound good to me.  I will play around with the db 
form stuff as discussed earlier, but feel free to dive in.

We had a good Webstats month last month.  I am not sure if they are from 
crackers interested in the security links or genuine users, but hits are 
hits.

All the best,

Doug

Justin wrote

>
> Doug,
>
>     Great to see that the 0.33 release is out.  This is a really rock 
> solid release.  One good thing about it is that it can support a large 
> number of users just as long as they are all in separate ginpEnvs.  
> For instance, I have mod_jk pointing at Tomcat from Apache at two 
> different galleries for different websites and they are both using the 
> same webapp in tomcat.  There's no duplicate class loading, which 
> would happen if they were separate wars like Java conventionally 
> handles separate web apps.
>
> What do you think would be some good features for next release?
>
>  - Database Integration
>  - Database Setup Wizard
>  - Most popular picture
>  - Most viewed picture
>  - OSCache integration
>  - Picture Uploading?
>  - Admin Console?
>
> What do you think users are looking for?
>
> Regards,
>
> Justin
>
>
>
>
> -------------------------------------------------------
> SF email is sponsored by - The IT Product Guide
> Read honest & candid reviews on hundreds of IT Products from real users.
> Discover which products truly live up to the hype. Start reading now.
> http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
> _______________________________________________
> Ginp-developers mailing list
> Gin...@li...
> https://lists.sourceforge.net/lists/listinfo/ginp-developers
>

[Ginp-developers] Next Release...

[Justin <ju...@sq...>]

Doug,

	Great to see that the 0.33 release is out.  This is a really rock solid 
release.  One good thing about it is that it can support a large number 
of users just as long as they are all in separate ginpEnvs.  For 
instance, I have mod_jk pointing at Tomcat from Apache at two different 
galleries for different websites and they are both using the same webapp 
in tomcat.  There's no duplicate class loading, which would happen if 
they were separate wars like Java conventionally handles separate web 
apps.

What do you think would be some good features for next release?

  - Database Integration
  - Database Setup Wizard
  - Most popular picture
  - Most viewed picture
  - OSCache integration
  - Picture Uploading?
  - Admin Console?

What do you think users are looking for?

Regards,

Justin

[Ginp-developers] cvs ci

[Doug C. <do...@cu...>]

Dear Justin,

cvs ci -m "Many problems with setLocale and request.getEncoding() in 
Tomcat. This seams to be a known problem on the web with various 
workarounds suggested but not totally working. This code uses a work 
around to fix the problem but is likely to cause problems another 
platforms. Encoding added to config file and URLEndoding reworked.   It 
all works perfectly on my laptop but there may be bugs in other 
environments.  This is a ci of all known bugs fixed so the code can 
tested and got into release state."

Please report any problems.  It it not just me that is finding encoding 
a nightmare and I think this is a Tomcat problem more than a Doug 
problem.  Ref: http://www.jguru.com/faq/view.jsp?EID=137281

I will update my live site now and lets do bug fixes and aim for the 
release as you suggested earlier.

All the best,

Doug

Re: [Ginp-developers] Bug in thread logic

[Doug C. <do...@cu...>]

Cool Thanks Justin.  I will do some testing.

I will make a log4j.properties.release and log4j.properties.chainsaw.....

All the best,

Doug

Justin wrote:

>
> Doug,
>
>     Ok I fixed the bug.  The make thumbs thread sleeps for a second 
> and then checks for new requests to make thumbnails.  The problem was 
> was that while it was sleeping it was blocking directory request 
> causing threads to pile up.  This shouldn't happen now as it doesn't 
> hold the synchronize lock on anything while it's sleeping.  BTW, Make 
> sure to take the log4j Chainsaw hookup out before you release.
>
> Regards,
>
>     Justin
>
> Doug Culnane wrote:
>
>> Dear Justin,
>>
>> There is a bug in the thread logic.  I tried to fix this but I have 
>> no experience with synchronized threads.  I would fix this by 
>> removing the synchronized bit out of the application, which you may 
>> not approve of.  Therefore please have a look at the code because it 
>> does not work on tomcat.  I have to click links several times to get 
>> a response.  I think that my encoding problem is related to this, but 
>> I can not know for sure until this is fixed.
>
>

Re: [Ginp-developers] Bug in thread logic

[Justin <ju...@sq...>]

Doug,

	Ok I fixed the bug.  The make thumbs thread sleeps for a second and 
then checks for new requests to make thumbnails.  The problem was was 
that while it was sleeping it was blocking directory request causing 
threads to pile up.  This shouldn't happen now as it doesn't hold the 
synchronize lock on anything while it's sleeping.  BTW, Make sure to 
take the log4j Chainsaw hookup out before you release.

Regards,

	Justin

Doug Culnane wrote:
> Dear Justin,
> 
> There is a bug in the thread logic.  I tried to fix this but I have no 
> experience with synchronized threads.  I would fix this by removing the 
> synchronized bit out of the application, which you may not approve of.  
> Therefore please have a look at the code because it does not work on 
> tomcat.  I have to click links several times to get a response.  I think 
> that my encoding problem is related to this, but I can not know for sure 
> until this is fixed.

Re: [Ginp-developers] Bug in thred logic

[Justin <ju...@sq...>]

Doug,

	It would be good if we could reproduce the deadlock or I could at least 
get a stack trace of it.  Why don't you run "kill -QUIT" on the java 
process and send me the standard out back.  The code you removed was an 
artifact of the older thumb making process.  Have you cvs updated 
lately?  I had some old behaviour in the code where it would wait till 
all the thumbs finished generating before showing the page.  I'll look 
into setting up a jmeter script tonight to try and trigger the deadlock 
with load.

BTW, Here's a quick tutorial on how to do the KILL -QUIT when the 
process is hung.

tail -f ./tomcat/logs/catalina.out &

(The next command is all on one line)

ps -axf | grep java | grep -v "\_" | grep tomcat | cut -d ' ' -f 1 | 
xargs kill -QUIT

The stacktrace of the jvm running tomcat will print out.  If you could 
copy and paste this and mail it to me when you get the hang that would 
be great.  In the meantime I will look closely at my code and try and 
reproduce the problem.

Thanks,

	Justin

Doug Culnane wrote:
> Dear Justin,
> 
> There is a bug in the thread logic.  I tried to fix this but I have no 
> experience with synchronized threads.  I would fix this by removing the 
> synchronized bit out of the application, which you may not approve of.  
> Therefore please have a look at the code because it does not work on 
> tomcat.  I have to click links several times to get a response.  I think 
> that my encoding problem is related to this, but I can not know for sure 
> until this is fixed.
> 
>  From Configuration I have removed this redundant code which I do not 
> think is relevant but I thought I would mention it just in case:
>    private boolean makeThumbsFlag=true;
>      /**
>     * Synchronized to make thread safe
>     * @return whether to launch a make thumbs thread.
>     */
>    public synchronized boolean makeThumbs() {
>        if (makeThumbsFlag==true) {
>            makeThumbsFlag=false;
>            return true;
>        }
>        return false;
>    }
> 
>    /**
>     * Call when the make thumbs thread has finished
>     */
>    public void doneMakingThumbs() {
>        makeThumbsFlag=true;
>    }
> 
> If you do not have time for this then let me know and I will reprogram 
> the synchronized bit out and make a series of images for the different 
> Thumbnail errors. ThumbnailBeingMadePleaseWaitAndRefresh.jpg
> OriginalFileNotFound.jpg
> CanNotWriteToDirectory.jpg
> ...
> 
> This may not be very elegant but it will be safer.
> 
> All the best, Happy Easter,
> 
> Doug
> 
> 
> 
> 
> -------------------------------------------------------
> SF email is sponsored by - The IT Product Guide
> Read honest & candid reviews on hundreds of IT Products from real users.
> Discover which products truly live up to the hype. Start reading now.
> http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
> _______________________________________________
> Ginp-developers mailing list
> Gin...@li...
> https://lists.sourceforge.net/lists/listinfo/ginp-developers

[Ginp-developers] Bug in thred logic

[Doug C. <do...@cu...>]

Dear Justin,

There is a bug in the thread logic.  I tried to fix this but I have no 
experience with synchronized threads.  I would fix this by removing the 
synchronized bit out of the application, which you may not approve of.  
Therefore please have a look at the code because it does not work on 
tomcat.  I have to click links several times to get a response.  I think 
that my encoding problem is related to this, but I can not know for sure 
until this is fixed.

 From Configuration I have removed this redundant code which I do not 
think is relevant but I thought I would mention it just in case:
    private boolean makeThumbsFlag=true;
   
    /**
     * Synchronized to make thread safe
     * @return whether to launch a make thumbs thread.
     */
    public synchronized boolean makeThumbs() {
        if (makeThumbsFlag==true) {
            makeThumbsFlag=false;
            return true;
        }
        return false;
    }

    /**
     * Call when the make thumbs thread has finished
     */
    public void doneMakingThumbs() {
        makeThumbsFlag=true;
    }

If you do not have time for this then let me know and I will reprogram 
the synchronized bit out and make a series of images for the different 
Thumbnail errors. 
ThumbnailBeingMadePleaseWaitAndRefresh.jpg
OriginalFileNotFound.jpg
CanNotWriteToDirectory.jpg
...

This may not be very elegant but it will be safer.

All the best, Happy Easter,

Doug