ginp-developers — ginp Developers

Re: [Ginp-developers] ant test passed.

[Justin <ju...@sq...>]

Good to hear it.  Let me know if you need any help with anything else 
before the release.

Regards,

Justin

Doug Culnane wrote:

> I ran ant test (1.6.2) from the command line and it passed the tests :-)
> 
> 
> ltdoc:/home/doc/wrk/www/ginp/build/WEB-INF/classes # ant -buildfile 
> ../../../build.xml  test
> Buildfile: ../../../build.xml
> 
> prepare:
> 
> compile:
> 
> test:
>    [junit] Testsuite: net.sf.ginp.test.TestGinp
>    [junit] Tests run: 14, Failures: 0, Errors: 0, Time elapsed: 1.251 sec
> 
>    [junit] Testcase: test_Collection took 1.038 sec
>    [junit] Testcase: test_Collection_sortPictures took 0.01 sec
>    [junit] Testcase: test_Commands_Logon took 0.032 sec
>    [junit] Testcase: test_Commands_SelectCollection took 0.029 sec
>    [junit] Testcase: test_Commands_SetLanguageCode took 0.011 sec
>    [junit] Testcase: test_GinpModelManager_translate took 0.016 sec
>    [junit] Testcase: test_Model took 0.012 sec
>    [junit] Testcase: test_ModelManager took 0.015 sec
>    [junit] Testcase: test_Model_pageDimensions took 0.009 sec
>    [junit] Testcase: test_Picture took 0.019 sec
>    [junit] Testcase: test_Picture_setDateTime took 0.023 sec
>    [junit] Testcase: test_StringTool_getXMLTagContent took 0.011 sec
>    [junit] Testcase: test_StringTool_replace took 0.009 sec
>    [junit] Testcase: test_StringTool_splitToArray took 0.012 sec
>    [junit] Testsuite: net.sf.ginp.test.TestSetup
>    [junit] Tests run: 9, Failures: 0, Errors: 0, Time elapsed: 2.579 sec
> 
>    [junit] Testcase: testValidConfig took 1.017 sec
>    [junit] Testcase: testHivemind took 0.132 sec
>    [junit] Testcase: testCreateDeleteKey took 0.217 sec
>    [junit] Testcase: testI18n took 0.234 sec
>    [junit] Testcase: testValidConfigLocation took 0.097 sec
>    [junit] Testcase: testValidPicturesLocation took 0.094 sec
>    [junit] Testcase: testBuildConfigFromVisit took 0.48 sec
>    [junit] Testcase: testGenerateJavaCommand took 0.119 sec
>    [junit] Testcase: testGetAvailableDirectories took 0.188 sec
> 
> BUILD SUCCESSFUL
> Total time: 5 seconds
> ltdoc:/home/doc/wrk/www/ginp/build/WEB-INF/classes #
> 
> 
> 
> 
> 

[Ginp-developers] Repackaged classes from net.culnane.ginp to net.sf.ginp

[Doug C. <do...@cu...>]

cvs ci -m "Repackage classes from net.culnane.ginp to net.sf.ginp."

-- 
Doug Culnane
do...@cu...
www.culnane.net

[Ginp-developers] ant test passed.

[Doug C. <do...@cu...>]

I ran ant test (1.6.2) from the command line and it passed the tests :-)


ltdoc:/home/doc/wrk/www/ginp/build/WEB-INF/classes # ant -buildfile ../../../build.xml  test
Buildfile: ../../../build.xml

prepare:

compile:

test:
    [junit] Testsuite: net.sf.ginp.test.TestGinp
    [junit] Tests run: 14, Failures: 0, Errors: 0, Time elapsed: 1.251 sec

    [junit] Testcase: test_Collection took 1.038 sec
    [junit] Testcase: test_Collection_sortPictures took 0.01 sec
    [junit] Testcase: test_Commands_Logon took 0.032 sec
    [junit] Testcase: test_Commands_SelectCollection took 0.029 sec
    [junit] Testcase: test_Commands_SetLanguageCode took 0.011 sec
    [junit] Testcase: test_GinpModelManager_translate took 0.016 sec
    [junit] Testcase: test_Model took 0.012 sec
    [junit] Testcase: test_ModelManager took 0.015 sec
    [junit] Testcase: test_Model_pageDimensions took 0.009 sec
    [junit] Testcase: test_Picture took 0.019 sec
    [junit] Testcase: test_Picture_setDateTime took 0.023 sec
    [junit] Testcase: test_StringTool_getXMLTagContent took 0.011 sec
    [junit] Testcase: test_StringTool_replace took 0.009 sec
    [junit] Testcase: test_StringTool_splitToArray took 0.012 sec
    [junit] Testsuite: net.sf.ginp.test.TestSetup
    [junit] Tests run: 9, Failures: 0, Errors: 0, Time elapsed: 2.579 sec

    [junit] Testcase: testValidConfig took 1.017 sec
    [junit] Testcase: testHivemind took 0.132 sec
    [junit] Testcase: testCreateDeleteKey took 0.217 sec
    [junit] Testcase: testI18n took 0.234 sec
    [junit] Testcase: testValidConfigLocation took 0.097 sec
    [junit] Testcase: testValidPicturesLocation took 0.094 sec
    [junit] Testcase: testBuildConfigFromVisit took 0.48 sec
    [junit] Testcase: testGenerateJavaCommand took 0.119 sec
    [junit] Testcase: testGetAvailableDirectories took 0.188 sec

BUILD SUCCESSFUL
Total time: 5 seconds
ltdoc:/home/doc/wrk/www/ginp/build/WEB-INF/classes #





-- 
Doug Culnane
do...@cu...
www.culnane.net

Re: [Ginp-developers] cvs ci

[Doug C. <do...@cu...>]

I have upgraded to ant-1.6.2 but I still get the build errors.  Because 
of the jEdit environment I am not sure what libraries are used etc.... I 
will play around a bit more with this.

I have scraped the html override of translations because:
- I did not want to have a hard coded list of supported languages.
- I  was not really using the html override for ginp pages only other 
pages on the Moth website.  Therefore I have a DougsHTMLTranslator  for 
these pages that are not part of the ginp project.
- You made a good point about others can contribute to the project 
easily by translating the properties files.

I have updated the documentation accordingly.  I think the translator 
works and is finished but it needs a bit more testing.

I got the new ginp built into my Moth Site.  I was missing this form the 
build compile target

    <copy todir="${build.home}/WEB-INF/classes">
        <fileset dir="src">
            <exclude name="**/*.java"/>
        </fileset>
    </copy>

I will update the Moth and My site next week when I am back on my Office 
LAN because at home I have a 44kbs modem that is really starting to get 
annoying.

I will continue repackaging the net.culnane.ginp to net.sf.ginp.  Then 
we should do some testing and tidying up ready for a release.  At the 
moment I only have one release which is the latest and best.  I do not 
have a unstable and stable.  I think this is OK but it may need to 
change in the future.

When 0.2 is released I think we should work on the next features.  I 
think your web interface for editing the config file is important, and 
so I hope you retain interest in the project.  We also should think 
carefully about the picture data xml DTD.  I have some ideas about this 
but it is important to get it right so I would of course welcome your 
feedback.

Is the documentation about HowTo build the ginp into your site OK?

All the best,

Doug

Justin wrote:

>
> Doug,
>
> Here's the line that calls the code that cause the ClassCastException:
>
> TransformerFactory factory = TransformerFactory.newInstance();
>
> I think this is an XML library mismatch issue which means the xml 
> library that is getting loaded by ant is getting mixed up with classes 
> getting loaded by the jdk that have incompatible interfaces.  My 
> suggestion is you upgrade your ant to 1.6.2 as this works fine for me 
> building on Debian.  Don't forget to copy junit.jar into 
> ${ant.home}/lib to get junit to run.
>
> Also I removed the dependecy on tomcat to build as this is not part of 
> our standard distribution.
>
> I think Java Resource Bundles are pretty easy to figure out they are 
> not anymore complex than windows inf files.  Perhaps you should put a 
> little note in the documentation about internationalization and how to 
> do it. All they need to do is unjar ginp.war and then edit the 
> Ginp.properties.  That's about as easy as editing the html files.  
> Besides, that way we can get people to contribute back to the project 
> more easily and when they upgrade their customized changes won't get 
> overwritten.
>
> Regards,
>
>     Justin
>
>


-- 
Doug Culnane
do...@cu...
www.culnane.net

Re: [Ginp-developers] cvs ci

[Doug C. <do...@cu...>]

Sorry about that I use a Java Tidy plug in that means I can be very 
lazy.  I will switch it off or think about a better way of setting it up.

I like the i18n stuff it is very cool.  I have kept the HTML tag over 
ride option.  I am not sure if this is good or not so I would be 
interested in your thoughts.  The advantage of it is that it is easy for 
HTML programmers to do custom language translation without having to 
understand and edit Java ResourseBundels.  I think I will keep the 
design like it i but you have a chance to tell me know if you think it 
is crap.

I will do some HowTo Multi language support documentation and extend the 
base languages to:

English
German
French
Spanish
Italian
....????

I will try to get some translation work done but may use Google  to get 
the base support looking like it works. 

I will also build the new ginp into the main site and Moth Site ready 
from a site update, and testing.

If I run the tests I get this error:

Testcase: testBuildConfigFromVisit took 2.839 sec
Caused an ERROR
java.lang.ClassCastException
net.sf.ginp.setup.SetupException: java.lang.ClassCastException
at 
net.sf.ginp.setup.SetupManagerImpl.writeConfigFromVisit(SetupManagerImpl.java:241)
at 
$SingletonProxy_101289b34b5_122.writeConfigFromVisit($SingletonProxy_101289b34b5_122.java)
at net.sf.ginp.test.TestSetup.testBuildConfigFromVisit(TestSetup.java:150)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at ise.antelope.common.AntelopePanel.executeTargets(AntelopePanel.java:709)
at ise.antelope.common.AntelopePanel$3$1.run(AntelopePanel.java:628)
Caused by: java.lang.ClassCastException
at javax.xml.transform.TransformerFactory.newInstance(Unknown Source)
at net.sf.ginp.util.GinpUtil.transform(GinpUtil.java:97)
at 
net.sf.ginp.setup.SetupManagerImpl.getConfigFromSetupVisit(SetupManagerImpl.java:285)
at 
net.sf.ginp.setup.SetupManagerImpl.writeConfigFromVisit(SetupManagerImpl.java:234)
... 24 more
Testcase: testBuildConfigFromVisit
BUILD FAILED
file:/home/doc/wrk/www/ginp/build.xml:116: Test 
net.sf.ginp.test.TestSetup failed
Total time: 23 seconds
===== BUILD FINISHED =====

I do not know if this is a problem or an environment thing, but you may 
understand it better.

Doug


Justin wrote:

>
> Doug,
>
>     I see you are moving the I18n to resource bundles.  Very cool.  
> One little thing though is try not to reformat my files.  It creates a 
> big cvs diff and it's a little difficult to see what changed between 
> revisions because the whole file gets redone.
>
> Thanks,
>
>     Justin
>
> Doug Culnane wrote:
>
>> Got the file and it works perfectly.
>> Lets stay on the aggressive changes thing for the moment and do a cvs 
>> export and test on a fresh machine later, before we go for a 
>> release.  There are bound to be new problems from the repackaging etc...
>>
>> All the best,
>>
>> Doug
>>
>> Justin wrote:
>>
>>>
>>>
>>> Doug,
>>>
>>>     I added the SetupTag, text fixes, and fixes to the win2k4 style 
>>> to the repository.  The Eclipse's CVS plugin seems to exhibit 
>>> strange behavior occasionally and didn't want to commit these 
>>> files.  I'll check out and build on another machine after I do my 
>>> next batch of commits to verify that everything that should be in 
>>> CVS is there.
>>>        Regards,
>>>
>>> Justin
>>>
>>>
>>
>
>


-- 
Doug Culnane
do...@cu...
www.culnane.net

Re: [Ginp-developers] cvs ci

[Justin <ju...@sq...>]

Doug,

	I added the SetupTag, text fixes, and fixes to the win2k4 style to the 
repository.  The Eclipse's CVS plugin seems to exhibit strange behavior 
occasionally and didn't want to commit these files.  I'll check out and 
build on another machine after I do my next batch of commits to verify 
that everything that should be in CVS is there.
	
	

Regards,

Justin

[Ginp-developers] Feedback on your changes.

[Doug C. <do...@cu...>]

Dear Justin,

I have had a better look at your work and I think it is very good 
although I do not understand much of it yet.  I did a CVSStats report 
(off line) and you now have contributed over 30% of the code to the 
project so thank you very much.

As you will see I have done some cvs ci.  My changes in summery are as 
follows:

Fix the w2k4 style. (easier than I thought)
Move the net.culnane.ginp.TestGinp class to the net.sf.ginp.test package.
Added a test target to build file.  (got all the libraries there now so 
lets use them)
Update documentation files to reflect recent changes.

I had a thought about the text of path to config file directory.  Maybe 
we should do a System.getProperty() type thing so that Windows users get 
a "C:\\Program Files\Apache\Tomcat\conf" type suggestion (Linux 
"/etc/tomcat/base" or "/usr/local/tomcat/conf/" ) by default.  This will 
make the thing so easy that even I would have got it right without 
confusion.  All you have to do is click next, next.....

I am on holiday now and so I hope to find time and enthusiasm to get 
hacking.

All the best and thanks again,

Doug


-- 
Doug Culnane
do...@cu...
www.culnane.net

Re: [Ginp-developers] cvs ci

[Justin <ju...@sq...>]

Doug,

The new stuff should be in CVS.  Let me know if you have any issues with 
it.  I tested it on both Resin and Tomcat.

Regards,

	Justin

Justin wrote:

> 
> Doug,
> 
>     Ok sounds good.  I'll check everything in tonight.  There's a lot. 
> I've got the new version of ginp running my little site gallery right 
> now.  I already handled all the XML parsing stuff.  It also
> automatically upgrades old ginp.xml if you choose upload in the setup.
> 
> Justin
> 
> Doug Culnane wrote:
> 
>> Dear Justin,
>>
>> I have committed a working dom4j xml parsing version of the ginp.xml 
>> config file.  The quality of this is not great because it will crap 
>> out if the xml is not perfectly well formed.  I am committing this so 
>> that you get my latest version and I will stop work and wait for your 
>> big changes.  There is no point in me continuing when you have the DTD 
>> of this config file (and the user structure changes as well), and I 
>> think you will end up throwing my stuff away.
>>
>> I think the XPATH is very useful so I have added the libraries.  I 
>> understand your reasoning for wanting this as it is easy to pull info 
>> out of the xml.  I also understand that my use of it at this stage is 
>> basic.
>>
>> Looking at my comma separated value list of users again I think this 
>> is very bad and insecure so lets get rid of it, with the structure you 
>> suggested.
>>
>> All the best,
>>
>> Doug
>>
> 
> 
> 
> 

Re: [Ginp-developers] cvs ci

[Justin <ju...@sq...>]

Doug,

	Ok sounds good.  I'll check everything in tonight.  There's a lot. 
I've got the new version of ginp running my little site gallery right 
now.  I already handled all the XML parsing stuff.  It also
automatically upgrades old ginp.xml if you choose upload in the setup.

Justin

Doug Culnane wrote:
> Dear Justin,
> 
> I have committed a working dom4j xml parsing version of the ginp.xml 
> config file.  The quality of this is not great because it will crap out 
> if the xml is not perfectly well formed.  I am committing this so that 
> you get my latest version and I will stop work and wait for your big 
> changes.  There is no point in me continuing when you have the DTD of 
> this config file (and the user structure changes as well), and I think 
> you will end up throwing my stuff away.
> 
> I think the XPATH is very useful so I have added the libraries.  I 
> understand your reasoning for wanting this as it is easy to pull info 
> out of the xml.  I also understand that my use of it at this stage is 
> basic.
> 
> Looking at my comma separated value list of users again I think this is 
> very bad and insecure so lets get rid of it, with the structure you 
> suggested.
> 
> All the best,
> 
> Doug
> 

[Ginp-developers] cvs ci

[Doug C. <do...@cu...>]

Dear Justin,

I have committed a working dom4j xml parsing version of the ginp.xml 
config file.  The quality of this is not great because it will crap out 
if the xml is not perfectly well formed.  I am committing this so that 
you get my latest version and I will stop work and wait for your big 
changes.  There is no point in me continuing when you have the DTD of 
this config file (and the user structure changes as well), and I think 
you will end up throwing my stuff away.

I think the XPATH is very useful so I have added the libraries.  I 
understand your reasoning for wanting this as it is easy to pull info 
out of the xml.  I also understand that my use of it at this stage is basic.

Looking at my comma separated value list of users again I think this is 
very bad and insecure so lets get rid of it, with the structure you 
suggested.

All the best,

Doug

-- 
Doug Culnane
do...@cu...
www.culnane.net