Re: [Gimp-print-devel] RFC PATCHv5: Support Kodak 1400, 6800, 6850, 605, 9810

[Robert K. <rl...@sp...>]

On Mon, 14 Jan 2013 07:05:39 -0500, Solomon Peachy wrote:
> On Mon, Jan 14, 2013 at 11:38:50AM +0100, Michael Mraka wrote:
>> It looks like my mail didn't go through so I'm resending it.
>
> Yeah, I've had a couple of failures sending to the list too..
>
>> % Anyway I'd like to ask you to commit your changes in couple of smaller
>> % changesets instead of one huge megapatch; e.g. media type support, row
>> % interlacing support, then support for Kodak 1400, then Kodak 6800, etc.
>> % It's much easier to follow the logic of someoneelse's changes (and fix
>> % bugs there :) when they are broken into stream of "one issue per
>> % commit".
>
> Yeah, I understand -- In the process of that work I managed to break 
> plane-interleaved printing more than once.
>
> So I'll split it all up and commit it piecemeal over the next day or two.
>
> Now we just need some volunteers to test everything.  :)
>
> (I should have a Kodak 1400 in a couple of days, but the other models 
>  are well beyond my budget's ability to justify)

For regression testing purposes, I suggest that you

% cd src/testpattern
% ./run-testpattern-2 -f dyesub -m baseline

on the current baseline.  This will create a directory of MD5 checksum
files for a large number of parameters.

Prior to each commit, repeat this, but with a different -m option.  Then
you can diff against the baseline and see if anything changed.

-- 
Robert Krawitz                                     <rl...@al...>

MIT VI-3 1987 - Congratulations MIT Engineers men's hoops Final Four!
Tall Clubs International  --  http://www.tall.org/ or 1-888-IM-TALL-2
Member of the League for Programming Freedom  --  http://ProgFree.org
Project lead for Gutenprint   --    http://gimp-print.sourceforge.net

"Linux doesn't dictate how I work, I dictate how Linux works."
--Eric Crampton