From: Roger L. <ro...@wh...> - 2001-06-02 23:03:21
|
On Sat, Jun 02, 2001 at 05:56:30PM +0100, Roger Leigh wrote: > I did it this way originally because of needing to do build specific bits > conditionally, but there was some problem with doing it in the Makefile. > Your way is cleaner, but I think there's an even cleaner way: > > configure.in: > AM_CONDITIONAL(TEST_BIN, test x${BUILD_TEST} = xyes) > > Makefile.am: > if TEST_BIN > noinst_PROGRAMS = testdither escp2-weavetest unprint escp2-unprint pcl-unprint bjc-unprint > else > noinst_PROGRAMS = > endif > > I think the problem I originally had was that automake didn't like variables > in its special variables (bin_PROGRAMS, man_MANS etc.) which is why I > chose the current method. If it causes you no problems, then I'll get rid > of all the stuff in configure.in. I think by putting a variable into > the substitution, you fooled automake into not giving the errors I got, > but I think doing it with conditionals is even cleaner. This `cleaner way' won't actually work, even though the generated Makefile is ultimately the same. I have changed everything as you suggested, and I'll commit it later this weekend once I have done some testing (I already found one GNU make-specific construct in src/foomatic). I have also made a few more changes so that it will be easy to convert to my prefered way of doing things when automake is fixed (I'll bring it up soon), as this will mean all of the RULE='$(RULE)' stuff can be deleted as the logic all goes into individual Makefiles. -- Roger Leigh ** Registration Number: 151826, http://counter.li.org ** Need Epson Stylus Utilities? http://gimp-print.sourceforge.net/ For GPG Public Key: finger rl...@to... or see public keyservers. |