DGifSlurp returns error return code

A library and utilities for processing GIFs

Brought to you by: abadger1999, esr

#84 DGifSlurp returns error return code

Milestone: v1.0_(example)

Status: closed

Owner: nobody

Labels: None

Priority: 1

Updated: 2016-03-16

Created: 2016-03-03

Creator: dgs

Private: No

DGifSlurp returns error return code. Always right after successful open/close sequence. Is DGifClose() not closing something?

Attached is a sample project with Makefile included. Runs with 5.1.2

1 Attachments

testgif.tar.gz

Discussion

Mike Sharov - 2016-03-05

I am also experiencing this issue in my project https://github.com/msharov/gleri . GIF loading code is in gotex.cc, can be tested using the included tutorial rgliv image viewer program to view a directory with several GIF files.

Loading a GIF file works the first time, but when a second GIF file is read (even if it is the same file as the first), DGifSlurp always fails.

The problem goes away after downgrading the library from 5.1.2 to 5.1.1.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Stefan Ehmann - 2016-03-06

konqueror is also having problems after the update to 5.1.2.

There is a problem in one of the added sanity checks.

RunningBits seems to be checked before it is initialized. I removed the check. It is redundant because RunningBits is initialized to BitsPerPixel + 1. BitsPerPixel is <= 8 so RunningBits cannot be > 32 anyway.

Last edit: Stefan Ehmann 2016-03-06

patch-fix-sanity-check

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Eric S. Raymond - 2016-03-15

I believe this is now fixed in the repository tip version. Please test and let me know so I can ship an uipdate.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Mike Sharov - 2016-03-15
  
  Works for me with the repository tip.
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Stefan Ehmann - 2016-03-16

Yes, the current version of dgif_lib.c is also working.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Eric S. Raymond - 2016-03-16

Thanks, I'll close this and prepare to ship the fix.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Eric S. Raymond - 2016-03-16

status: open --> closed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

dgs - 2016-08-20

Dear friend!

Have you seen that nice stuff already? You'lllove that for sure, take a look http://siphychowo.fusion94.org/lnmjosp

Best regards, Christianbook.com

alternate

image001.jpg

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

dgs - 2016-08-25

Hello friend,
I've got a good news for you, you'lllike it for sure, read it here please http://fultatufe.capemofo.com/lnxzwo

All the best, gphoto-devel@lists.sf.net

alternate

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

dgs - 2016-09-16

Hello friend,

I saw you last achievements, and I think you need to keep up the good work! Here is some helpful information for you http://trendechoge.mysignspinner.com/lnpry

Wishes, nancygrant65@comcast.net

alternate

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.