[Gfarm-commits] SF.net SVN: gfarm:[6258] gfarm_v2/trunk/lib/libgfarm/gfarm/conn_hash.c

[<n-...@us...>]

Revision: 6258
          http://gfarm.svn.sourceforge.net/gfarm/?rev=6258&view=rev
Author:   n-soda
Date:     2012-04-16 02:50:17 +0000 (Mon, 16 Apr 2012)
Log Message:
-----------
modify comment about using username as a key of connection hash.
see r6217 vs r5040 and r6257.

Revision Links:
--------------
    http://gfarm.svn.sourceforge.net/gfarm/?rev=6217&view=rev
    http://gfarm.svn.sourceforge.net/gfarm/?rev=5040&view=rev
    http://gfarm.svn.sourceforge.net/gfarm/?rev=6257&view=rev

Modified Paths:
--------------
    gfarm_v2/trunk/lib/libgfarm/gfarm/conn_hash.c

Modified: gfarm_v2/trunk/lib/libgfarm/gfarm/conn_hash.c
===================================================================
--- gfarm_v2/trunk/lib/libgfarm/gfarm/conn_hash.c	2012-04-16 01:36:26 UTC (rev 6257)
+++ gfarm_v2/trunk/lib/libgfarm/gfarm/conn_hash.c	2012-04-16 02:50:17 UTC (rev 6258)
@@ -15,7 +15,11 @@
 {
 	const struct gfp_conn_hash_id *id = key;
 
-	/* username is key xxxx username is not key xxxxx */
+	/*
+	 * XXX FIXME: username is currently removed from keys,
+	 * to make GSI authentication work.
+	 * (Should we change GSI authentication protocol?)
+	 */
 	return (gfarm_hash_casefold(id->hostname, strlen(id->hostname)) +
 #ifdef __KERNEL__
 		gfarm_hash_default(id->username, strlen(id->username)) +
@@ -29,7 +33,7 @@
 {
 	const struct gfp_conn_hash_id *id1 = key1, *id2 = key2;
 
-	/* username is not key */
+	/* XXX FIXME: username is currently removed from keys */
 	return (strcasecmp(id1->hostname, id2->hostname) == 0 &&
 #ifdef __KERNEL__
 		strcmp(id1->username, id2->username) == 0 &&

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.