Menu

#28 add menu items+accelerators to move layers up and down

closed-accepted
None
5
2010-08-24
2010-08-24
No

this patch
- unifies the callback names for moving layers up and down
- adds two items to the view menu to move the currently selected layer up and down with accelerators ctrl+up/down (which may break some gtk usability rules, ctrl+page up/down may be a good alternative)
- makes the tree model grab focus, when the mentioned accelerators are activated. the thought behind is, that if someone uses the keyboard to change the order of the layers, he probable wants to do other things with the layers with the keyboard too (e.g. change color, which will work shortly ;).

you (julian) said, that F10 triggers some gtk menu (the app menu in the panel?) on your system. this should not happen imho. i have not tried it in an ubuntu live session, but asked a friend. neither on my nor on his 10.04 ubuntu F10 does anything special. so maybe you have configured this on your own?

Discussion

  • Julian Lamb

    Julian Lamb - 2010-08-24

    Looks great Stefan....I applied it as is.

    Regarding the F10, it looks like a GNOME default...see link:
    http://library.gnome.org/devel/hig-book/stable/input-keyboard.html.en

    In fact, it looks like we shouldn't override F8 either, so I'll change it to F7 instead. Is this okay with you?

    Julian

     
  • Julian Lamb

    Julian Lamb - 2010-08-24
    • assigned_to: nobody --> thepurlieu
    • status: open --> closed-accepted
     

Log in to post a comment.