Re: [Geowebcache-devel] Parameter Filters via GetCapabilitiesConfiguration

[Kevin S. <sm...@dr...>]

On 2017-05-10 6:30 PM, Alex McKeown wrote:
>
> We've made a fork of GeowebCache and altered
> GetCapabilitiesConfiguration.java to take a list of cachedParameters
> in the constructor (in the same way vendorParameters are currently
> defined). We then add a Parameter Filter for each cachedParameter so
> that the given parameters are recognised and cached when requests are
> received.
>
>  
>
> We're thinking of sending through a pull request for our changes, but
> we haven't written up tests or documentation yet. Does anyone have any
> feedback on this solution and might it be something that could be
> merged into the main gwc repo?
>
>  
>
This sounds like a viable idea.  I'd like to try to move away from
configuring things in the application context this way, but
GetCapabilitiesConfiguration is already so dependent on that approach it
would probably be more confusing not to stick with it.  If we ever
change it over to something nicer, we can deal with your changes at the
same time.

Tests and docs would absolutely be required for this.  If you want to
link to the current state of your work, we can give it a quick look over
to comment on your approach before you start documenting and testing it.

-- 
Kevin Michael Smith
<sm...@dr...>