[Geotools-devel] Postgis Datasource Subclassing

[Jody G. <jga...@re...>]

I am sub classing PostgisDataSource and PostgisDataSourceFactory right 
now, and I am getting a bit of impedance. Looks like these classes were 
not designed to be sub classed - is the plan to make them final.

PostgisDataSourceFactory:
- canProcess( Map params ): cannot smoothly call super as dbtype is hard 
coded, added an isDBType( String ) method which subclasses can override

PostgisDataSource:
- a lot of useful variables are private, I cannot tell if this is 
intentional (and subclasses are intended to use accessors)
- particularly vexing is the host of private static fields

I will keep tying for a bit as I hate cut and paste coding.

I saw that OID was the default FID column - I was under the impression 
that OID was not stable across updates.