From: Chris H. <ch...@op...> - 2003-07-22 22:59:58
|
On Tue, 22 Jul 2003, Geoghegan, Sean wrote: > Hi Chris, > > I have been doing some testing with Oracle and the latest Geoserver > release using the DataSourceFinder mechanism. It all seems to work > fine. > One thing I noticed though was that connection handling is particularly > inefficent. It seems there is one connection open for each feature type > and the connections are never closed. I think this needs to be resolved > before 1.0. Yes, it definitely needs to be resolved before 1.0. The current solution was always meant to be temporary until we figured out connection pooling in geotools. > Im not sure how we should do it though. We could maybe > delegate the connection handling to the Datasource Finder mechanism, or > maybe use the J2EE Connection pooling? I need to look more into J2EE Connection pooling - I glanced at it, but was pretty much head down all day pounding through pmd and checkstyle errors. > > I would be particularly interested in having this problem solved and offer any help I can. > > Any ideas? James and I talked a bit, and I think the thing to do may be to have a ConnectionFactory singleton - we would do away with the DBConnectionFactories, as the code for each is practically identical for each - I think the only difference is the driver used. Each jdbc based DataSourceFactory - the one implementing DataSourceFinder - would call on the ConnectionFactory, passing in its appropriate driver and connection path. The ConnectionFactory could then pass back any currently open connection on that driver and path. If there were none open then it would create a new one. So that's a simple solution, and probably where we should start. But recent thinking on locking makes me realize that we will probably need to complicate things, and possible throw out that solution. But I think it is a good place to start, and we can evaluate later if it can be expanded. If you have time this week you can start coding it up - I'm sure there are issues that will be obvious once you start, that we can't think through right now. I'm probably going to be focused on getting geotools ready for beta, but I can definitely jump in if you need thoughts/coding help. I'll also try to look into the j2ee pooling tomorrow. Oh, and you also might look into deegree's code, as I remember they have do implement a Connection Pool. Chris > > Sean Geoghegan > > > > > -----Original Message----- > > From: Chris Holmes [mailto:ch...@op...] > > Sent: Thursday, 17 July 2003 12:53 AM > > To: geo...@li... > > > > GeoServer 0.97 was just released on sourceforge, available at: > > http://prdownloads.sourceforge.net/geoserver/geoserver-0.97.ta > > r.gz?download > > > > This release adds the only operation that GeoServer was > > lacking - GetFeaturesWithLock, so we are now fully > > specification compliant on all operations, including > > transactions and locking. This release has passed an > > extensive test suite of conformance tests as part of the > > OGC's CITE initiative. If you are interested in sql files > > and the proper featureTypes folders for the test data of the > > test suite, let me know. > > You _can_ set up geoserver on your own with the test data > > provided, but it is a lot of work, getting the tables and > > schema.xml files exactly right. > > The test suite is not publically available right now, but it > > should be some time soon. > > > > Now that GeoServer is spec compliant, it's time to focus on > > robustness and usability. We are aiming to get the 1.0 > > release out by the end of september at the latest. A few > > more datasources should be available by then - the oracle > > datasource just needs some testing to make sure it works with > > geoserver, and hopefully others will be available soon. > > Please send problems to this list, and feedback to > > geo...@op..., as we love to hear from our users. > > > > > > thanks, > > > > > > Chris > > > > > > > > > > > > > > > > ------------------------------------------------------- > > This SF.net email is sponsored by: VM Ware With VMware you > > can run multiple operating systems on a single machine. > > WITHOUT REBOOTING! Mix Linux / Windows / Novell virtual > > machines at the same time. Free trial click here: > > http://www.vmware.com/wl/offer/345/0 > > _______________________________________________ > > Geoserver-devel mailing list > > Geo...@li... > > https://lists.sourceforge.net/lists/listinfo/geoserver-devel > > > > > ------------------------------------------------------- > This SF.net email is sponsored by: VM Ware > With VMware you can run multiple operating systems on a single machine. > WITHOUT REBOOTING! Mix Linux / Windows / Novell virtual machines at the > same time. Free trial click here: http://www.vmware.com/wl/offer/345/0 > _______________________________________________ > Geoserver-devel mailing list > Geo...@li... > https://lists.sourceforge.net/lists/listinfo/geoserver-devel > |