From: Justin D. <jde...@op...> - 2013-07-22 12:37:48
|
I think closing an old pull request that the original submitter has not been responsive too is ok. And as long as we explain why we are closing it I think it actually makes the project look better than just leaving it open. So perhaps more of a description on close so that the original author doesn't think they cant re-open or re-submit the pr if they are able to be active again. My $0.02. On Sun, Jul 21, 2013 at 11:21 PM, Ben Caradoc-Davies < Ben...@cs...> wrote: > Old pull requests also undermine branch hygiene. Is an old pull request > for master changed to a pull request for a stable branch when we make a > new stable? I don't think so. Misinterpreted pull requests might end up > merging across branches. Furthermore, single-use pull request branches > should be rebased for merge clarity, or flattened and cherry-picked. Do > we really want a two-year arc in our branch history? > > +1 for closing stable pull requests, and +1 for linking them from Jira. > > Thanks, Brett, for your diligent housekeeping. We will need to clarify > policy at today's meeting. Might be best to let module maintainers preen > pull requests for their modules, but if they do not, other developers > will have to. > > Kind regards, > Ben. > > On 22/07/13 13:04, Brett Walker wrote: > > Andrea Said: > > > > /| Maybe we should link the pull request from the associated > > jira ticket, and then close the pull, so that others might take over > later?/ > > > > I agree with this sentiment. > > > > Some of my random thoughts regarding pull requests: > > > > Pull request are intimately tied to the code base. That big green button > > to merge is compelling at times. Push Me, Push Me… Closing an old (what > > is old?) pull request prevents damaging merges from hitting our code > > base. Jira tickets don’t have this associated risk. > > > > While geotools committers can re-open closed pull requests, I’m unsure > > if the original contributor can do this. I think the original > > contributor cannot, but it is easy to create a new pull request. Note in > > the jira ticket if this is the case > > > > If a jira ticket is not connected to a pull request, then create one. > > > > A pull request has three states: Open, Closed and unmerged, Merged; > > while a jira ticket has more detailed state information. > > > > A useful attribute of pull requests that could be used more is the > > person to which the pull request is assigned. It is mostly left > > unassigned. An assigned person would be a geotools committer. This would > > prevent toes from being damaged. > > > > Brett > > -- > Ben Caradoc-Davies <Ben...@cs...> > Software Engineer > CSIRO Earth Science and Resource Engineering > Australian Resources Research Centre > > > ------------------------------------------------------------------------------ > See everything from the browser to the database with AppDynamics > Get end-to-end visibility with application monitoring from AppDynamics > Isolate bottlenecks and diagnose root cause in seconds. > Start your free trial of AppDynamics Pro today! > http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk > _______________________________________________ > GeoTools-Devel mailing list > Geo...@li... > https://lists.sourceforge.net/lists/listinfo/geotools-devel > -- Justin Deoliveira OpenGeo - http://opengeo.org Enterprise support for open source geospatial. |