From: Justin D. <jde...@op...> - 2012-10-04 13:09:51
|
Thanks Gerson. Patch applied. Yeah, the dev guy does state that but we definitely are fine with just pull requests as well. But it indeed it never hurts to have a jira to accompany a pull request, since that is where we officially generate the changelog from. -Justin On Wed, Oct 3, 2012 at 10:46 PM, Gerson Galang <ger...@gm...>wrote: > Hi Justin, > > I've added JIRA entry for this issue (GEOT-4278) and attached my patch to > it. It's still documented in the developer guide that it's preferable for > casual contributors like me to just attach our patch in JIRA rather than > making a pull request from our repository. So hope all's good. > > Cheers, > > Gerson Galang > Research Software Engineer > Melbourne eResearch Group > The University of Melbourne > > From: Justin Deoliveira <jde...@op...> > Date: Thursday, 4 October 2012 12:31 AM > To: Gerson Galang <ger...@gm...> > Cc: "geo...@li..." < > geo...@li...> > Subject: Re: [Geotools-gt2-users] A temporary workaround to GeoJSON no > such attribute problem? > > Hi Gerson, > > The patch looks good. It might be nice though to allow for parsing null > values via a flag. This would keep the defaults the way they are today. > Something like. > > FeatureJSON.setEncodeNullValues(boolean) > > -Justin > > On Wed, Oct 3, 2012 at 12:08 AM, Gerson Galang <ger...@gm...>wrote: > >> Hi, >> >> In May 2012, Gus MacAulay posted a message on the mailing list about him >> having an issue with FeatureJSON class not being able to handle features >> with differing properties. >> >> >> http://osgeo-org.1560.n6.nabble.com/GeoJSON-No-such-Attribute-problem-td4950845.html >> >> Is there any reason why FeatureJSON skips null value attributes from >> being written into the output GeoJSON document? FeatureJSON won't write >> feature properties with null values as it skips it (see line 527 of >> FeatureJSON.java) but it will read properties with null values fine. To >> make the reading and writing capabilities compatible with each other, I've >> written a patch. Is this acceptable with you guys? >> >> >> https://github.com/gerson721/geotools/commit/41c8ef3af3a15b86ddd139e210b13e72717ce3f7 >> >> Cheers, >> >> Gerson Galang >> Research Software Engineer >> Melbourne eResearch Group >> The University of Melbourne >> >> >> ------------------------------------------------------------------------------ >> Don't let slow site performance ruin your business. Deploy New Relic APM >> Deploy New Relic app performance management and know exactly >> what is happening inside your Ruby, Python, PHP, Java, and .NET app >> Try New Relic at no cost today and get our sweet Data Nerd shirt too! >> http://p.sf.net/sfu/newrelic-dev2dev >> _______________________________________________ >> GeoTools-GT2-Users mailing list >> Geo...@li... >> https://lists.sourceforge.net/lists/listinfo/geotools-gt2-users >> >> > > > -- > Justin Deoliveira > OpenGeo - http://opengeo.org > Enterprise support for open source geospatial. > > -- Justin Deoliveira OpenGeo - http://opengeo.org Enterprise support for open source geospatial. |