[Geotools-devel] MapContext extends MapContent

[Jody G. <jod...@gm...>]

Hi Andrea:

I have another idea that came up when looking at the patch (sorry for picking on your patch Michael, I feel bad as this work is 1/2 done, and my fault in that respect).

You have hit on one of two remaining tasks:

1) update StreamingRenderer to use MapContent
2) update StreamingRenderer to support DirectLayer

With respect to (1) ....

Andrea how do you feel about making MapContent, MapViewport and Layer part of gt-api? We could not have the explicit subclasses like FeatureLayer defined in gt-api (as for example FeatureLayer would be defined by gt-main in order to make use of DataUtilities).

To make that approach "smooth" I would also define a Render interface (to hold setMapContent / getMapContent) and have GTRender extend that:

The GTRender / MapContext / MapLayer classes would remain in gt-render, existing client code can continue to use it as a "nice" way of setting up a MapContent.

-- 
Jody Garnett

On Friday, 6 May 2011 at 4:54 PM, Andrea Aime wrote: 
> On Fri, May 6, 2011 at 3:13 AM, Michael Bedward
> <mic...@gm...> wrote:
> > Hi Jody,
> > 
> > > you are brave!
> > 
> > No, just foolish. See aaime's unhappy comment on the Jira:
> > http://jira.codehaus.org/browse/GEOT-3565
> > 
> > He assumes it will break everything, although the setter and getter
> > for MapContext are still there, just deprecated and the patch is meant
> > only for trunk.
> 
> Ah hem, sorry? This is largely exagerated. Quoting verbatim from
> my comments:
> - "So this is an API change. It will break all existing
> implementations of GTRenderer,
>  in particular afaik the patch does not care for the shapefile renderer. "
> 
> Not saying no to the change, just noting it's an API change that will
> make one of the modules not build anymore.
> 
> - "I also see that the patch removes some c coding style bits with
> more java like one,
>  but I'm unsure if all of them are actually equivalent... Maybe it
> is equivalent but after 10 hours of work I'm too tired to tell :-p
> Allow me some more time to look into the patch. Maybe next time split
> it into two, code cleanups in one patch, api changes in the other. "
> 
> How any of this equates to me _assuming_ it will break everything?
> 
> I want to get the patch applied, just want to double check it since
> the rendering
> subsystem is poorly tested (so trying to compensate lack of testing
> with review).
> 
> Cheers
> Andrea
> 
> 
> -- 
> -------------------------------------------------------
> Ing. Andrea Aime
> GeoSolutions S.A.S.
> Tech lead
> 
> Via Poggio alle Viti 1187
> 55054 Massarosa (LU)
> Italy
> 
> phone: +39 0584 962313
> fax: +39 0584 962313
> 
> http://www.geo-solutions.it
> http://geo-solutions.blogspot.com/
> http://www.youtube.com/user/GeoSolutionsIT
> http://www.linkedin.com/in/andreaaime
> http://twitter.com/geowolf
> 
> -------------------------------------------------------
>