[Geotools-devel] [jira] Created: (GEOT-1922) Minimal Cleanup to FeatureCollection

[Jody G. (JIRA) <ji...@co...>]

Minimal Cleanup to FeatureCollection
------------------------------------

                 Key: GEOT-1922
                 URL: http://jira.codehaus.org/browse/GEOT-1922
             Project: GeoTools
          Issue Type: Bug
          Components: core main
    Affects Versions: 2.5-M2
            Reporter: Jody Garnett
            Assignee: Jody Garnett
         Attachments: feature_collection_java5.patch

There is a really good proposal out on how to clean up FeatureCollection it covers several topics:
- making FeatureCollection not implement java.util.Collection (this is required so we do not accidently allow people to use a for each loop)
- throwing out unused methods from Collection
- creating a FeatureIterator that allows writing
- etc...

We no longer have time to consider this entire proposal for the 2.5.0 release; but we do need to account for the first topic - not using java.util.Collection.

The attached patch has the following changes:
- ResourceCollection no longer extends Collection
- ResourceCollection is method compatible with collection
- DataUtilities.list( FeatureCollection ): List - used to adapt to a real collection for a few test cases (around 12 failures)
- Isolating the two prepCollection and prepFeatureCollection methods in StreamingRenderer


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira