[Geotools-devel] Inconsistencies in ReferencedEnvelope

[Martin D. <mar...@ge...>]

I had a look (by accident) to ReferencedEnvelope. I noticed 3 "reference" 
methods, which are inconsistent with each other:

ReferencedEnvelope reference(ReferencedEnvelope)
------------------------------------------------
Had no documentation, but looking at the code it the create a new instance of 
ReferencedEnvelope inconditionnaly, given a non-null argument.


ReferencedEnvelope reference(Envelope)
--------------------------------------
Creates a new ReferencedEnvelope only if necessary, in which case the CRS is set 
to null. Otherwise returns the existing ReferencedEnvelope with its CRS preserved.


ReferencedEnvelope reference(BoundingBox)
-----------------------------------------
Creates a new ReferencedEnvelope only if necessary and set copy the CRS.


Unless there is some mysterious reasons for having inconsistent "reference" 
methods in their behavior (whatever new instances are created or not and in CRS 
setting), can the guys who wrote those methods try to put a little bit of 
consistency among them please?

	Martin