[Geotools-devel] ArcSDE state of play, some mistakes due to new feature model handling of Date converations

[Jody G. <jga...@re...>]

I have been a bit puzzled by some of the test failures, specifically 
FilterTest.testBBoxFilter. The two features being compared (and failing) 
are pretty much the same ... except for a Date comparison.

The two dates look equal to the toString method; but on closer 
inspection they have different values for the internal "fastTime" field.
- 1088924400500
- 1088924400531

It really feels like this is a date stamp of some sort that is being 
incorrectly provided as an attribute value.
- the first feature is obtained by grabbing all the content and doing a 
BBOX filter on the client side
- the second one is obtained using a BBOX filter
- they have the same SDE.DELETE_ME.4 feature id

I was thinking this was a date stamp but it looks like a programming bug ...

AttributeImpl:DATE_COL=Sun Jul 04 00:00:00 PDT 2004

Interestingly the values come out of the sdeAttReader as a 
GregorianCalendar; and the time field is empty. Chances are these are 
only suppoed to represent a specific Day and not a timestamp.

Chased the code into SimpleFeatureBuilder, Converters, 
TemporalConverterFactory and the following block of code:
> return target.getConstructor( new Class[] { Long.TYPE } 
> ).newInstance(  new Object[]{ new Long( calendar.getTimeInMillis() ) }
I will need to fix up this method to actually respect what the Calendar 
means - ie does not actually specify a time.
Jody