From: Andrea A. <aa...@op...> - 2008-04-18 13:10:56
|
Jody Garnett ha scritto: > Daniele Romagnoli wrote: >> Hi list, >> some time ago I have noticed that the developers guide suggests to use >> JALOPY for code formatting. >> http://docs.codehaus.org/display/GEOT/5.1.1+Coding+Conventions >> >> Someone (^_^) told me that Jalopy has been abandoned and (with >> eclipse) we should use the formatting rules available here: >> http://svn.geotools.org/geotools/trunk/gt/build/eclipse/ >> >> Should we update the developers guide? > We should mention that in the developers guide; although honestly we > need something that can run from NetBeans and Eclipse. The eclipse > formatting settings were just designed to let eclipse produce code that > was close. > > I thought we still had the option of running the Jalopy settings from maven? It's ugly, not really an option imho. It will rewrite the file completely even if it was not modified, and may introduce cross platform issues due to newline changes. We had to stop using it in GeoServer for that reason at least. I know it's possible to run the eclipse code formatter stand alone... Hibernate folks somehow managed to do that: http://opensource.atlassian.com/projects/hibernate/browse/HBX-811 (how they did this, I don't know). Cheers Andrea |