Re: [Geotools-devel] On long build times

[Andrea A. <aa...@op...>]

Martin Desruisseaux ha scritto:
> Andrea Aime a écrit :
>> I personally had a look into the EPSG authority one
>> and spotted a handful of tests that are using most of the time,
>> they are tests checking full scans of the db looking for
>> a code it's not there and a multithreaded load test. Making
>> them into "extensive" ones takes the build time of that
>> module down to 15s (quite a gain down from over one minute).
>> I've attached a patch, Martin, can you have a look at it
>> and see if it's ok to commit? (I guess the same patch can
>> be applied to 2.4.x to the same effect).
> 
> For the full scan, I don't remember doing that... 

It may be my doing, since it's related to CRS.lookupIdentifier, thought
I don't remember adding the same test three times (actually I think
it's running against different decorators of the base factory, not sure).

> For the multithreaded stuff,
> it was Refraction's work from last summer, so maybe Jody wants to look at the
> proposed patch? (I didn't had the time to review the multithreaded work yet :(
> ). Otherwise I would said "go for it".

Well, the patch for each method is really simple. It's about adding, at 
the beginning of the method:

if(!TestData.isExtensive())
   return;

> In theory, the patch should not impact the 2.4 branch since the multithread work
> is supposed to be on trunk only. Actually I remember that back in 2.3, we did
> some efforts for reducing epsg-hsql test time (TestData.isExtensive() has been
> introduced partially for epsg-hsql if I remember right).

Yep.

> Thanks a lot for looking at that!

My pleasure
Cheers
Andrea