From: Andrea A. <aa...@op...> - 2007-12-29 20:56:54
|
Justin Deoliveira ha scritto: > Hi Andrea, > > Glad you tracked it down. I looked over the patch and have a slight > alternative. Instead of tracking wether there is a connection problem in > the MySQLTestSetup, I think it wold also work if we did it right in > JDBCTestSupport#setup(). This way the check is in a single place and we > dont have to worry about doing the same trick for other databases when > they get implemented. How about I commit the patch and you try it out. Hum, why not? I tried something along these lines, but if I used a field in the class, it was useless as the class was recreated for each method call (maybe that happens only in eclipse?) and if I used a static variable that would have affected h2 tests as well. > I also notice from your patch that some test methods are commented out > stating that they break the build. Any idea what is going on there? In my patch? Hmm... don't remember... maybe I did comment them out when the thing first broke the build some time ago and I did not notice it. Cheers Andrea |