[Geotools-devel] [jira] Created: (GEOT-1613) MaxIncFIDMapper does not close result set

[Jody G. (JIRA) <ji...@co...>]

MaxIncFIDMapper does not close result set
-----------------------------------------

                 Key: GEOT-1613
                 URL: http://jira.codehaus.org/browse/GEOT-1613
             Project: GeoTools
          Issue Type: Bug
    Affects Versions: 2.3.5
            Reporter: Jody Garnett
            Assignee: Jody Garnett


Thanks to Federico Nieri for reporting this:
{panel}
I have found the problem.  It's a bug on the class  org.geotools.data.jdbc.fidmapper.MaxIncFIDMapper in the main module.
{code}

    /**
     * @see org.geotools.data.jdbc.fidmapper.FIDMapper#createID(java.sql.Connection,
     *      Feature, Statement)
     */
    public String createID(Connection conn, Feature feature, Statement statement)
        throws IOException {
        try {
            Statement stmt = conn.createStatement();
            ResultSet rs = stmt.executeQuery("Select MAX(" + FIDColumn
                    + ") from " + tableName);

            if (rs.next()) {
                int maxFid = rs.getInt(1);

                return String.valueOf(maxFid + 1);
            } else {
                throw new DataSourceException("Could not get MAX for "
                    + tableName + "." + FIDColumn
                    + ": No result returned from query");
            }
        } catch (SQLException e) {
            throw new DataSourceException("An sql problem occurred. Are the table and the fid column there?",
                e);
        }
    }
{code}

doesn't close the result set and the statement and so after some cicle it finish cursors on DB! I'm using the 2.1.0 version, but this problem is only on the 2.3.5  Do you know how I can report this bug?

Where can I submit it?
{panel}


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira