Re: [Geotools-devel] Logging switch

[Martin D. <mar...@ge...>]

Justin Deoliveira a écrit :
> However, way back when we had a discussion and it was mostly agreed to
> switch to commons logging. Even Martin agreed that if the rest of the
> developers were for the change that he would concede (correct if i am
> wrong here Martin).

You are right. At that time, I didn't though about redirecting to common-loggin;
the idea came later after discussion with Andrea, and CommonHandler was born
from that. Yet it was probably a more complicated hack than necessary, since
CommonLogger would be simplier and more straightforward. I didn't though about
CommonLogger at that time neither; again, this is Andrea who gave me this idea
with his org.geotools.logging package proposal.

> So what I am saying is I would rather see effort go into a switch to
> commons logging rather than the search and replace discussed above.

What aboug giving a try to CommonLogger? It seems so straightforward to me that
I believe that it would be fast to implement. The search and replace should be
quite fast too, using the "Logger\s*\.\s*get" regular expression. So I believe
that giving a try in Geotools would not cost us a lot.

> Actually when i spec'd it out way back when most of the commons logging
> switch can be done with a search and replace as well.

Maybe be in other modules, but not in metadata, referencing, coverage, etc.
Those modules use logging beyong what common-logging API allows. The replacement
would not be straightfoward and would imply the lost of some functionalities. In
almost every place where I use logging, I attach some extra information like the
public API that emmited the logging (which may not be the API detected by the
logging framework - lets also remind that automatic detection is unreliable, no
matter the logging framework, since they are affected by HotSpot optimization).
So to make a comparaison, I would see switching to common-logging a little bit
like truncating the stack trace in exceptions.

So would it be acceptable to give a try to CommonLogger first?

    Martin