[Geotools-devel] Fix GEOT-1038? Lets get a move on

[Jody G. <jga...@re...>]

Bleah - please commit (this is trunk). And test cases that verify the 
"fix" would be helpful.
Can I ask if GeoTools 2.3 also suffers from the same breakage? Or is 
this part of the work
Justin and I did (or later that Cory did for the aggregate functions?)

Gabriel I will be on IRC all this week if you want to work on these 
things together.

Regards,
Jody
> Hi all,
>
> as you may see in http://jira.codehaus.org/browse/GEOT-1038, almost all 
> FunctionExpression implementations in trunk are broken.
>
> I'm working on fixing it, but since it means modifying like 130 classes, I 
> want to ask the responsibles for direction: should I fix and commit, provided 
> that the test cases I wrote, which exposes 373 bugs, all pass; or should I 
> send a patch?
>
> btw, since most Functions inherit from FunctionExpressionImpl, the fix for 
> them is just to remove its internal Expression[] fields and properly delegate 
> to the superclass methods, which already take care of making the deprecated 
> methods play nice with the new ones from the GeoAPI Function interface.
>
> Regards,
>
>