|
From: Justin D. <jde...@op...> - 2006-11-05 20:59:07
|
Jody, I notice that you have changed Filter.NONE to Filter.INCLUDE and Filter.ALL to Filter.EXCLUDE. Is this really necessary? For one, to me this is even more confusing then before. With the old names, one can say "Filter.ALL filters all", and "Filter.NONE filters none", this seems to be more expressive then "Filter.EXCLUDE filters all, and Filter.INCLUDE filters none". Two this makes it more work for people to switch over. With the change over, we are forcing people to use the geoapi interfaces, but now also forcing the name in constants. If the names were the same all I would have to do is change the Filter import and it would still work. I know this isn't a huge deal as its just a search and replace, but it seems to me to be needless work. Anyways, people may disagree, but this is just my 2 cents. -Justin -- Justin Deoliveira The Open Planning Project jde...@op... |