From: Chris H. <ch...@op...> - 2006-04-24 23:03:10
|
Richard Gould wrote: > Looks like it has already been removed on trunk. > > It is safe for you to ignore it. As Chris Holmes stated, that GPL > license should not be there. > > The only remaining issue I can see is TestFilterHandler.java in > module/main has a VFNY GPL copyright on it: > > /* Copyright (c) 2002 Vision for New York - www.vfny.org. All rights > reserved. > * This code is licensed under the GPL 2.0 license, availible at the root > * application directory. > */ > > Does anyone know if this can be safely removed as well? The file has Rob > Hranac's name on it. Yup VFNY == TOPP, it can be safely removed, wasn't intended to go in GPL. Chris > > Cheers > > Richard > > per...@no... wrote: > >> This is what I found in the (version 2.1.0) sources, at the beginning of >> MySQLDataStoreFactory.java: >> >> /* Copyright (c) 2001, 2003 TOPP - www.openplans.org. All rights >> reserved. >> * This code is licensed under the GPL 2.0 license, availible at the >> root >> * application directory. >> */ >> /* >> * Geotools2 - OpenSource mapping toolkit >> * http://geotools.org >> * (C) 2002, Geotools Project Managment Committee (PMC) >> * >> * This library is free software; you can redistribute it and/or >> * modify it under the terms of the GNU Lesser General Public >> * License as published by the Free Software Foundation; >> * version 2.1 of the License. >> * >> * This library is distributed in the hope that it will be useful, >> * but WITHOUT ANY WARRANTY; without even the implied warranty of >> * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU >> * Lesser General Public License for more details. >> * >> */ >> >> So, there are two conflicting licenses in it. >> >> Pertti >> >>> -----Original Message----- >>> From: ext Richard Gould [mailto:rg...@re...] Sent: 23 >>> April 2006 23:34 >>> To: Tapola Pertti (Nokia-NET/Espoo) >>> Cc: jga...@re...; Haggstrom Hans (Nokia-NET/Espoo); >>> geo...@li... >>> Subject: Re: [Geotools-devel] GeoTools license information incorrect >>> in the Wiki >>> >>> Thanks Pertti. I have updated all of the modules to indicate that >>> there is an issue. I will bring it up during tomorrow's GeoTools >>> meeting as well. >>> >>> Note that I could not find anything wrong in MySQLDataStoreFactory.java >>> >>> Updated the pages at: >>> http://docs.codehaus.org/display/GEOTOOLS/Indexed-Shapefile >>> http://docs.codehaus.org/display/GEOTOOLS/Main >>> http://docs.codehaus.org/display/GEOTOOLS/Tiger >>> http://docs.codehaus.org/display/GEOTOOLS/Validation >>> >>> Cheers, >>> >>> Richard >>> >>> per...@no... wrote: >>> >>>> Here is a list of GPL-licensed files that we found (by >>> >>> >>> searching for " >>> >>>> GPL" in the files): >>>> >>>> >>> >>> ext\indexed-shapefile\src\org\geotools\data\shapefile\indexed\IndexedS >>> >>>> ha >>>> pefileDataStoreFactory.java >>>> >>> >>> ext\validation\src\org\geotools\validation\attributes\EqualityValidati >>> >>>> on >>>> .java >>>> >>> >>> ext\validation\src\org\geotools\validation\attributes\NullZeroValidati >>> >>>> on >>>> .java >>>> >>> >>> ext\validation\src\org\geotools\validation\attributes\RangeValidation. >>> >>>> ja >>>> va >>>> >>> >>> ext\validation\src\org\geotools\validation\attributes\UniqueFIDValidat >>> >>>> io >>>> n.java >>>> >>> >>> ext\validation\src\org\geotools\validation\attributes\UniquityValidati >>> >>>> on >>>> .java >>>> >>> >>> ext\validation\src\org\geotools\validation\DefaultFeatureValidation.ja >>> >>>> va >>> >>> >>> ext\validation\src\org\geotools\validation\DefaultIntegrityValidation. >>> >>>> ja >>>> va >>>> ext\validation\src\org\geotools\validation\dto\PlugInDTO.java >>>> ext\validation\src\org\geotools\validation\dto\TestDTO.java >>>> ext\validation\src\org\geotools\validation\dto\TestSuiteDTO.java >>>> ext\validation\src\org\geotools\validation\FeatureValidation.java >>>> ext\validation\src\org\geotools\validation\IntegrityValidation.java >>>> ext\validation\src\org\geotools\validation\PlugIn.java >>>> >>> >>> ext\validation\src\org\geotools\validation\relate\ContainsIntegrity.ja >>> >>>> va >>> >>> >>> ext\validation\src\org\geotools\validation\relate\ContainsIntegrityBea >>> >>>> nI >>>> nfo.java >>>> >>> >>> ext\validation\src\org\geotools\validation\relate\CrossesIntegrity.jav >>> >>>> a >>> >>> >>> ext\validation\src\org\geotools\validation\relate\CrossesIntegrityBean >>> >>>> In >>>> fo.java >>>> >>> >>> ext\validation\src\org\geotools\validation\relate\DisjointIntegrity.ja >>> >>>> va >>> >>> >>> ext\validation\src\org\geotools\validation\relate\DisjointIntegrityBea >>> >>>> nI >>>> nfo.java >>>> >>> >>> ext\validation\src\org\geotools\validation\relate\IntersectsIntegrity. >>> >>>> ja >>>> va >>>> >>> >>> ext\validation\src\org\geotools\validation\relate\IntersectsIntegrityB >>> >>>> ea >>>> nInfo.java >>>> >>> >>> ext\validation\src\org\geotools\validation\relate\OverlapsIntegrity.ja >>> >>>> va >>> >>> >>> ext\validation\src\org\geotools\validation\relate\OverlapsIntegrityBea >>> >>>> nI >>>> nfo.java >>>> >>> >>> ext\validation\src\org\geotools\validation\relate\RelateIntegrity.java >>> >>> ext\validation\src\org\geotools\validation\relate\RelateIntegrityBeanI >>> >>>> nf >>>> o.java >>>> >>> >>> ext\validation\src\org\geotools\validation\relate\RelationIntegrity.ja >>> >>>> va >>> >>> >>> ext\validation\src\org\geotools\validation\relate\RelationIntegrityBea >>> >>>> nI >>>> nfo.java >>>> >>> >>> ext\validation\src\org\geotools\validation\relate\SpatialTestCase.java >>> >>> ext\validation\src\org\geotools\validation\relate\TouchesIntegrity.jav >>> >>>> a >>> >>> >>> ext\validation\src\org\geotools\validation\relate\TouchesIntegrityBean >>> >>>> In >>>> fo.java >>>> >>> >>> ext\validation\src\org\geotools\validation\relate\WithinIntegrity.java >>> >>> ext\validation\src\org\geotools\validation\relate\WithinIntegrityBeanI >>> >>>> nf >>>> o.java >>>> >>> >>> ext\validation\src\org\geotools\validation\spatial\IsValidGeometryVali >>> >>>> da >>>> tion.java >>>> >>> >>> ext\validation\src\org\geotools\validation\spatial\LineCoveredByPolygo >>> >>>> nV >>>> alidation.java >>>> >>> >>> ext\validation\src\org\geotools\validation\spatial\LineNoSelfOverlappi >>> >>>> ng >>>> Validation.java >>>> >>> >>> ext\validation\src\org\geotools\validation\spatial\LinesNotIntersectVa >>> >>>> li >>>> dation.java >>>> ext\validation\src\org\geotools\validation\Validation.java >>>> ext\validation\src\org\geotools\validation\ValidationBeanInfo.java >>>> ext\validation\src\org\geotools\validation\ValidationResults.java >>>> ext\validation\src\org\geotools\validation\Validator.java >>>> ext\validation\src\org\geotools\validation\xml\ArgHelper.java >>>> ext\validation\src\org\geotools\validation\xml\ReaderUtils.java >>>> >>> >>> ext\validation\src\org\geotools\validation\xml\ValidationException.jav >>> >>>> a ext\validation\src\org\geotools\validation\xml\WriterUtils.java >>>> ext\validation\src\org\geotools\validation\xml\XMLReader.java >>>> >>> >>> ext\validation\test\org\geotools\validation\attributes\NullZeroValidat >>> >>>> io >>>> nTest.java >>>> >>> >>> ext\validation\test\org\geotools\validation\attributes\RangeFeatureVal >>> >>>> id >>>> ationTest.java >>>> >>> >>> ext\validation\test\org\geotools\validation\FeatureValidationTest.java >>> >>> ext\validation\test\org\geotools\validation\IntegrityValidationTest.ja >>> >>>> va >>> >>> >>> ext\validation\test\org\geotools\validation\relate\OverlapsIntegrityTe >>> >>>> st >>>> .java >>>> >>> >>> ext\validation\test\org\geotools\validation\RoadNetworkValidationResul >>> >>>> ts >>>> .java >>>> >>> >>> ext\validation\test\org\geotools\validation\RoadValidationResults.java >>> >>> ext\validation\test\org\geotools\validation\UniqueFIDIntegrityValidati >>> >>>> on >>>> .java >>>> >>> >>> ext\validation\test\org\geotools\validation\ValidationPlugInTester.jav >>> >>>> a >>> >>> >>> ext\validation\test\org\geotools\validation\ValidationProcessorTest.ja >>> >>>> va ext\validation\test\org\geotools\validation\xml\XMLReaderTest.java >>>> module\main\test\org\geotools\filter\TestFilterHandler.java >>>> plugin\mysql\src\org\geotools\data\mysql\MySQLDataStoreFactory.java >>> >>> >>> Could not see anything wrong with this file. >>> >>> >>>> plugin\tiger\src\org\geotools\data\tiger\TigerDataStoreFactory.java >>>> >>>> Pertti >>>> >>>> >>>> >>>> >>>>> -----Original Message----- >>>>> From: ext Jody Garnett [mailto:jga...@re...] >>>>> Sent: 18 April 2006 16:20 >>>>> To: Haggstrom Hans (Nokia-NET/Espoo) >>>>> Cc: geo...@li...; Tapola Pertti >>>>> (Nokia-NET/Espoo); Richard Gould >>>>> Subject: Re: [Geotools-devel] GeoTools license information >>>>> incorrect in the Wiki >>>>> >>>>> Han...@no... wrote: >>>>> >>>>> Good timing Hans, we are in the middle of an IP review as >>> >>> >>> part of our >>> >>>>> involvement with the OSGEO Foundation, it seems you have the jump >>>>> on us. The project is intentended to be LGPL, commercial >>> >>> >>> friendly and so >>> >>>>> on. I will go fix the SF page now, we do not really use their >>>>> facilities other then for code distribution. >>>>> >>>>> Any code that does not meet this will be rewritten. >>>>> >>>>> >>>>>> Hello, >>>>>> >>>>>> In the documentation in the GeoTools wiki the license for >>>>> >>>>> >>>>> GeoTools is >>>>> >>>>> >>>>>> described as LGPL ( >>>>>> _http://www.geotools.org/display/GEOT/1.4+Source+License_ ). >>>>>> >>>>>> However, on the sourceforge project page the licenses GPL, >>> >>> >>> LGPL, and >>> >>>>>> MIT are listed ( _http://sourceforge.net/projects/geotools/_ ). >>>>>> >>>>>> In the sources (for version 2.1.0), there seems to be both LGPL >>>>>> and GPL licensed code (based on license comments in files), as >>>>> >>>>> >>>>> well as one >>>>> >>>>> >>>>>> source file covered by the Sun license (NumberParser.java, >>>>> >>>>> >>>>> copied from >>>>> >>>>> >>>>>> an old version of the JDK perhaps?). The Sun license comment reads: >>>>>> >>>>>> * Copyright 2002 Sun Microsystems, Inc. All rights reserved. >>>>>> * SUN PROPRIETARY/CONFIDENTIAL. Use is subject to license terms. >>>>>> >>>>>> Could the Wiki page mentioning only LGPL be updated to reflect the >>>>>> licenses mentioned on the sourceforge page? (Or alternatively the >>>>>> code updated to only contain LGPL licensed code, althought that is >>>>>> probably a more long term effort). Also, the Sun licensed file >>>>>> should probably be replaced or at least investigated, as it >>> >>> >>> seems to >>> >>>>>> be incompatible with GPL and LGPL. >>>>>> >>>>>> >>>>>> >>>>>> We wanted to use the main-2.1.0.jar and shapefile-2.1.0.jar >>> >>> >>> with the >>> >>>>>> LGPL license. Fortunately, these two Jars did only contain >>> >>> >>> one unit >>> >>>>>> test file and one html file that were GPL licensed, and the Sun >>>>>> licensed NumberParser.java (used for parsing some doubles from >>>>>> strings). We removed the test, html file, and >>>>> >>>>> >>>>> NumberParser.java. We >>>>> >>>>> >>>>>> had to replace the places where NumberParser.java was used (in >>>>>> DbaseFileReader.java) with (slower) calls to standard JDK >>>>> >>>>> >>>>> library methods. >>>>> >>>>> Darn shapefile was just checked by Richard, I will ask him to look >>>>> into this and get back to you. Probably would not hurt to >>> >>> >>> open a issue >>> >>>>> on this stuff.. >>>>> >>>>> >>>>>> According to LGPL we make our changes to the code available in the >>>>>> attached file (it was the only changed source file). >>>>>> >>>>> >>>>> Thanks muchly, >>>>> Jody >>>>> >>>>> >>> >>> > > > > ------------------------------------------------------- > Using Tomcat but need to do more? Need to support web services, security? > Get stuff done quickly with pre-integrated technology to make your job > easier > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > _______________________________________________ > Geotools-devel mailing list > Geo...@li... > https://lists.sourceforge.net/lists/listinfo/geotools-devel -- Chris Holmes The Open Planning Project http://topp.openplans.org |