Re: [Geotools-devel] A couple mistakes in styleland

[Cory H. <ch...@re...>]

Jody Garnett wrote:

> NamedStyle was not an interface
> StyleFactory was not an interface
>
> The last one is more serious, there are a couple entries to 
> StyleFactory.createStyleFactory that are about to get broken.
> Afraid this is a mistake, and things break (GeoServer and uDig in this 
> case).
> Code will be refactored to use a StyleFactoryFinder, details when they 
> are available.

I broke a few more things out into interfaces, and moved some more of 
org.geotools.styling over to modules/api...

Added:
   geotools/branches/stylish/gt/module/api/src/org/geotools/styling/FeatureTypeConstraint.java
   geotools/branches/stylish/gt/module/api/src/org/geotools/styling/NamedLayer.java
   geotools/branches/stylish/gt/module/api/src/org/geotools/styling/RemoteOWS.java
   geotools/branches/stylish/gt/module/api/src/org/geotools/styling/StyledLayer.java
   geotools/branches/stylish/gt/module/api/src/org/geotools/styling/UserLayer.java
   geotools/branches/stylish/gt/module/api/src/org/geotools/styling/UserStyle.java
   geotools/branches/stylish/gt/module/main/src/org/geotools/styling/NamedLayerImpl.java
   geotools/branches/stylish/gt/module/main/src/org/geotools/styling/StyledLayerImpl.java
   geotools/branches/stylish/gt/module/main/src/org/geotools/styling/UserLayerImpl.java
Removed:
   geotools/branches/stylish/gt/module/main/src/org/geotools/styling/FeatureTypeConstraint.java
   geotools/branches/stylish/gt/module/main/src/org/geotools/styling/NamedLayer.java
   geotools/branches/stylish/gt/module/main/src/org/geotools/styling/RemoteOWS.java
   geotools/branches/stylish/gt/module/main/src/org/geotools/styling/StyledLayer.java
   geotools/branches/stylish/gt/module/main/src/org/geotools/styling/UserLayer.java
Modified:
   geotools/branches/stylish/gt/module/main/src/org/geotools/styling/SLDParser.java
   geotools/branches/stylish/gt/module/main/src/org/geotools/styling/StyledLayerDescriptor.java
   geotools/branches/stylish/gt/module/main/src/org/geotools/xml/styling/sldComplexTypes2.java
   geotools/branches/stylish/gt/module/main/test/org/geotools/styling/SLDStyleTest.java


Note that UserStyle is a new interface (it was in the sld-1.0.0 spec, so 
I added it), but it has no implementation.

Much ado about refactoring?

Cheers,
Cory.