Re: [Geotools-devel] Merging JDBCDataStore changes

[Chris H. <ch...@op...>]

Quoting "Amr A. Alam" <aa...@re...>:

> Hey Chris,
> I've completed my changes on my branch for breaking out JDBCDataStore
> into JDBC1DataStore, and JDBC2DataStore.
Congrats!

>
> I've successfully built both trunk and 2.1.x after merging in my
> branch
> locally. (With a minor change to postgis --included in attached
> patch)
>
> Now I need to get these changes merged into both trunk and 2.1.x by a
> PMC, hopefully one who is also the module maintainer of PostGIS.
> I also need a code review of my changes so that I may go ahead and
> add/commit my new HSQL plugin (my commit rights are pending a code
> review).
Ok, I think you're changes look fine to me.  Though it's obviously been
too long since I looked at the JDBCDataStore class.  We've got all
kinds of Catalog and Metadata stuff in there?  Where did that come
from?  It looks like none of it is in the interfaces, so perhaps it's
remnants of the days before we steered clear of that direction?  One
thing you're missing is adding your name in the author section.

I'm also don't really think we should put these changes in 2.1.x - it's
a bit of an api change, and as such I think should just be in trunk.  I
suppose I could be convinced otherwise, but I thought 2.1.x should just
be bug fixes, without changing any api?  This change is relatively
minor, but I fear setting a precedent, where improvements and api
changes are split between trunk and head.  Like we're past just 'stable
branch', we're now in 'released branch'.  Head should move towards
stability, and we should be making releases off of it, and using branch
and merge for api changes.

I can't do the merge, as my svn is still screwed.  My ISP is supposedly
working on it.  But they kinda suck.

Chris


>
> The changes on the branch also include some bug fixes.
>
> The changes are in the *jdbc1-exp* branch, i wasn't able to create a
> patch since the patch would just show that some files were added, and
> not get the content of the new files...(all the changes are confined
> to
> 'jdbc1-exp/src/org/geotools/data/jdbc/')
>
> Let me know if you need anything else.
>
> Amr.
>




----------------------------------------------------------
This mail sent through IMP: https://webmail.limegroup.com/