From: Chris H. <ch...@op...> - 2005-05-20 16:23:47
|
Erm. Maybe contains is faster? Ask Andrea, I actually suspect it's a vestige of a former time when we actually did the envelope stuff ourselves, I forget why, but Andrea initially did an improvement with just checking the bounds before passing to JTS. I suspect maybe he just translated that straight into JTS speak when it was available or some such, without seeing the shortcut... C Quoting db...@op...: > org.geotools.filter.GeometryFilterImpl::contains(Feature)::(about > line > 240) > .. > > else if (filterType == GEOMETRY_BBOX) { > if(envRight.contains(envLeft) || > envLeft.contains(envRight)) > { > return true; > } else if(envRight.intersects(envLeft)) { > return left.intersects(right); > } else { > return false; > } > > Whats going on? > > shouldnt this just be: > > return envRight.intersects(envLeft) || left.intersects(right); > > dave > > > ---------------------------------------------------------- > This mail sent through IMP: https://webmail.limegroup.com/ > > > ------------------------------------------------------- > This SF.Net email is sponsored by Oracle Space Sweepstakes > Want to be the first software developer in space? > Enter now for the Oracle Space Sweepstakes! > http://ads.osdn.com/?ad_id=7412&alloc_id=16344&op=click > _______________________________________________ > Geotools-devel mailing list > Geo...@li... > https://lists.sourceforge.net/lists/listinfo/geotools-devel > ---------------------------------------------------------- This mail sent through IMP: https://webmail.limegroup.com/ |