[Geotools-devel] [jira] Reopened: (GEOT-90) Change Param to URL.class (rather than String.class)

[<ji...@co...>]

Message:

   The following issue has been reopened.

   Reopener: Jody Garnett
       Date: Wed, 11 Feb 2004 2:38 PM

Currently createDataStore returns null, rather than an error when given a malformed url String.
---------------------------------------------------------------------
View the issue:
  http://jira.codehaus.org/secure/ViewIssue.jspa?key=GEOT-90

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: GEOT-90
    Summary: Change Param to URL.class (rather than String.class)
       Type: Improvement

     Status: Reopened
   Priority: Minor

 Original Estimate: 1 hour
 Time Spent: 5 minutes
  Remaining: 55 minutes

    Project: GeoTools
 Components: 
             shapefile
   Fix Fors:
             2.0-b2

   Assignee: 
   Reporter: Jody Garnett

    Created: Mon, 2 Feb 2004 4:30 AM
    Updated: Wed, 11 Feb 2004 2:38 PM
Environment: GeoServer

Description:
GeoServer makes the following use of Params:
#1 - generate custom input fields based on param type
#2 - provide relative file URLs

Currently, for the sake of ShapefileDataStore GeoServer recognizes the key: "url" and values starting with "file:". This allows relative file URLs to be used with Shapefile DataStore.

What this request boils down to is:

public DataStore createDataStore(Map params) throws IOException {
   URL url = (URL) getParametersInfo[0].lookUp(params);
   ...
}

public Param[] getParametersInfo() {
   return new Param[] { new Param("url", URL.class, "url to a .shp file") };
}

With a similar change for canProcess(), this will allow GeoServer to make use of #1/#2 while not breaking any existing applications. Param class knows how to deal with String.class where URL.class is required.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira