From: <Sim...@cs...> - 2012-05-16 01:48:43
|
Hi Jesse, This sounds like really good work and even better when it turns up critical fixes! For my part, I think you should commit these as soon as possible so that we can all use them in the RC process. Cheers and thanks, Simon ________________________________________ From: Jesse Eichar [jes...@ca...] Sent: Wednesday, 16 May 2012 4:52 AM To: Devel geo...@li... Subject: [GeoNetwork-devel] web-itest Hi, web-itest has been commented out from the build. And I have a branch which changes the web-itest module to be webspecs maven adapter. It checks out webspecs and runs the integration tests. All the tests currently in web-itest are in the webspecs as well. The module is only included in the build if the integration-tests profile is activated so the idea is that this would primarily be used on the continuous integration build and not each time a developer builds. Last weekend I spent sometime to get most of the tests passing again and as a result found a couple of errors. One was a database connection leak which I consider to be critical. My question: Can I merge these change to trunk? (it does not affect build without profile so it is a pretty safe change.) Not all tests pass yet because there have been enough changes since January (when I wrote them) that some have been broken but again it doesn't affect build and it does have some important fixes. Jesse |