From: <L....@su...> - 2006-12-28 18:13:16
|
Steve, Good job on catching all the docs changes and .geomview use. But Geomview needs to be backward compatible, and also support .geomview = files if they are used by "now-legacy" modules. Your changes to /src/bin/geomview/common/worldio.c don't do this. I recommend that worldio.c looks for .geomview-blah as before, but then = overwrites the sprintf'd string with the char-shorter %s/geomview-blah = and looks again (repeats the iteration) so that it also picks up on the = geomview-blah that geomview is now using. Repeating the block of code is perhaps inelegant, but not breaking = existing modules that have to work across 1.8.1 and 1.8.2 is a lot = neater from a user perspective. cheers, L. <http://www.ee.surrey.ac.uk/Personal/L.Wood/><L....@su...> -----Original Message----- From: geo...@li... on behalf of Steve M. = Robbins Sent: Thu 2006-12-28 5:35 To: Mark Phillips Cc: geo...@li...; 35...@bu... Subject: Re: [geomview-users] dot-files in /usr/lib/geomview trigger = root-kit warnings =20 Hello folks, On Thu, Dec 07, 2006 at 01:02:41AM -0500, Mark Phillips wrote: > Anyway, it's fine with me if someone wants to change the names of = these > files. The simplest thing would be to just drop the initial '.'. = That > would involve changing each external module and/or its Makefile, and > changing the part of Geomview that looks for the files, which is in = the file > src/bin/geomview/commonworldio.c. I have made these changes, and two additional ones, so that no dot-files are installed. =20 The additional changes are: (1) data/.geomview renamed to data/geomview This file is installed into ${datadir} and read at startup, so geomview.sh also changes. (2) data/NDview/scripts/.ndview renamed to data/NDview/scripts/ndview This file is also installed under ${datadir}, and read by src/bin/NDview/NDview, which is therefore also changed. Lots of documentation files also updated. I'm attaching the patch for comments. I'd like to commit this in the coming days, unless there are strong objections. Cheers, -Steve |