Menu

#594 Incorrect commenting for PHP/PHTML file

closed-fixed
nobody
Filetypes (68)
5
2011-10-13
2010-12-04
Brad Wilson
No

Geany 0.19.1 - Ubuntu 10.10 official repo

When trying to comment tags in a PHTML file using Geany's "Toggle Line Commentation" it will use the PHP opening and closing comments (/* and */) instead of the HTML/XML opening and closing comments (<!-- and -->).

Also, if you then try to toggle the comment to "off" it will add another iteration of the PHP style comments instead of un-commenting the existing incorrect PHP comments.

You can reproduce this by trying to comment some tags in the attached file by selecting them and using CTRL-E, and then try to uncomment them by using CTRL-E again.

Not sure if this is a bug or a feature request but it would be really nice and extremely useful if the lexer could distinguish whether or not it was commenting inside a PHP tag and use the appropriate comments.

Thanks much, and please let me know if you need anything else. Love Geany and looking forward to 0.20 being released!

Discussion

  • Brad Wilson

    Brad Wilson - 2010-12-04

    A PHTML file

     
  • Nick Treleaven

    Nick Treleaven - 2010-12-08

    The Scintilla lexer doesn't seem to be recognizing the '?>' token, so never gets reset to HTML. I'll try to test this with the latest Scintilla soon.

     
  • Nick Treleaven

    Nick Treleaven - 2010-12-08
    • summary: Incorrect commenting for PHTML file --> Incorrect commenting for PHP/PHTML file
     
  • Anonymous

    Anonymous - 2011-10-13
    • status: open --> closed-fixed
     

Log in to post a comment.

MongoDB Logo MongoDB