#129 Bookmarks sidebar only caches initial line numbers, so becomes desynched from the actual markers as their lines are moved up or down
The Addons/Bookmarks sidebar only caches the initial line numbers of its source markers. Thus, it erroneously becomes desyncronised from the actual markers as their lines are moved up or down
Tabbing between the markers using the native Ctrl+,. shortcuts jumps properly to the latest line numbers.
The bookmarks plugin documentation implies it should reflect the markers. Thus, it should update as the markers move, to their latest line numbers. This was what I expected but does not happen.
Since automatic real-time refresh during editing might be prohibitively slow for large files being edited, you might prefer to offer an option to refresh either automatically or on-demand. The latter could be offered for example by a toolbar button or a right-click built into the Bookmarks sidebar.
Using latest Geany on Debian 8/LXDE, with no mods except the standard colour themes and Addons installed.
Many thanks
D
Discussion
(If a manual refresh option were added, e.g. for large files with many markers - I think nonetheless it should auto-refresh if they move to the Bookmarks from another sidebar tab.)
Btw I love everything else about Geany so far - I am moving from Windows and was looking for something that would be somewhat like NotePad++, but Geany is already better :-)
Last edit: db0451 2015-09-12
Likely duplicate of this 5-year old report:
http://sourceforge.net/p/geany-plugins/bugs/39/
Previously discussed here, including a programming explanation of why the current line-tracking system is not much use, plus a suggested way to fix it:
http://users.geany.narkive.com/LrzWt2Q7/strange-behavior-of-bookmarks
Thanks for bringing this up again, and also for the investigation of the history of this bug.
I'm going to fix this next week.
Brilliant, thanks!
Last edit: db0451 2015-09-14
I created https://github.com/geany/geany-plugins/pull/284 which attempts to fix the problem.
Testing is welcome if you don't hesitate to build from source.
Thanks, the description sounds great! I'll definitely try to compile and test - hopefully tonight or otherwise the weekend.
Finally built from source! All I had to do was... add Debian testing to apt, grab Geany 1.25, download the old addons src, add the new bookmarks.c, patch the potential null ptr deref mentioned in the pull, & fight autotools for about 30 minutes till it worked... :-)
The good news is that - aside from being a real education in the perils of autotools - I'm now running the latest and greatest Geany with the updated Bookmarks, and certainly everything I've tested so far works perfectly as expected! Geany just got even better!
Thanks for the great help. Probably these are all the updates needed for this, but if you make any more commits and want them tested, I'd be happy to help. Cheers!
Should be fixed now in https://github.com/geany/geany-plugins/commit/38bf4b0f3b25bbb2cd6ef69f132e49d82611f986