[Gdcm-hackers] gdcm-git:Grassroots DICOM branch release updated. ed89ffa392dd8e970527d63cf4c7b15f497f7f29

[malat <ma...@us...>]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Grassroots DICOM".

The branch, release has been updated
       via  ed89ffa392dd8e970527d63cf4c7b15f497f7f29 (commit)
      from  297966a852d8671a363830b52add6ea34e7017b6 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceforge.net/p/gdcm/gdcm/ci/ed89ffa392dd8e970527d63cf4c7b15f497f7f29/

commit ed89ffa392dd8e970527d63cf4c7b15f497f7f29
Author: Sean McBride <se...@ro...>
Date:   Tue Apr 4 21:35:06 2023 -0400

    Auto-fixed all clang-tidy performance-trivially-destructible warnings
    
    They were all already =default, but now they are in the .h, instead of duplicating in the .cxx.

diff --git a/.clang-tidy b/.clang-tidy
index 51fc2a113..af1098919 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -93,7 +93,6 @@ Checks: '-*,
   performance-*,
   -performance-unnecessary-value-param,
   -performance-unnecessary-copy-initialization,
-  -performance-trivially-destructible,
   readability-*,
   -readability-magic-numbers,
   -readability-else-after-return,
diff --git a/Source/DataStructureAndEncodingDefinition/gdcmByteSwapFilter.cxx b/Source/DataStructureAndEncodingDefinition/gdcmByteSwapFilter.cxx
index 9a5267ea5..7b1508f7f 100644
--- a/Source/DataStructureAndEncodingDefinition/gdcmByteSwapFilter.cxx
+++ b/Source/DataStructureAndEncodingDefinition/gdcmByteSwapFilter.cxx
@@ -27,8 +27,6 @@ namespace gdcm
 //{
 //}
 //-----------------------------------------------------------------------------
-ByteSwapFilter::~ByteSwapFilter()
-= default;
 
 bool ByteSwapFilter::ByteSwap()
 {
diff --git a/Source/DataStructureAndEncodingDefinition/gdcmByteSwapFilter.h b/Source/DataStructureAndEncodingDefinition/gdcmByteSwapFilter.h
index ef50ef09d..cd7c84d6e 100644
--- a/Source/DataStructureAndEncodingDefinition/gdcmByteSwapFilter.h
+++ b/Source/DataStructureAndEncodingDefinition/gdcmByteSwapFilter.h
@@ -28,7 +28,7 @@ class GDCM_EXPORT ByteSwapFilter
 {
 public:
   ByteSwapFilter(DataSet& ds):DS(ds),ByteSwapTag(false) {}
-  ~ByteSwapFilter();
+  ~ByteSwapFilter() = default;
   ByteSwapFilter(const ByteSwapFilter &) = delete;
   ByteSwapFilter& operator=(const ByteSwapFilter &) = delete;
 
diff --git a/Source/MediaStorageAndFileFormat/gdcmDictPrinter.cxx b/Source/MediaStorageAndFileFormat/gdcmDictPrinter.cxx
index d0718a84e..5ec8cab61 100644
--- a/Source/MediaStorageAndFileFormat/gdcmDictPrinter.cxx
+++ b/Source/MediaStorageAndFileFormat/gdcmDictPrinter.cxx
@@ -27,9 +27,6 @@ DictPrinter::DictPrinter()
 }
 
 //-----------------------------------------------------------------------------
-DictPrinter::~DictPrinter()
-= default;
-
 VM GuessVMType(DataElement const &de)
 {
   if( de.IsEmpty() ) return VM::VM1;
diff --git a/Source/MediaStorageAndFileFormat/gdcmDictPrinter.h b/Source/MediaStorageAndFileFormat/gdcmDictPrinter.h
index 5287f30f9..39cad5a9a 100644
--- a/Source/MediaStorageAndFileFormat/gdcmDictPrinter.h
+++ b/Source/MediaStorageAndFileFormat/gdcmDictPrinter.h
@@ -27,7 +27,7 @@ class GDCM_EXPORT DictPrinter : public Printer
 {
 public:
   DictPrinter();
-  ~DictPrinter();
+  ~DictPrinter() = default;
 
   void Print(std::ostream& os);
 
diff --git a/Source/MediaStorageAndFileFormat/gdcmDirectionCosines.cxx b/Source/MediaStorageAndFileFormat/gdcmDirectionCosines.cxx
index ee3bd0d94..275d74855 100644
--- a/Source/MediaStorageAndFileFormat/gdcmDirectionCosines.cxx
+++ b/Source/MediaStorageAndFileFormat/gdcmDirectionCosines.cxx
@@ -40,8 +40,6 @@ DirectionCosines::DirectionCosines(const double dircos[6])
   Values[5] = dircos[5];
 }
 
-DirectionCosines::~DirectionCosines() = default;
-
 void DirectionCosines::Print(std::ostream &os) const
 {
   os << Values[0] << ",";
diff --git a/Source/MediaStorageAndFileFormat/gdcmDirectionCosines.h b/Source/MediaStorageAndFileFormat/gdcmDirectionCosines.h
index d03eafb89..73717fdc0 100644
--- a/Source/MediaStorageAndFileFormat/gdcmDirectionCosines.h
+++ b/Source/MediaStorageAndFileFormat/gdcmDirectionCosines.h
@@ -29,7 +29,7 @@ public:
   DirectionCosines(const double dircos[6]);
   // Cannot get the following signature to be wrapped with swig...
   //DirectionCosines(const double *dircos = 0 );
-  ~DirectionCosines();
+  ~DirectionCosines() = default;
 
   /// Print
   void Print(std::ostream &) const;
diff --git a/Source/MediaStorageAndFileFormat/gdcmOrientation.cxx b/Source/MediaStorageAndFileFormat/gdcmOrientation.cxx
index fa70a3d10..836e5ae0a 100644
--- a/Source/MediaStorageAndFileFormat/gdcmOrientation.cxx
+++ b/Source/MediaStorageAndFileFormat/gdcmOrientation.cxx
@@ -19,7 +19,6 @@ namespace gdcm
 {
 
 Orientation::Orientation() = default;
-Orientation::~Orientation() = default;
 
 void Orientation::Print(std::ostream &os) const
 {
diff --git a/Source/MediaStorageAndFileFormat/gdcmOrientation.h b/Source/MediaStorageAndFileFormat/gdcmOrientation.h
index c4d21f636..bced6667f 100644
--- a/Source/MediaStorageAndFileFormat/gdcmOrientation.h
+++ b/Source/MediaStorageAndFileFormat/gdcmOrientation.h
@@ -27,7 +27,7 @@ class GDCM_EXPORT Orientation
   friend std::ostream& operator<<(std::ostream &_os, const Orientation &o);
 public:
   Orientation();
-  ~Orientation();
+  ~Orientation() = default;
 
   /// Print
   void Print(std::ostream &) const;
diff --git a/Source/MediaStorageAndFileFormat/gdcmPrinter.cxx b/Source/MediaStorageAndFileFormat/gdcmPrinter.cxx
index e7464bebc..b7a45fac9 100644
--- a/Source/MediaStorageAndFileFormat/gdcmPrinter.cxx
+++ b/Source/MediaStorageAndFileFormat/gdcmPrinter.cxx
@@ -82,8 +82,6 @@ Printer::Printer():PrintStyle(Printer::VERBOSE_STYLE),F(nullptr)
 }
 
 //-----------------------------------------------------------------------------
-Printer::~Printer()
-= default;
 
 void Printer::SetColor(bool c)
 {
diff --git a/Source/MediaStorageAndFileFormat/gdcmPrinter.h b/Source/MediaStorageAndFileFormat/gdcmPrinter.h
index fa183dc6b..92999178a 100644
--- a/Source/MediaStorageAndFileFormat/gdcmPrinter.h
+++ b/Source/MediaStorageAndFileFormat/gdcmPrinter.h
@@ -60,7 +60,7 @@ class GDCM_EXPORT Printer
 {
 public:
   Printer();
-  ~Printer();
+  ~Printer() = default;
 
   /// Set file
   void SetFile(File const &f) { F = &f; }
diff --git a/Source/MediaStorageAndFileFormat/gdcmSpacing.cxx b/Source/MediaStorageAndFileFormat/gdcmSpacing.cxx
index 3d49cc3c6..e2622a173 100644
--- a/Source/MediaStorageAndFileFormat/gdcmSpacing.cxx
+++ b/Source/MediaStorageAndFileFormat/gdcmSpacing.cxx
@@ -18,8 +18,6 @@ namespace gdcm
 
 Spacing::Spacing() = default;
 
-Spacing::~Spacing() = default;
-
 /*
  * http://www.ics.uci.edu/~eppstein/numth/frap.c
  * http://stackoverflow.com/questions/95727/how-to-convert-floats-to-human-readable-fractions
diff --git a/Source/MediaStorageAndFileFormat/gdcmSpacing.h b/Source/MediaStorageAndFileFormat/gdcmSpacing.h
index f71299ab6..bec72d445 100644
--- a/Source/MediaStorageAndFileFormat/gdcmSpacing.h
+++ b/Source/MediaStorageAndFileFormat/gdcmSpacing.h
@@ -86,7 +86,7 @@ class GDCM_EXPORT Spacing
 {
 public :
   Spacing();
-  ~Spacing();
+  ~Spacing() = default;
 
   // Here are the list of spacing we support:
   // (0018,0088) DS [1.500000]                                         # 8,1 Spacing Between Slices
diff --git a/Utilities/.clang-tidy b/Utilities/.clang-tidy
index ac5701a02..013a3eff9 100644
--- a/Utilities/.clang-tidy
+++ b/Utilities/.clang-tidy
@@ -106,7 +106,6 @@ Checks: '-*,
   performance-*,
   -performance-unnecessary-value-param,
   -performance-unnecessary-copy-initialization,
-  -performance-trivially-destructible,
   -performance-no-int-to-ptr,
   readability-*,
   -readability-magic-numbers,

-----------------------------------------------------------------------

Summary of changes:
 .clang-tidy                                                      | 1 -
 Source/DataStructureAndEncodingDefinition/gdcmByteSwapFilter.cxx | 2 --
 Source/DataStructureAndEncodingDefinition/gdcmByteSwapFilter.h   | 2 +-
 Source/MediaStorageAndFileFormat/gdcmDictPrinter.cxx             | 3 ---
 Source/MediaStorageAndFileFormat/gdcmDictPrinter.h               | 2 +-
 Source/MediaStorageAndFileFormat/gdcmDirectionCosines.cxx        | 2 --
 Source/MediaStorageAndFileFormat/gdcmDirectionCosines.h          | 2 +-
 Source/MediaStorageAndFileFormat/gdcmOrientation.cxx             | 1 -
 Source/MediaStorageAndFileFormat/gdcmOrientation.h               | 2 +-
 Source/MediaStorageAndFileFormat/gdcmPrinter.cxx                 | 2 --
 Source/MediaStorageAndFileFormat/gdcmPrinter.h                   | 2 +-
 Source/MediaStorageAndFileFormat/gdcmSpacing.cxx                 | 2 --
 Source/MediaStorageAndFileFormat/gdcmSpacing.h                   | 2 +-
 Utilities/.clang-tidy                                            | 1 -
 14 files changed, 6 insertions(+), 20 deletions(-)


hooks/post-receive
-- 
Grassroots DICOM