Re: [Gdcm2] gdcm 2.8.2 compile error

[Mathieu M. <mat...@gm...>]

Hi,

On Tue, Aug 29, 2017 at 9:18 AM,  <em...@po...> wrote:
> Hello,
>
> I hope someone could help me with a compilation error that I do get while
> compiling gdcm 2.8.2 on Windows with MSVC 19.10.25019.0. Do I miss some
> configuration or is it realy a bug in the code?
>
> Steps:
> 1. Downloaded and extracted gdcm-2.8.2.tar.gz
> 2. prepared the package with the command:  cmake.exe -G "NMake Makefiles"
> 3. executed compile: nmake
> 4. Compilation stops with following:
>
> [ 13%] Building CXX object
> Source/DataStructureAndEncodingDefinition/CMakeFiles/gdcmDSED.dir/gdcmCSAHeader.cxx.objgdcmCSAHeader.cxx
> j:\opt\var\gdcm-2.8.2_vs64\source\datastructureandencodingdefinition\gdcmCSAHeader.h(80):
> error C2059: syntax error: ''template<''

Right. I think I messed up the syntax for MSVC and deprecated mechanism.

Can you open the file: gdcmCSAHeader.h with your favorite editor, and change:

  GDCM_LEGACY(template <typename TSwap>
  std::istream &Read(std::istream &is));

into:

  template <typename TSwap>
  GDCM_LEGACY(std::istream &Read(std::istream &is));

If this works, you'll need to do the same thing for:

  GDCM_LEGACY(template <typename TSwap>
  const std::ostream &Write(std::ostream &os) const);

into:

  template <typename TSwap>
  GDCM_LEGACY(const std::ostream &Write(std::ostream &os) const);

I am eager to know if this works for you now.

Thanks
-M