[Gdcm-hackers] [ gdcm-Bugs-2974857 ] ZTolerance and sign
Cross-platform DICOM implementation
Brought to you by:
malat
|
From: SourceForge.net <no...@so...> - 2011-12-30 18:36:35
|
Bugs item #2974857, was opened at 2010-03-22 14:29 Message generated for change (Settings changed) made by malat You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=739587&aid=2974857&group_id=137895 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: General (default) >Group: 2.3 Status: Open Resolution: None Priority: 5 Private: No Submitted By: Mathieu Malaterre (malat) Assigned to: Mathieu Malaterre (malat) Summary: ZTolerance and sign Initial Comment: Double definition: Line 30 of: http://gdcm.svn.sourceforge.net/viewvc/gdcm/trunk/Source/MediaStorageAndFileFormat/gdcmIPPSorter.cxx?revision=6507&view=markup and Line 246 of: http://gdcm.svn.sourceforge.net/viewvc/gdcm/trunk/Source/MediaStorageAndFileFormat/gdcmImageHelper.cxx?revision=6507&view=markup Also I'd recommend to change line 251 of gdcmImageHelper.cxx and 181 of gdcmIPPSorter.cxx to something which also test the sign of the difference to be constant. More correctly the whole difference should stay constant within the ZTolerance range (not just it's absolute value). Because now also a dataset with alternating z-positions like 1,2,1,2,1,2,1,2 would be valid. Actually something like this might happen, if some Dicom Stack mixes up temporal and spatial series. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=739587&aid=2974857&group_id=137895 |