#498 Build failure on s390x

[Ankur Sinha]

Hi,

3.0.4 and 3.0.5 both fail to build on Fedora but only on the s390x architecture. The error is:

3.0.5/Utilities -I/builddir/build/BUILD/GDCM-3.0.5/Utilities/socketxx -I/builddir/build/BUILD/GDCM-3.0.5/Utilities/socketxx/socket++ -I/builddir/build/BUILD/GDCM-3.0.5/s390x-redhat-linux-gnu/Utilities/socketxx/socket++  -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -march=zEC12 -mtune=z13 -fasynchronous-unwind-tables -fstack-clash-protection -O2 -g -DNDEBUG -fPIC   -o CMakeFiles/gdcmMEXD.dir/gdcmMovePatientRootQuery.cxx.o -c /builddir/build/BUILD/GDCM-3.0.5/Source/MessageExchangeDefinition/gdcmMovePatientRootQuery.cxx
make[2]: Leaving directory '/builddir/build/BUILD/GDCM-3.0.5/s390x-redhat-linux-gnu'
make[2]: Entering directory '/builddir/build/BUILD/GDCM-3.0.5/s390x-redhat-linux-gnu'
[ 79%] Building CXX object Testing/Source/MediaStorageAndFileFormat/Cxx/CMakeFiles/gdcmMSFFTests.dir/TestImageChangePlanarConfiguration.cxx.o
cd /builddir/build/BUILD/GDCM-3.0.5/s390x-redhat-linux-gnu/Testing/Source/MediaStorageAndFileFormat/Cxx && /usr/bin/c++   -I/builddir/build/BUILD/GDCM-3.0.5/s390x-redhat-linux-gnu/Source/Common -I/builddir/build/BUILD/GDCM-3.0.5/Source/Common -I/builddir/build/BUILD/GDCM-3.0.5/Testing/Source/Data -I/builddir/build/BUILD/GDCM-3.0.5/s390x-redhat-linux-gnu/Testing/Source/Data -I/builddir/build/BUILD/GDCM-3.0.5/Source/DataStructureAndEncodingDefinition -I/builddir/build/BUILD/GDCM-3.0.5/Source/DataDictionary -I/builddir/build/BUILD/GDCM-3.0.5/Source/MediaStorageAndFileFormat  -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -march=zEC12 -mtune=z13 -fasynchronous-unwind-tables -fstack-clash-protection -O2 -g -DNDEBUG   -o CMakeFiles/gdcmMSFFTests.dir/TestImageChangePlanarConfiguration.cxx.o -c /builddir/build/BUILD/GDCM-3.0.5/Testing/Source/MediaStorageAndFileFormat/Cxx/TestImageChangePlanarConfiguration.cxx
/builddir/build/BUILD/GDCM-3.0.5/Testing/Source/MediaStorageAndFileFormat/Cxx/TestImageChangePlanarConfiguration.cxx: In function 'int TestImageChangePlanarConfigurationFunc(const char*, bool)':
/builddir/build/BUILD/GDCM-3.0.5/Testing/Source/MediaStorageAndFileFormat/Cxx/TestImageChangePlanarConfiguration.cxx:124:11: error: 'ByteSwap' is not a member of 'gdcm'
  124 |     gdcm::ByteSwap<unsigned short>::SwapRangeFromSwapCodeIntoSystem(
      |           ^~~~~~~~
/builddir/build/BUILD/GDCM-3.0.5/Testing/Source/MediaStorageAndFileFormat/Cxx/TestImageChangePlanarConfiguration.cxx:124:20: error: expected primary-expression before 'unsigned'
  124 |     gdcm::ByteSwap<unsigned short>::SwapRangeFromSwapCodeIntoSystem(
      |                    ^~~~~~~~
make[2]: *** [Testing/Source/MediaStorageAndFileFormat/Cxx/CMakeFiles/gdcmMSFFTests.dir/build.make:612: Testing/Source/MediaStorageAndFileFormat/Cxx/CMakeFiles/gdcmMSFFTests.dir/TestImageChangePlanarConfiguration.cxx.o] Error 1
make[2]: Leaving directory '/builddir/build/BUILD/GDCM-3.0.5/s390x-redhat-linux-gnu'
make[1]: *** [CMakeFiles/Makefile2:1911: Testing/Source/MediaStorageAndFileFormat/Cxx/CMakeFiles/gdcmMSFFTests.dir/all] Error 2

The build task for 3.0.5 is here, but since it's a scratch build and will be deleted soon. So, I'll upload the build log files also:

https://koji.fedoraproject.org/koji/taskinfo?taskID=41527333

The bug is here, with the log file attached to it:
https://bugzilla.redhat.com/show_bug.cgi?id=1756429

Cheers,
Ankur

[Mathieu Malaterre]

Works fine on Debian buildds:

• https://buildd.debian.org/status/fetch.php?pkg=gdcm&arch=s390x&ver=3.0.5-1.1&stamp=1585249555&raw=0

[Mathieu Malaterre]

oh I see the issue now: see commit 858143e454