Re: [Gc-linux-cvs] linux/arch/ppc/platforms gamecube.c,1.28,1.29

[<a.o...@bl...>]

On Fri, Jan 07, 2005 at 03:34:35PM -0800, he...@us... wrote:
> Update of /cvsroot/gc-linux/linux/arch/ppc/platforms
> In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv14169
> 
> Modified Files:
> 	gamecube.c 
> Log Message:
> Add kexec ppc hooks.
> We still have no kexec on mainline, but will soon.
> 
> 
> Index: gamecube.c
> ===================================================================
> RCS file: /cvsroot/gc-linux/linux/arch/ppc/platforms/gamecube.c,v
> retrieving revision 1.28
> retrieving revision 1.29
> diff -u -d -r1.28 -r1.29
> --- gamecube.c	6 Jan 2005 19:57:53 -0000	1.28
> +++ gamecube.c	7 Jan 2005 23:34:32 -0000	1.29
> @@ -158,6 +158,20 @@
>  #endif
>  }
>  
> +#ifdef CONFIG_KEXEC
> +void gamecube_shutdown(void)
> +{
> +	/* currently not used */
> +}
> +
> +int gamecube_kexec_prepare(struct kimage *image)
> +{
> +	int retval = 0;
> +
> +	return retval;
> +}
> +#endif /* CONFIG_KEXEC */
> +

Since these are not referenced outside this file (yet?), they should
be defined static, no? Think namespace pollution ...

	Arthur