From: Andy S. <an...@ee...> - 2007-10-21 01:16:23
|
FYI: This feature also allows to implement theme related session / user / group preferences. E.g. a theme selector just like the language selector. (i.e. joe7 could implement the theme selector on the theme demo site as a module instead of hacking core) I'm sure we'll see some modules using the new event soon enough. - Andy Andy Staudacher wrote: > The event / feature has been added. > > Docs: > http://codex.gallery2.org/Gallery2:Theme_Override_By_Event > http://codex.gallery2.org/Gallery2:Embedding:Integration#Embed > ded_Theme_vs_S > tandalone_Theme > > Modules using this event require core API 7.40, integrations > require embed API 1.3. > > - Andy > > > Andy Staudacher wrote: > > @floridave: thanks for your feedback! > > > > @integrators (wpg2, drupal, phpbb, joomla, ...): > > The code is ready to be committed. > > Can you live with this API or do you need something else? > > > > - Andy > > > > Tim Almdal wrote: > > > I think this url works better: > > > > > > > > > http://reviews.gallery2.org/index.jsp?page=ReviewDisplay&reviewid=402 > > > > > > Tim > > > > > > Andy Staudacher wrote: > > > > I've drafted a patch that allows integrations and modules > > > to override > > > > the theme and its parameters for all pages. > > > > > > > > I've started a discussion in the corresponding code > > review and I'm > > > > looking forward to getting some feedback to make sure > > that this API > > > > change covers the common use cases. > > > > > > > > See: > > > > http://reviews.gallery2.org/index.jsp?reviewid=402 > > > > > > > > It's based on 2 recent core API changes: > > > > - Jack's lightweight event system refactoring: Posting > events is > > > > considered to be less resource intensive now. > > > > - Tim's registerFactoryImplementationForRequest(), allowing to > > > > register event handlers for embed requests only (cheap > > > in-memory operations). > > > > > > > > - Andy |