From: Jack B. <ms...@fr...> - 2007-08-24 01:12:14
|
Awesome, thanks Uday. Thanks for creating the review. Unfortunately, attaching a diff to a review doesn't currently display your changes correctly. I think this has something to do with Code Collaborator's integration with our revision control system. I also attached diffs to my first review; maybe Code Collaborator will support this in future. Meanwhile, you need to follow the instructions in codex for adding your changes using the Code Collaborator tool: http://codex.gallery2.org/Gallery2:CodeReviewTips Thanks for making all the style changes. Please update your codex page with instructions for installing your project: http://codex.gallery2.org/Gallery2:Image_Manipulation Jack > Hi Mr.Jack, > i added all diff files in gallery-contrib , please have a look at those > and let me know any further changes needed in those , i added sql > script needed in that same svn repository, i added some code to Review > system have you seen those . i will add remaining files to review > system also before i proceed let me know if procedure i followed for > adding first 2 files is correct ? >=20 > Thanks, > Uday |