From: Alan H. <ala...@su...> - 2006-08-24 04:15:48
|
Short summary: Phpdoc cleanup, tested with PHP 5.2.0RC2, some small bugfixes. * Phpdoc cleanup - Looked at bharat's setup for building phpdoc - Got more recent version of phpdoc and committed to vendor branch on gmc svn - Made copy in svn for our usage, made a few small changes in setup files and output templates - Wrote a perl script to do preprocessing on files, so we only need one docblock at the top of each file and it will apply to the file and the class - Performed phpdoc and whitespace cleanup across G2 svn - New setup now in use, http://gallery.menalto.com/apidoc/index.html - Total line count of php/class/inc files dropped by 7044 lines from start to end of this cleanup (some other commits in there too, including removing some obsolete code found in this cleanup) * Other G2 - Problem with PHP 5.2.0RC* was reported in the forums, so I compiled RC2; confirmed the problem, tracked it down to a PHP bug and reported that to php-qa. Should be fixed in 5.2.0 final! - Made 2 small changes so unit tests work on PHP 5.2.0 (unit test code can't cast object to string; a watermark test needed clearstatcache) - Renamed digibug.PrintPhotos view so class name doesn't conflict with shutterfly (caused unit test failure when both were run) - Fix references to shutterfly in digibug/photoworks - No plugins use $ret->wrap anymore, so ensure all require Core API 7.4 or higher - Bug #1468797 - redirect to root album if rewritten URL is accessed but rewrite module not active - Add $storage->checkPoint in a couple places to help with large deletes - Use vsprintf instead of call_user_func_array('sprintf' (2 places) - UserLogin: always set $form.returnUrl so tpl doesn't complain if a link here doesn't have g2_return param - Some fixes for right-to-left languages in albumselect and floatrix - Small api addition for GalleryTranslator::translateDomain - Ran unit tests on PHP 4.3.0 and 5.1.5-mysqli * Code reviews - Locked user (Signe) - User album permissions (virshu) - Imageblock album+maxSize (bharat) |