From: Alan H. <ala...@su...> - 2006-07-26 20:12:20
|
hi- i did a quick first-pass review. looks pretty good, though I didn't examine all the regexp and array juggling in the SearchUtilities class in any detail. http://tools.gallery2.org/pastebin/672 please post a new diff after going over this, and we can get this into svn. bharat, any comment on the SearchUtilities::doAndSearch function? it's currently hardcoded to true. - Alan Georg Rehfeld wrote: > Hi all, > > - updated all DB tests to not expect case insensivity searches any more > - added some more tests > >> Please find the patch as text, compressed archive and zipped at: >> >> http://georg-rehfeld.de/test/and_search_patch.txt >> http://georg-rehfeld.de/test/and_search_patch.tgz >> http://georg-rehfeld.de/test/and_search_patch.zip > > regards, Georg |