Re: [Galeon-devel] Re: Embed abstraction borked ?

[Marco P. G. <ma...@it...>]

On Tue, 2002-06-25 at 22:05, Ricardo Fern=E1ndez Pascual wrote:
> El mar, 25-06-2002 a las 21:56, Marco Pesenti Gritti escribi=F3:
>=20
> > I should have probably looked at the code before, but you know how lazy
> > I am ;)
>=20
> I should write docs. Not sure if the code is very easy to follow without
> at least a description of what does each class.

I should do it too. I wonder if documenting our apis with gtk docs would
worth.

> > This sounds good to me but I think src/ is not a good place then. I
> > think it should be moved to utils or to embed.
>=20
> Agreed. Utils looks like the best place for me.
>=20
> >=20
> > I think ideally to have a good level of abstraction it should be
> > possible to build an alternative interface using just libutils and
> > libembed. This is now borked by two cases:
> > 1 This autocompletion thing
>=20
> Feel free to move everything to utils. If you don't do it, I'll do once
> I'm again coding.
>=20

It's not urgent :)

> > 2 Philip is accessing GaleonWindow from sidebar code.
>=20
> No idea about why he needs to do this... Maybe we just have to extend
> the interface somehow. But I have not looked at that code at all.
>=20

Well the sidebar is per window, and you need to access it to be able to
add mozilla sidebars inside it.
We are using IS_GALEON_WINDOW, this works to not break nautilus view,
but you couldnt build the nautilus view in a separate executable anymore
without some defines.

> > I dont know how we should behave about these.
> > I dont feel strongly, no alternative ui is planned, so we could just
> > live with it ... but really we should try to not make these cases more
> > than 2-3. Otherwise we break things that could be cool to do in the
> > future ... like a separate nautilus-view executable ... I know it's not
> > planned but I think it's worth to not close the alternative.
> >=20
> > What do you think ?
>=20
> I fully agree with you here :)
>=20

Heh good :)

Marco